Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Sean McGovern <gseanmcg@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] fate: fix sub2video_{basic, time_limited} on big-endian targets
Date: Fri, 8 Mar 2024 10:11:59 -0500
Message-ID: <CAPBf_O=4KTeCa3jUTSNGtue7frCFPY6tKQFo-Rfmfcyfj4OdHA@mail.gmail.com> (raw)
In-Reply-To: <20240306234837.19083-1-gseanmcg@gmail.com>

On Wed, Mar 6, 2024, 18:48 Sean McGovern <gseanmcg@gmail.com> wrote:

> The reference file uses BGRA pixel format, so request it here.
> ---
>  tests/fate/ffmpeg.mak | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/tests/fate/ffmpeg.mak b/tests/fate/ffmpeg.mak
> index 669c878c7f..77e93693b9 100644
> --- a/tests/fate/ffmpeg.mak
> +++ b/tests/fate/ffmpeg.mak
> @@ -62,6 +62,7 @@ fate-sub2video: CMD = framecrc -auto_conversion_filters \
>  FATE_SAMPLES_FFMPEG-$(call FRAMECRC, VOBSUB, DVDSUB, SCALE_FILTER) +=
> fate-sub2video_basic
>  fate-sub2video_basic: CMD = framecrc -auto_conversion_filters \
>    -i $(TARGET_SAMPLES)/sub/vobsub.idx \
> +  -pix_fmt bgra \
>    -fps_mode passthrough -copyts \
>    -filter_complex "sws_flags=+accurate_rnd+bitexact\;[0:s:0]scale" \
>    -c:v rawvideo -threads 1
> @@ -71,6 +72,7 @@ fate-sub2video_basic: CMD = framecrc
> -auto_conversion_filters \
>  FATE_SAMPLES_FFMPEG-$(call FRAMECRC, SUP, PGSSUB, SCALE_FILTER
> RAWVIDEO_ENCODER) += fate-sub2video_time_limited
>  fate-sub2video_time_limited: CMD = framecrc -auto_conversion_filters \
>    -i $(TARGET_SAMPLES)/sub/pgs_sub.sup \
> +  -pix_fmt bgra \
>    -fps_mode passthrough -copyts \
>    -t 15 \
>    -filter_complex "sws_flags=+accurate_rnd+bitexact\;[0:s:0]scale" \
> --
> 2.39.2
>

Ping review, if someone has some cycle.

-- Sean McGovern
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2024-03-08 15:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-06 23:48 Sean McGovern
2024-03-08 15:11 ` Sean McGovern [this message]
2024-03-25 22:07   ` Sean McGovern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPBf_O=4KTeCa3jUTSNGtue7frCFPY6tKQFo-Rfmfcyfj4OdHA@mail.gmail.com' \
    --to=gseanmcg@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git