From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B9E3043076 for ; Tue, 19 Jul 2022 07:26:11 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BF83A68B5DD; Tue, 19 Jul 2022 10:26:08 +0300 (EEST) Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 068F968B5CB for ; Tue, 19 Jul 2022 10:26:01 +0300 (EEST) Received: by mail-ed1-f43.google.com with SMTP id m16so18367212edb.11 for ; Tue, 19 Jul 2022 00:26:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=qUaRHj0L0QUwOnlNZeETdHuN2MEtKuow7WWW1+wYo80=; b=gBY5XaMwIGBlz+RnTHzgJa/isXuq4/TRyDXuBL+GX/9fX9XTvNR8UIlXfBzmn1Sn7M p01Yc5SQ7GhOIRwlvTmKwBw554BeVKzIJLYs+quosysRjTUa0UWq/JttmsN0dXoVdC7n ANx0y6oJMwPJJXG3WfRDGYs72Eyq4n33lOLJoG+zQToVMxnIQswzcI6kMZUl17GURIOM nVYh9jaEJ8/GRXbX1xLf5tp76PBvmbCl6jyVaG1mUpM1C3WyLsvm0xpPLdyG2s/QN2sP /HQ66p6mFHCoxPo3LULGNvOtZLAlmiSm6CM3mkHCV0FwNpJszfB+P0Vu9ab/x/ONkq1c SAdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=qUaRHj0L0QUwOnlNZeETdHuN2MEtKuow7WWW1+wYo80=; b=Sjn3NLBv++9PEd1ft6k0nWCzAhgPY3YBV394W1nNbBeZHK1mk4xBYDE/jK+dGwsvmz sY7IJgTpx34bZOiIiMawrsctT9bpR8aAKFfPGWxrW3+rMCWoMTv0YJr//yhmFfy+p7d8 krxFs+hb80eOK6UNwG+3fu8C8UvpoCj3iYvW0TvUHaKB7D160Ebs1t/VS+rr0NRvoj/i fMalmSJIIxdMLve3sNR6b863UcW9a26UXRdHDBop7rk1AVRtUWJ2tcXrlr/wd+56tKBD HIEu9Wk34VUtmcNNFligDKkDmy4JexN80Cz1BIIi8WoBA9Wm4T8jf1+xKIe0E4yz8JZY ho0A== X-Gm-Message-State: AJIora+G8JWReOqeE/c/kTSA1DQ6XQbrLwtDel1YKBVpBsek9yz42BEG hX/5IvmKwu2GzBKhHP7mhgPdq388GbyVgmsONj/Fqrbc X-Google-Smtp-Source: AGRyM1tHoj/1xM5olkFnkm++UKKFHSbWMQKyd5m1s9qe2NhidfhnWcdXkvkwFz6vAtwBnTwNSLhz5WUYsgEX5uk9Ul8= X-Received: by 2002:a05:6402:54:b0:43b:5cbd:d5db with SMTP id f20-20020a056402005400b0043b5cbdd5dbmr15782640edu.264.1658215561264; Tue, 19 Jul 2022 00:26:01 -0700 (PDT) MIME-Version: 1.0 References: <20220708225404.23748-1-timo@rothenpieler.org> <952b21f7-29c5-3d90-f85b-703eaa1e0904@rothenpieler.org> In-Reply-To: <952b21f7-29c5-3d90-f85b-703eaa1e0904@rothenpieler.org> From: Mark Himsley Date: Tue, 19 Jul 2022 08:25:50 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH v2 0/8] ddagrab source filter, lavfi.c wrapped_avframe and dependent changes X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sun, 17 Jul 2022 at 12:37, Timo Rothenpieler wrote: > > I will push this series tonight, in about 8 hours from now. > Last chance to delay this by reviewing or raising related concerns. Just FYI - this broke my nightly automated builds - which cross-compile on Linux for Windows. x86_64-w64-mingw32-gcc -I. -I./ --static -static -static-libstdc++ -static-libgcc -DPTW32_STATIC_LIB -D_WIN32_WINNT=0x0600 -I/opt/ffbuild/include -D_ISOC99_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -U__STRICT_ANSI__ -D__USE_MINGW_ANSI_STDIO=1 -D__printf__=__gnu_printf__ -D_POSIX_C_SOURCE=200112 -D_XOPEN_SOURCE=600 -DPIC -DOPJ_STATIC -DZLIB_CONST -DHAVE_AV_CONFIG_H -DBUILDING_avfilter --static -static -static-libstdc++ -static-libgcc -DPTW32_STATIC_LIB -D_WIN32_WINNT=0x0600 -I/opt/ffbuild/include --static -static -static-libstdc++ -static-libgcc -DPTW32_STATIC_LIB -D_WIN32_WINNT=0x0600 -std=c11 -fomit-frame-pointer -pthread -I/opt/ffbuild/include -I/opt/ffbuild/include -I/opt/ffbuild/include -I/opt/ffbuild/include/freetype2 -I/opt/ffbuild/include -I/opt/ffbuild/include/libpng14 -I/opt/ffbuild/include/openjpeg-2.4 -I/opt/ffbuild/include/opus -I/opt/ffbuild/include/opus -I/opt/ffbuild/include -I/opt/ffbuild/include -I/opt/ffbuild/include/srt -I/opt/ffbuild/include -I/opt/ffbuild/include -I/opt/ffbuild/include -I/opt/ffbuild/include -I/opt/ffbuild/include -I/opt/ffbuild/include -I/opt/ffbuild/include -I/opt/ffbuild/include -I/opt/ffbuild/include -I/opt/ffbuild/include -DLIBXML_STATIC -I/opt/ffbuild/include/libxml2 -I/opt/ffbuild/include -g -Wdeclaration-after-statement -Wall -Wdisabled-optimization -Wpointer-arith -Wredundant-decls -Wwrite-strings -Wtype-limits -Wundef -Wmissing-prototypes -Wstrict-prototypes -Wempty-body -Wno-parentheses -Wno-switch -Wno-format-zero-length -Wno-pointer-sign -Wno-unused-const-variable -Wno-bool-operation -Wno-char-subscripts -O3 -fno-math-errno -fno-signed-zeros -fno-tree-vectorize -Werror=format-security -Werror=implicit-function-declaration -Werror=missing-prototypes -Werror=return-type -Werror=vla -Wformat -fdiagnostics-color=auto -Wno-maybe-uninitialized -MMD -MF libavfilter/vsrc_ddagrab.d -MT libavfilter/vsrc_ddagrab.o -c -o libavfilter/vsrc_ddagrab.o libavfilter/vsrc_ddagrab.c libavfilter/vsrc_ddagrab.c: In function 'init_dxgi_dda': libavfilter/vsrc_ddagrab.c:157:36: error: expected declaration specifiers or '...' before '*' token 157 | typedef DPI_AWARENESS_CONTEXT (*set_thread_dpi_t)(DPI_AWARENESS_CONTEXT); | ^ libavfilter/vsrc_ddagrab.c:158:5: error: unknown type name 'set_thread_dpi_t' 158 | set_thread_dpi_t set_thread_dpi; | ^~~~~~~~~~~~~~~~ libavfilter/vsrc_ddagrab.c:200:23: error: 'set_thread_dpi_t' undeclared (first use in this function); did you mean 'set_thread_dpi'? 200 | set_thread_dpi = (set_thread_dpi_t)dlsym(user32_module, "SetThreadDpiAwarenessContext"); | ^~~~~~~~~~~~~~~~ | set_thread_dpi libavfilter/vsrc_ddagrab.c:200:23: note: each undeclared identifier is reported only once for each function it appears in libavfilter/vsrc_ddagrab.c:200:40: error: expected ';' before 'GetProcAddress' 200 | set_thread_dpi = (set_thread_dpi_t)dlsym(user32_module, "SetThreadDpiAwarenessContext"); | ^ | ; libavfilter/vsrc_ddagrab.c:206:9: error: unknown type name 'DPI_AWARENESS_CONTEXT' 206 | DPI_AWARENESS_CONTEXT prev_dpi_ctx; | ^~~~~~~~~~~~~~~~~~~~~ libavfilter/vsrc_ddagrab.c:215:39: error: 'DPI_AWARENESS_CONTEXT_PER_MONITOR_AWARE_V2' undeclared (first use in this function) 215 | prev_dpi_ctx = set_thread_dpi(DPI_AWARENESS_CONTEXT_PER_MONITOR_AWARE_V2); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ libavfilter/vsrc_ddagrab.c:215:24: error: called object 'set_thread_dpi' is not a function or function pointer 215 | prev_dpi_ctx = set_thread_dpi(DPI_AWARENESS_CONTEXT_PER_MONITOR_AWARE_V2); | ^~~~~~~~~~~~~~ libavfilter/vsrc_ddagrab.c:158:22: note: declared here 158 | set_thread_dpi_t set_thread_dpi; | ^~~~~~~~~~~~~~ libavfilter/vsrc_ddagrab.c:229:13: error: called object 'set_thread_dpi' is not a function or function pointer 229 | set_thread_dpi(prev_dpi_ctx); | ^~~~~~~~~~~~~~ libavfilter/vsrc_ddagrab.c:158:22: note: declared here 158 | set_thread_dpi_t set_thread_dpi; | ^~~~~~~~~~~~~~ [0m [91mlibavfilter/vsrc_ddagrab.c:233:24: warning: assignment to 'int' from 'void *' makes integer from pointer without a cast [-Wint-conversion] 233 | set_thread_dpi = NULL; | ^ libavfilter/vsrc_ddagrab.c:239:24: warning: assignment to 'int' from 'void *' makes integer from pointer without a cast [-Wint-conversion] 239 | set_thread_dpi = NULL; | ^ make: *** [ffbuild/common.mak:81: libavfilter/vsrc_ddagrab.o] Error 1 -- Mark Himsley _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".