From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id C69244C548 for <ffmpegdev@gitmailbox.com>; Sat, 5 Apr 2025 07:58:07 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 485F968B172; Sat, 5 Apr 2025 10:58:03 +0300 (EEST) Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CE1B7687D8F for <ffmpeg-devel@ffmpeg.org>; Sat, 5 Apr 2025 10:57:56 +0300 (EEST) Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-30beedb99c9so25000341fa.3 for <ffmpeg-devel@ffmpeg.org>; Sat, 05 Apr 2025 00:57:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743839876; x=1744444676; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=gtP5DzxXNTkBS8XysH2XZCwjPTg0xQIT+Bfrpl5qn4A=; b=gGI4nPV0Qda2O17kHO4uJGli10AFipqb1LWL8tys5oO1M9Qs/1P3V3u1qI2RgESb0/ BY6Q7TeKtpypSZTGlfyu239EVFQJFocCu7wv+PReDbAZjejU/zbrt3XWuxtClH4XOfMo r1D+8RgPKnDdNmR9dOCT44ee8R2RV2iKeaU1/JgjJB3tn/pYzR7EZHpa8OIPd+PNeYEH IFWtRJGwfPXShPhV6XJfPzPdqMwSG76sur3nvIGxhLGDeSgTBqb0EX92yLqnTVtFwc1J 5spEyV0soo/OOOEIMt12rrF3LEVuTLjl6j2ZsUlrDUsHvtOPQNgRl+dkmXKbsZoEO1+v 6Mrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743839876; x=1744444676; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gtP5DzxXNTkBS8XysH2XZCwjPTg0xQIT+Bfrpl5qn4A=; b=jLYivgbRaGUTaLkOij7paPV4z79oNn/hdVJi7ieNmOSmJGGTqU0VbSHXOZexf1z3jI VJAxSH6cFyk8t2JwvbOcfUjp14yB8qisaSzbx/6+tis5/uSg2KEiqNrhfNwbf6bzX+qD GgFiCsvMsKW8JHJMCsLSBbxtGWSuM16cozUl+iJ+hMhz5NGVV1IXdcKnOy6KztwaaKR+ eDkayQ4HPnByeBCXlltyRegEWRiCt3pr67txz1kZvL9++w0Qv0t9YOxgjvDyhS6MSh7j BDWTTtoMk4rm/EHAL18dkK8rWu4Z2QdEHhXXki8uvbTah7q6yAL/vSqeD1P7DDXnHNre CRcg== X-Gm-Message-State: AOJu0YxYXmGIefW8AlHFIcFFXinYevmQ9sW2jNfAbVuf6Qon2rvMHJim uSbcaIqnFPoNd5bfqznfMf5BalhoTNrwewxYjgpo934PxShlNnPGnQoot03/0k3AhbI3U+ok9ZY as1hfSCJ3IQ3KQf2ry3MjBMoEyUbjsxkP X-Gm-Gg: ASbGncsH6iKwPLKhrzXCGVHTb43I400zenK3gFywG3EKE6PC8NvkliuOEpmO0bguPtf QuAONXEnCXpLouhZC70AsWGFAExRl5oMdARXn37d0tD9SEMwbIDGrTli7fP228cvCwPr9Wvfa4C 58UwZYX/vm0XGRF2pxMMlXFhMI2mA7EwEsJU7S X-Google-Smtp-Source: AGHT+IEO5iCWaLs8+08nZZ5S0FvEFfVXT2LHNW3rtxBEzlRPoM+S0vw+uPm+lNStE7d4325dqAm9QtI/OxDdDDDdPVU= X-Received: by 2002:a05:651c:1447:b0:30b:f24a:651a with SMTP id 38308e7fff4ca-30f164f5688mr5352271fa.5.1743839875612; Sat, 05 Apr 2025 00:57:55 -0700 (PDT) MIME-Version: 1.0 References: <20250404092402.54430-4-alexander.bladh@gmail.com> <20250404233723.GB4991@pb2> In-Reply-To: <20250404233723.GB4991@pb2> From: Alexander bladh <alexander.bladh@gmail.com> Date: Sat, 5 Apr 2025 09:57:44 +0200 X-Gm-Features: ATxdqUE3Ss2e0dcsdDDPIAeoHYU0BGEzzMHml_KM7gcCJZp4G6Swl8nCyICZWAE Message-ID: <CAOyJSgqTKwwSr-g00v8KP7hz1ACvE5up_S5GZ1ibMKgWiB0bpw@mail.gmail.com> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] libavformat/matroskadec: Add support for chapter segment UUID and edition UID X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> Archived-At: <https://master.gitmailbox.com/ffmpegdev/CAOyJSgqTKwwSr-g00v8KP7hz1ACvE5up_S5GZ1ibMKgWiB0bpw@mail.gmail.com/> List-Archive: <https://master.gitmailbox.com/ffmpegdev/> List-Post: <mailto:ffmpegdev@gitmailbox.com> Sorry, must have messed something up when running the tests locally. I will also check the warning. New contributor here, I have been looking at this issue for years now so I thought I would try to contribute. https://trac.ffmpeg.org/ticket/3123 My plan is * Read the extra data needed to support ordered chapters * Add some data structure tracking external files * Add an option to search for external segment with related discovery logic * Implement reading and seeking through external segments Let me know if you have any feedback. Regards, Alexander On Sat, 5 Apr 2025 at 01:37, Michael Niedermayer <michael@niedermayer.cc> wrote: > On Fri, Apr 04, 2025 at 11:24:05AM +0200, Alexander Westberg-Bladh wrote: > > This adds support for parsing ChapterSegmentUID and > ChapterSegmentEditionUID > > elements in Matroska chapters. These elements are used in ordered > chapters > > to reference external files see #3123. > > > > Signed-off-by: Alexander Westberg-Bladh <alexander.bladh@gmail.com> > > --- > > libavformat/matroska.h | 3 +++ > > libavformat/matroskadec.c | 32 ++++++++++++++++++++------------ > > 2 files changed, 23 insertions(+), 12 deletions(-) > > breaks fate-h264-direct-bff > > ==3402053== Invalid read of size 8 > ==3402053== at 0x126DCE6: av_buffer_realloc (in ffmpeg/ffmpeg_g) > ==3402053== by 0x67E927: ebml_parse (in ffmpeg/ffmpeg_g) > ==3402053== by 0x67EC84: ebml_parse (in ffmpeg/ffmpeg_g) > ==3402053== by 0x67EC84: ebml_parse (in ffmpeg/ffmpeg_g) > ==3402053== by 0x67F421: matroska_read_header (in ffmpeg/ffmpeg_g) > ==3402053== by 0x625A1E: avformat_open_input (in ffmpeg/ffmpeg_g) > ==3402053== by 0x3054D4: ifile_open (in ffmpeg/ffmpeg_g) > ==3402053== by 0x31C417: open_files.isra.0 (in ffmpeg/ffmpeg_g) > ==3402053== by 0x31E3F5: ffmpeg_parse_options (in ffmpeg/ffmpeg_g) > ==3402053== by 0x2FCD77: main (in ffmpeg/ffmpeg_g) > ==3402053== Address 0x118dd288 is 0 bytes after a block of size 1,672 > alloc'd > ==3402053== at 0x483E0F0: memalign (in > /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so) > ==3402053== by 0x483E212: posix_memalign (in > /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so) > ==3402053== by 0x128A524: av_malloc (in ffmpeg/ffmpeg_g) > ==3402053== by 0x128A6ED: av_mallocz (in ffmpeg/ffmpeg_g) > ==3402053== by 0x625DC4: avformat_open_input (in ffmpeg/ffmpeg_g) > ==3402053== by 0x3054D4: ifile_open (in ffmpeg/ffmpeg_g) > ==3402053== by 0x31C417: open_files.isra.0 (in ffmpeg/ffmpeg_g) > ==3402053== by 0x31E3F5: ffmpeg_parse_options (in ffmpeg/ffmpeg_g) > ==3402053== by 0x2FCD77: main (in ffmpeg/ffmpeg_g) > > > [...] > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > No great genius has ever existed without some touch of madness. -- > Aristotle > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".