[FFmpeg-devel] [PATCH] avcodec/mediacodecdec: replace memset with direct zero init

[FFmpeg-devel] [PATCH] avcodec/mediacodecdec: replace memset with direct zero init

[Zhao Zhili]

From: Zhao Zhili <zhilizhao@tencent.com>

---
 libavcodec/mediacodecdec.c | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/libavcodec/mediacodecdec.c b/libavcodec/mediacodecdec.c
index 4937828f21..ea9362ba85 100644
--- a/libavcodec/mediacodecdec.c
+++ b/libavcodec/mediacodecdec.c
@@ -133,14 +133,12 @@ static int h264_set_extradata(AVCodecContext *avctx, FFAMediaFormat *format)
     int i;
     int ret;
 
-    H264ParamSets ps;
+    H264ParamSets ps = {0};
     const PPS *pps = NULL;
     const SPS *sps = NULL;
     int is_avc = 0;
     int nal_length_size = 0;
 
-    memset(&ps, 0, sizeof(ps));
-
     ret = ff_h264_decode_extradata(avctx->extradata, avctx->extradata_size,
                                    &ps, &is_avc, &nal_length_size, 0, avctx);
     if (ret < 0) {
@@ -199,8 +197,8 @@ static int hevc_set_extradata(AVCodecContext *avctx, FFAMediaFormat *format)
     int i;
     int ret;
 
-    HEVCParamSets ps;
-    HEVCSEI sei;
+    HEVCParamSets ps = {0};
+    HEVCSEI sei = {0};
 
     const HEVCVPS *vps = NULL;
     const HEVCPPS *pps = NULL;
@@ -215,9 +213,6 @@ static int hevc_set_extradata(AVCodecContext *avctx, FFAMediaFormat *format)
     int sps_data_size = 0;
     int pps_data_size = 0;
 
-    memset(&ps, 0, sizeof(ps));
-    memset(&sei, 0, sizeof(sei));
-
     ret = ff_hevc_decode_extradata(avctx->extradata, avctx->extradata_size,
                                    &ps, &sei, &is_nalff, &nal_length_size, 0, 1, avctx);
     if (ret < 0) {
-- 
2.46.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/mediacodecdec: replace memset with direct zero init

[Matthieu Bouron]

On Thu, Jun 12, 2025 at 5:33 PM Zhao Zhili
<quinkblack-at-foxmail.com@ffmpeg.org> wrote:
>
> From: Zhao Zhili <zhilizhao@tencent.com>
>
> ---
>  libavcodec/mediacodecdec.c | 11 +++--------
>  1 file changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/libavcodec/mediacodecdec.c b/libavcodec/mediacodecdec.c
> index 4937828f21..ea9362ba85 100644
> --- a/libavcodec/mediacodecdec.c
> +++ b/libavcodec/mediacodecdec.c
> @@ -133,14 +133,12 @@ static int h264_set_extradata(AVCodecContext *avctx, FFAMediaFormat *format)
>      int i;
>      int ret;
>
> -    H264ParamSets ps;
> +    H264ParamSets ps = {0};
>      const PPS *pps = NULL;
>      const SPS *sps = NULL;
>      int is_avc = 0;
>      int nal_length_size = 0;
>
> -    memset(&ps, 0, sizeof(ps));
> -
>      ret = ff_h264_decode_extradata(avctx->extradata, avctx->extradata_size,
>                                     &ps, &is_avc, &nal_length_size, 0, avctx);
>      if (ret < 0) {
> @@ -199,8 +197,8 @@ static int hevc_set_extradata(AVCodecContext *avctx, FFAMediaFormat *format)
>      int i;
>      int ret;
>
> -    HEVCParamSets ps;
> -    HEVCSEI sei;
> +    HEVCParamSets ps = {0};
> +    HEVCSEI sei = {0};
>
>      const HEVCVPS *vps = NULL;
>      const HEVCPPS *pps = NULL;
> @@ -215,9 +213,6 @@ static int hevc_set_extradata(AVCodecContext *avctx, FFAMediaFormat *format)
>      int sps_data_size = 0;
>      int pps_data_size = 0;
>
> -    memset(&ps, 0, sizeof(ps));
> -    memset(&sei, 0, sizeof(sei));
> -
>      ret = ff_hevc_decode_extradata(avctx->extradata, avctx->extradata_size,
>                                     &ps, &sei, &is_nalff, &nal_length_size, 0, 1, avctx);
>      if (ret < 0) {
> --

LGTM.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".