From: James Almer <jamrial@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffplay: use correct buffersink channel layout parameters
Date: Mon, 18 Mar 2024 17:31:29 -0300
Message-ID: <CAOZuJMjr6RYJ8gvVUjnqDfHxK0gVvaN6+opZuUuj=cF84-houQ@mail.gmail.com> (raw)
In-Reply-To: <20240318202000.24745-1-cus@passwd.hu>
LGTM if tested. Sorry for the breakage.
Please backport it to all the relevant release branches too.
On Mon, Mar 18, 2024 at 5:20 PM Marton Balint <cus@passwd.hu> wrote:
> Regression since 0995e1f1b31f6e937a1b527407ed3e850f138098.
>
> Signed-off-by: Marton Balint <cus@passwd.hu>
> ---
> fftools/ffplay.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fftools/ffplay.c b/fftools/ffplay.c
> index 09b4846deb..fcd1319ce7 100644
> --- a/fftools/ffplay.c
> +++ b/fftools/ffplay.c
> @@ -2040,6 +2040,8 @@ static int configure_audio_filters(VideoState *is,
> const char *afilters, int for
> goto end;
>
> if (force_output_format) {
> + av_bprint_clear(&bp);
> + av_channel_layout_describe_bprint(&is->audio_tgt.ch_layout, &bp);
> sample_rates [0] = is->audio_tgt.freq;
> if ((ret = av_opt_set_int(filt_asink, "all_channel_counts", 0,
> AV_OPT_SEARCH_CHILDREN)) < 0)
> goto end;
> --
> 2.35.3
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-03-18 20:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-18 20:20 Marton Balint
2024-03-18 20:31 ` James Almer [this message]
2024-03-19 19:47 ` Marton Balint
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOZuJMjr6RYJ8gvVUjnqDfHxK0gVvaN6+opZuUuj=cF84-houQ@mail.gmail.com' \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git