Re: [FFmpeg-devel] [PATCH 2/2] avcodec/sanm: avoid using k in left pxoff check

From: Manuel Lauss <manuel.lauss@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 2/2] avcodec/sanm: avoid using k in left pxoff check
Date: Tue, 3 Jun 2025 12:30:40 +0200
Message-ID: <CAOLZvyGj6U3Ud4hkEPA0MZQE8TN4SYEW_YgHU-6D+9ExNrBOhA@mail.gmail.com> (raw)
In-Reply-To: <20250530225130.GQ29660@pb2>

Servus Michael,

On Sat, May 31, 2025 at 12:51 AM Michael Niedermayer
<michael@niedermayer.cc> wrote:

> > > >              /* smooth top and left block borders with neighbours */
> > > > -            if (((pxoff - p + k) < 0) || ((pxoff - p + k) >= maxpxo)
> > > > +            if (((pxoff - p + 0) < 0) || ((pxoff - p + k) >= maxpxo)
> > > >                  || ((pxoff + 3 * p) < 0) || ((pxoff + 3 * p) >= maxpxo)
> > > >                  || (i == 0) || (j == 0))
> > > >                  continue;
> >
> > Oops, yes, that change is correct.
>
> will apply
>
>
> > I think you should just rip the whole block-smoothing block out
> > entirely: it creates a "sawtooth" pattern
> > which is more annoying than the "blockiness" it tries to soften.
>
> probably, but i just wanted to fix the out of array access,
> ill leave improvment beyond that to others

Is it OK if I just remove this block entirely?  I'd commit that along
with the other 2 sanm patches I have.

Manuel
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".