Re: [FFmpeg-devel] [PATCH v2 0/3] avcodec/sanm: Fixes for "StarWars - Making Magic"

[Manuel Lauss <manuel.lauss@gmail.com>]

Hi,

If there are no objections, I will commit this with whitespace fixes
in 2-3 days.  I see no regressions with existing sanm video support.

Manuel

On Tue, May 6, 2025 at 5:41 PM Manuel Lauss <manuel.lauss@gmail.com> wrote:
>
> This patchset extends the SANM codec handler to support video of
> the 1996 CD-ROM Title "StarWars - Making Magic".
> These videos all consist of a 640x480 codec3 background, with 320x240
> codec48 animations put on top at random left/top offsets.
>
> v2: reworded descriptions, fixes in #3.
>
> #1: some "Making Magic" files advertise codec48 compression type 6.
>     The actual data stops after the codec headers, and the dos exe as well as
>     the codec48 decoder in the MotS game exe don't know of it and simply
>     ignore it.
>
> #2: change the FOBJ frame size determination to recognize common sizes.
>     With the scheme employed by Making Magic, the codec48 dimensions can no
>     longer be blindly trusted.
>
> #3: support video of Making Magic.  This patch also brings the fobj
>     handling more in line with what the game engines actually do.
>
> Tested with RA1, RA2 (c37), Outlaws (c47), MotS (c48)
>
> See https://ibb.co/73Pt803  for post/pre fix screenshots.
>
> Manuel Lauss (3):
>   avcodec/sanm: ignore codec48 compression type 6
>   avcodec/sanm: add a whitelist for known FOBJ sizes
>   avcodec/sanm: support "StarWars - Making Magic" video
>
>  libavcodec/sanm.c | 100 ++++++++++++++++++++++++++++++++--------------
>  1 file changed, 70 insertions(+), 30 deletions(-)
>
> --
> 2.49.0
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".