From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 518834043E for ; Sun, 24 Apr 2022 18:43:28 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 807C868B00F; Sun, 24 Apr 2022 21:43:27 +0300 (EEST) Received: from mail-yw1-f176.google.com (mail-yw1-f176.google.com [209.85.128.176]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CC8C168008A for ; Sun, 24 Apr 2022 21:43:21 +0300 (EEST) Received: by mail-yw1-f176.google.com with SMTP id 00721157ae682-2ebf4b91212so129157617b3.8 for ; Sun, 24 Apr 2022 11:43:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=ssRKl8zkm6Bx+GXK2pbEbtZELtYbVdTixTEtyN45is8=; b=d8tsMS8JLs1jXBUaeLrrmVz3a17oQYxKr+/cQyRzVDspshZ65RoafyrI28B5c0CkpM tmasex1N7E4tdA0n9S4UihzSKsZY5k11fDTLf8QKhyIptTsz7Dq1Lx5+VjsplAOeJfQh eJ8vbBTULeVH+rHCZ/otPhtMFguN2m/PJ9LzTuINkppmT+psr2eM5wjN2SScjYooSkHk vwllBqqAO0vk4dnDkH1x+DHSMQWeMauEu9ZbobXsvbGi8ax4aj5iFt1tltbWpuQTGOY/ rG+zIr1wBXbnTPPN25YwNwXoM2CbjmsxPLoS+T/VNy4g74tYr4M1upOAOOuX6aLkQe2x pTOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=ssRKl8zkm6Bx+GXK2pbEbtZELtYbVdTixTEtyN45is8=; b=Tq1fDu85+iV4w05iOWu9b+5/XC/QJtXPftIzWRoyi+H10VP/AJqGWZEDeOUV6uf6kN 490NgPquF9uU3kqAkrXU+4qFLs1eW8meVTUqDlhETyXSD1o3glrlFxbuzCNJfBJxurFF fH0mtRnkpstUZKeYvPRu13hRPOm6MAxFj98dEAWMG0b3VMMX3jX1ScLme3FgdE3EtrSu pvsCPFWDwukJUTTtYaupivzKPj7tkgMqUi9EllNhGce3FtyRgmVAYs6Kgesx1uU73+iU 1IqNt9i66JLvjni2SHOUDUF/c1lDcO5RPacKDEJV7yQurC3Dnu3F0cCgTE486WOAOCSx Zgig== X-Gm-Message-State: AOAM531WiBloC67SOgWowuxY/8VYmwRGhBl13l0CYgZvgbzAGa2IEPZa 0r+TmNnOWdgVWcwPqvt2V/fxETHIM7Q3OPV0B1MJgr7CoW0XUQ== X-Google-Smtp-Source: ABdhPJx4JGcxQ8CzNdqF1k8eMcEiCUDocm8nIcZpMXQV1g9UfdjMbRcvUBHWoWY9rbrPB9r7S9qoER4OUMLr65tmf1s= X-Received: by 2002:a81:16cf:0:b0:2f7:cc18:7bd1 with SMTP id 198-20020a8116cf000000b002f7cc187bd1mr6161909yww.155.1650825800227; Sun, 24 Apr 2022 11:43:20 -0700 (PDT) MIME-Version: 1.0 References: <20220419205704.3548965-1-vigneshv@google.com> <62f20540-ad9f-cda3-20ff-9c4952e220a4@gyani.pro> In-Reply-To: From: Vignesh Venkatasubramanian Date: Sun, 24 Apr 2022 11:43:09 -0700 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avformat/mov: Add support for still image AVIF parsing X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, Apr 21, 2022 at 9:16 AM Vignesh Venkatasubramanian wrote: > > On Thu, Apr 21, 2022 at 2:08 AM Gyan Doshi wrote: > > > > > > > > On 2022-04-20 09:54 am, Gyan Doshi wrote: > > > > > > > > > On 2022-04-20 02:49 am, Paul B Mahol wrote: > > >> On Tue, Apr 19, 2022 at 10:57 PM Vignesh Venkatasubramanian < > > >> vigneshv-at-google.com@ffmpeg.org> wrote: > > >> > > >>> Add support for parsing AVIF still images. This patches supports > > >>> AVIF still images that have exactly 1 item (i.e.) no alpha channel. > > >>> Essentially, we will have to parse the "iloc" box and populate > > >>> the mov index. > > >>> > > >>> With this patch, we can decode still AVIF images like so: > > >>> ffmpeg -i image.avif image.png > > >>> > > >>> Partially fixes trac ticket #7621 > > >>> > > >> LGTM > > > > > > Will push tomorrow if no one else has. > > > > Can you provide a sample AVIF image and command that this patch allows > > decoding of? > > > > I tried a couple of samples from Netflix[1] and MS[2] and none worked, > > even with forcing MOV demuxer ("moov atom not found" or "error reading > > header"). > > Thanks for verifying. The test files you tried are invalid/not > supported by this patch. Please see the explanation below. > > > > > [1]: http://download.opencontent.netflix.com/?prefix=AV1/Chimera/AVIF/ > > These files are not valid AVIF since they don't have the major brand > set to "mif1" and not "avif". They are also missing a few other > mandatory boxes. libavif (the reference AVIF library) also is not able > to parse these files. These files were likely made when the AVIF > specification was not yet finalized. > > $ ./avifdec --info Chimera-AV1-8bit-1280x720-3363kbps-100.avif > ERROR: Failed to decode image: BMFF parsing failed > Diagnostics: > * [Strict] Item ID 1 of type 'av01' is missing mandatory pixi property > > > [2]: > > https://github.com/AOMediaCodec/av1-avif/tree/master/testFiles/Microsoft > > > > These files have EXIF metadata and will contain more than one item > entry in the iloc box. This patch does not support that (however, i > have a follow-up patch to fix this). The files in this directory > return AVERROR_PATCHWELCOME as intended. > The follow-up patch for supporting the files in the "Microsoft" subdirectory is here: http://ffmpeg.org/pipermail/ffmpeg-devel/2022-April/295647.html > For a set of working AVIF files that are supported by this patch you > can try the files under "Link-U" and "Netflix" subdirectories of this repo: > > https://github.com/AOMediaCodec/av1-avif/tree/master/testFiles/Link-U > > https://github.com/AOMediaCodec/av1-avif/tree/master/testFiles/Netflix/avif > > The command is as mentioned in the commit message: > ./ffmpeg -i output.png > > Please let me know if you have more questions. Thank you! > > > > Regards, > > Gyan > > > > > > _______________________________________________ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > To unsubscribe, visit link above, or email > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > > > > -- > Vignesh -- Vignesh _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".