From: Vignesh Venkatasubramanian <vigneshv-at-google.com@ffmpeg.org> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Subject: Re: [FFmpeg-devel] [PATCH] avformat/mov: Add support for still image AVIF parsing Date: Sun, 24 Apr 2022 11:43:09 -0700 Message-ID: <CAOJaEPLfM=xrsx9kgKXu8aa87i7dAKzkcZpXd1A_Mc4C6tCQBA@mail.gmail.com> (raw) In-Reply-To: <CAOJaEPKCxjS39WY1KFrb14DjCPDBcF=Yd06+oOfsQvnCMz0Rgw@mail.gmail.com> On Thu, Apr 21, 2022 at 9:16 AM Vignesh Venkatasubramanian <vigneshv@google.com> wrote: > > On Thu, Apr 21, 2022 at 2:08 AM Gyan Doshi <ffmpeg@gyani.pro> wrote: > > > > > > > > On 2022-04-20 09:54 am, Gyan Doshi wrote: > > > > > > > > > On 2022-04-20 02:49 am, Paul B Mahol wrote: > > >> On Tue, Apr 19, 2022 at 10:57 PM Vignesh Venkatasubramanian < > > >> vigneshv-at-google.com@ffmpeg.org> wrote: > > >> > > >>> Add support for parsing AVIF still images. This patches supports > > >>> AVIF still images that have exactly 1 item (i.e.) no alpha channel. > > >>> Essentially, we will have to parse the "iloc" box and populate > > >>> the mov index. > > >>> > > >>> With this patch, we can decode still AVIF images like so: > > >>> ffmpeg -i image.avif image.png > > >>> > > >>> Partially fixes trac ticket #7621 > > >>> > > >> LGTM > > > > > > Will push tomorrow if no one else has. > > > > Can you provide a sample AVIF image and command that this patch allows > > decoding of? > > > > I tried a couple of samples from Netflix[1] and MS[2] and none worked, > > even with forcing MOV demuxer ("moov atom not found" or "error reading > > header"). > > Thanks for verifying. The test files you tried are invalid/not > supported by this patch. Please see the explanation below. > > > > > [1]: http://download.opencontent.netflix.com/?prefix=AV1/Chimera/AVIF/ > > These files are not valid AVIF since they don't have the major brand > set to "mif1" and not "avif". They are also missing a few other > mandatory boxes. libavif (the reference AVIF library) also is not able > to parse these files. These files were likely made when the AVIF > specification was not yet finalized. > > $ ./avifdec --info Chimera-AV1-8bit-1280x720-3363kbps-100.avif > ERROR: Failed to decode image: BMFF parsing failed > Diagnostics: > * [Strict] Item ID 1 of type 'av01' is missing mandatory pixi property > > > [2]: > > https://github.com/AOMediaCodec/av1-avif/tree/master/testFiles/Microsoft > > > > These files have EXIF metadata and will contain more than one item > entry in the iloc box. This patch does not support that (however, i > have a follow-up patch to fix this). The files in this directory > return AVERROR_PATCHWELCOME as intended. > The follow-up patch for supporting the files in the "Microsoft" subdirectory is here: http://ffmpeg.org/pipermail/ffmpeg-devel/2022-April/295647.html > For a set of working AVIF files that are supported by this patch you > can try the files under "Link-U" and "Netflix" subdirectories of this repo: > > https://github.com/AOMediaCodec/av1-avif/tree/master/testFiles/Link-U > > https://github.com/AOMediaCodec/av1-avif/tree/master/testFiles/Netflix/avif > > The command is as mentioned in the commit message: > ./ffmpeg -i <avif file> output.png > > Please let me know if you have more questions. Thank you! > > > > Regards, > > Gyan > > > > > > _______________________________________________ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > To unsubscribe, visit link above, or email > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > > > > -- > Vignesh -- Vignesh _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2022-04-24 18:43 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-03-03 23:57 Vignesh Venkatasubramanian 2022-03-15 21:38 ` Vignesh Venkatasubramanian 2022-03-16 12:41 ` Lynne 2022-03-16 16:57 ` Vignesh Venkatasubramanian 2022-03-16 17:00 ` Vignesh Venkatasubramanian 2022-03-16 17:02 ` Vignesh Venkatasubramanian 2022-03-22 21:56 ` Vignesh Venkatasubramanian 2022-03-28 17:07 ` Vignesh Venkatasubramanian 2022-03-28 17:13 ` Paul B Mahol 2022-03-28 18:10 ` Vignesh Venkatasubramanian 2022-03-28 18:11 ` Vignesh Venkatasubramanian 2022-03-28 19:11 ` Vignesh Venkatasubramanian 2022-04-18 22:03 ` Vignesh Venkatasubramanian 2022-04-19 20:21 ` Paul B Mahol 2022-04-19 20:55 ` Vignesh Venkatasubramanian 2022-04-19 20:57 ` Vignesh Venkatasubramanian 2022-04-19 21:19 ` Paul B Mahol 2022-04-20 4:24 ` Gyan Doshi 2022-04-21 9:00 ` Gyan Doshi 2022-04-21 16:16 ` Vignesh Venkatasubramanian 2022-04-22 4:17 ` Gyan Doshi 2022-04-22 18:58 ` Vignesh Venkatasubramanian 2022-04-22 18:59 ` Vignesh Venkatasubramanian 2022-04-23 8:13 ` Gyan Doshi 2022-04-24 18:41 ` Vignesh Venkatasubramanian 2022-04-24 18:43 ` Vignesh Venkatasubramanian [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAOJaEPLfM=xrsx9kgKXu8aa87i7dAKzkcZpXd1A_Mc4C6tCQBA@mail.gmail.com' \ --to=vigneshv-at-google.com@ffmpeg.org \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git