From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A17AC43B2E for ; Wed, 13 Jul 2022 16:12:48 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D3D4F68B9EB; Wed, 13 Jul 2022 19:12:46 +0300 (EEST) Received: from mail-yb1-f180.google.com (mail-yb1-f180.google.com [209.85.219.180]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 34FF768B9BE for ; Wed, 13 Jul 2022 19:12:41 +0300 (EEST) Received: by mail-yb1-f180.google.com with SMTP id y195so20118817yby.0 for ; Wed, 13 Jul 2022 09:12:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=viBuZWqf9lnjh6Kw9sd3X1y0EuhFUxUdLcWYZvnYV34=; b=I08lL8TIWHhbthJAt7TRxitxCsHh7VEil5xvoSw9+1z1HN/i/pJvfiEyBoALnbinJ6 8gx8tvEW0adzXEH9EVzAUjcSePJiQxl+euN/AB121mORI67dbGgmXkxPmSeAt6feigsS FLMTurbhDugcZXltm1xvcYEAENcg10tQ6WGk8ZGep32tVe3GjKGj6BP3e8TPF+45wNsN MPFxGdiBjmI/8kDv4lMj2tiWCvsJf5afsE1WPwI0Gb1xHM89GF07dCd0WbpTe6jDQFMi r49HtkIxXaS8kWjZylk1cBY3sAd1/+A+tsS5dCq+n95u4ufNe5L6FWcRIDsaDzz0YHhH RoMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=viBuZWqf9lnjh6Kw9sd3X1y0EuhFUxUdLcWYZvnYV34=; b=y4EKTDi5j7G6nhw86MNP54EPfSHLvj7Myo/ZuWUFdhv53KtzSYJnaX7lvZGNY28kzK wxbO7lQBPrF/Ue6buHsbSExBBurAcsvbaKcWflM49QfAce4BndEzhf9RNZP+1S0BoJst RrSyJlXIkvOOJUSHrlvruxDL7zQeYPGSaWw1p0BHbkJFXYwGrKirOLAo0BEyVHG/RVsO BBYi8p9XzuwcqUX3mR+gu2usioWAC6KTMv+zQWmp5EuMD4qV/fA1qT9dC81FiD9/uToL iEDcIayS0coZp+Ob9Bx7pZPCOhiRzOJeCCh7pl3GJjOzvdV+0UBRASbtbDZnYzKWJI5B /Afw== X-Gm-Message-State: AJIora8ougtvfef1bJOgcxUtgJIlLobj9bFFN3FCPPvdx71/9bIMugaI 2Yf5NbbBAcrdsG/Rej0lVfQt14vVMqdyJK6gLO8cTTyLVFU= X-Google-Smtp-Source: AGRyM1sItJYKrdHiIGLjrFU3t4k4EBRzJpbPs2kDvi9SXKr9956Y1UEZrTh2KArDgQ03r6rLk01EDj64Ja4sg220eH4= X-Received: by 2002:a25:c405:0:b0:668:c24e:3065 with SMTP id u5-20020a25c405000000b00668c24e3065mr4345466ybf.189.1657728759482; Wed, 13 Jul 2022 09:12:39 -0700 (PDT) MIME-Version: 1.0 References: <20220630210434.1551769-1-vigneshv@google.com> In-Reply-To: From: Vignesh Venkatasubramanian Date: Wed, 13 Jul 2022 09:12:28 -0700 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: Rework the AVIF parser to handle multiple items X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, Jul 11, 2022 at 3:25 PM James Zern wrote: > > On Thu, Jun 30, 2022 at 2:04 PM Vignesh Venkatasubramanian > wrote: > > > > Stores the item ids of all the items found in the file and > > processes the primary item at the end of the meta box. This patch > > does not change any behavior. It sets up the code for parsing > > alpha channel (and possibly images with 'grid') in follow up > > patches. > > > > Signed-off-by: Vignesh Venkatasubramanian > > --- > > libavformat/isom.h | 4 ++ > > libavformat/mov.c | 148 ++++++++++++++++++++++++++++----------------- > > 2 files changed, 97 insertions(+), 55 deletions(-) > > > > [...] > > @@ -4692,9 +4755,25 @@ static int mov_read_meta(MOVContext *c, > AVIOContext *pb, MOVAtom atom) > tag = avio_rl32(pb); > atom.size -= 4; > if (tag == MKTAG('h','d','l','r')) { > + int ret; > avio_seek(pb, -8, SEEK_CUR); > atom.size += 8; > - return mov_read_default(c, pb, atom); > + ret = mov_read_default(c, pb, atom); > + if (ret < 0) > > In some other cases these two lines are combined, if ((ret = ... > Done. > + return ret; > + if (c->is_still_picture_avif) { > + int ret; > + // Add a stream for the YUV planes (primary item). > + ret = avif_add_stream(c, c->primary_item_id); > + if (ret) > > This could be updated too and use '< 0' to match other code. > Done. > + return ret; > + // For still AVIF images, the meta box contains all the > + // necessary information that would generally be > provided by the > + // moov box. So simply mark that we have found the moov box so > + // that parsing can continue. > + c->found_moov = 1; > + } > + return ret; > } > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". -- Vignesh _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".