From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id BA6A5445FC for ; Mon, 19 Sep 2022 16:46:40 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3345868BA50; Mon, 19 Sep 2022 19:46:38 +0300 (EEST) Received: from mail-yb1-f169.google.com (mail-yb1-f169.google.com [209.85.219.169]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 781F168BA02 for ; Mon, 19 Sep 2022 19:46:31 +0300 (EEST) Received: by mail-yb1-f169.google.com with SMTP id p69so36646603yba.0 for ; Mon, 19 Sep 2022 09:46:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date; bh=BLakjsRVweD7GVFxrHcEH3n8UZW0RVCI5CxH6viVvjI=; b=T5KBdQa3ye05QqHS+FrBk5/wf7mCQgx+MAGfJHaLzaUDA7EcAf9w1//n+3GFFeBa16 H98grOFebsXXW3GiDusIbPqLHsxdqVLnMmYitG4l+lhfcjWO+ToCSej3zXgugV8mZK9T zlMAKgZGpOQ8wPD70CqK0zhGBHdFjQB5LVdJQnHucs6++D0x40WKUjhfF3ZlTRkBHS5a Ns/jJqStbqr45qcCtjt6hl1DCh338HOuqd2ckgx+2Po+Dg57y9hYklOjO5QGyQ20sSdB n0BupXjl8h8I55WIuDBk/8meXTTlU9Nn2UaY+wAt+UMw2xJvdlC/1g/1luSLPBp7odZ5 /taQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date; bh=BLakjsRVweD7GVFxrHcEH3n8UZW0RVCI5CxH6viVvjI=; b=M4y31fOszsOSo6rtkAvX+y8DlN96aQ5iuy1DlDvKOthuT3pVwH7ZAOCdv2rWibLa8z CBaZpzdN7ehkNvE5MP0OO4pAJ2cOFWny5NfazTyISzNTwIKNt/wvCnQyr0FBwT1BUTtN wpDjYbuDGLboeipM86l8Lsl08FOn+6DxsGr895HJQdpl0bs3dYQ+RWef+6JZfP6Vu4p8 aBNopZ3itB4dXH5+7OGvSKj/XOj2dioHT8tde7IaI6s82eJVg+p/q908H9iTZsX3/L6H HH3NYTqUwy/nKHMQN6MSKMVJXEm6mVqM9Atk6fHa9qzMGPnyYZJ4q66y3lajd5ipqQT1 2k2g== X-Gm-Message-State: ACrzQf3B5NukSejQWRE9VhyxzyMbqhJGGzj/qRAEhJiAN0coNyda5IWP n9KOFbtLQTW2VGmQn/tUv7x2aQ3yF8NBqtNbwAGPheVBZG8= X-Google-Smtp-Source: AMsMyM7uVCi48g4F6FlvFv8ToJpM5wVAl8p+7yl2+xMqcc4luI2IOD4maeQH2QEW+R7DVS6AknlLIH1w7F+vLjmm3ZM= X-Received: by 2002:a25:6e05:0:b0:683:714f:c371 with SMTP id j5-20020a256e05000000b00683714fc371mr14307693ybc.96.1663605989411; Mon, 19 Sep 2022 09:46:29 -0700 (PDT) MIME-Version: 1.0 References: <20220914002757.1570637-1-jzern@google.com> In-Reply-To: <20220914002757.1570637-1-jzern@google.com> From: Vignesh Venkatasubramanian Date: Mon, 19 Sep 2022 09:46:18 -0700 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add -min-gf-interval X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, Sep 13, 2022 at 5:28 PM James Zern wrote: > > this maps to the vpxenc argument with the same name and the > VP9E_SET_MIN_GF_INTERVAL codec control > > Signed-off-by: James Zern > --- > doc/encoders.texi | 2 ++ > libavcodec/libvpxenc.c | 11 +++++++++++ > libavcodec/version.h | 2 +- > 3 files changed, 14 insertions(+), 1 deletion(-) > > diff --git a/doc/encoders.texi b/doc/encoders.texi > index ac71f50ad2..5a5579d5e5 100644 > --- a/doc/encoders.texi > +++ b/doc/encoders.texi > @@ -2176,6 +2176,8 @@ Set altref noise reduction filter type: backward, forward, centered. > Set altref noise reduction filter strength. > @item rc-lookahead, lag-in-frames (@emph{lag-in-frames}) > Set number of frames to look ahead for frametype and ratecontrol. > +@item min-gf-interval > +Set minimum golden/alternate reference frame interval (VP9 only). > @end table > > @item error-resilient > diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c > index 09b56aae2a..667cffc200 100644 > --- a/libavcodec/libvpxenc.c > +++ b/libavcodec/libvpxenc.c > @@ -131,6 +131,7 @@ typedef struct VPxEncoderContext { > int tune_content; > int corpus_complexity; > int tpl_model; > + int min_gf_interval; > AVFifo *hdr10_plus_fifo; > /** > * If the driver does not support ROI then warn the first time we > @@ -186,6 +187,9 @@ static const char *const ctlidstr[] = { > #ifdef VPX_CTRL_VP9E_SET_TPL > [VP9E_SET_TPL] = "VP9E_SET_TPL", > #endif > +#ifdef VPX_CTRL_VP9E_SET_MIN_GF_INTERVAL > + [VP9E_SET_MIN_GF_INTERVAL] = "VP9E_SET_MIN_GF_INTERVAL", > +#endif > #endif > }; > > @@ -1173,6 +1177,10 @@ static av_cold int vpx_init(AVCodecContext *avctx, > #ifdef VPX_CTRL_VP9E_SET_TPL > if (ctx->tpl_model >= 0) > codecctl_int(avctx, VP9E_SET_TPL, ctx->tpl_model); > +#endif > +#ifdef VPX_CTRL_VP9E_SET_MIN_GF_INTERVAL > + if (ctx->min_gf_interval >= 0) > + codecctl_int(avctx, VP9E_SET_MIN_GF_INTERVAL, ctx->min_gf_interval); > #endif > } > #endif > @@ -1911,6 +1919,9 @@ static const AVOption vp9_options[] = { > #endif > #ifdef VPX_CTRL_VP9E_SET_TPL > { "enable-tpl", "Enable temporal dependency model", OFFSET(tpl_model), AV_OPT_TYPE_BOOL, {.i64 = -1}, -1, 1, VE }, > +#endif > +#ifdef VPX_CTRL_VP9E_SET_MIN_GF_INTERVAL > + { "min-gf-interval", "Minimum golden/alternate reference frame interval", OFFSET(min_gf_interval), AV_OPT_TYPE_INT, {.i64 = -1}, -1, INT_MAX, VE }, > #endif > LEGACY_OPTIONS > { NULL } > diff --git a/libavcodec/version.h b/libavcodec/version.h > index 2328be4b26..7e89daf017 100644 > --- a/libavcodec/version.h > +++ b/libavcodec/version.h > @@ -30,7 +30,7 @@ > #include "version_major.h" > > #define LIBAVCODEC_VERSION_MINOR 43 > -#define LIBAVCODEC_VERSION_MICRO 100 > +#define LIBAVCODEC_VERSION_MICRO 101 > > #define LIBAVCODEC_VERSION_INT AV_VERSION_INT(LIBAVCODEC_VERSION_MAJOR, \ > LIBAVCODEC_VERSION_MINOR, \ > -- > 2.37.2.789.g6183377224-goog > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". lgtm. -- Vignesh _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".