From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4075B400DA for ; Thu, 17 Feb 2022 19:34:08 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 057FA68B354; Thu, 17 Feb 2022 21:34:06 +0200 (EET) Received: from mail-yb1-f169.google.com (mail-yb1-f169.google.com [209.85.219.169]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3D85368020D for ; Thu, 17 Feb 2022 21:33:59 +0200 (EET) Received: by mail-yb1-f169.google.com with SMTP id p5so15049302ybd.13 for ; Thu, 17 Feb 2022 11:33:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BEY3pTAUXZHs/xukDhs1fndvTJrwhRrUcThvtZtFGr8=; b=amrpAW6GI0O9Rp+z8RlzMjUVM1ITVhGdSg6fvkpG16qY3sJ/jZN0u4E2+nE5/XXalo Cs0DkJhNS22LnV2oaJPYPuzAy3eCYeMeA0BczZhgqutlSCNcrhBqVW3qy3RM7ZEtDuMf rOdNx/zC/WVCnAUxz39IfFaapv0kvYpHK35cSxgsybg1zr7eHRRtiX9S8T6irZXVvNaY fyAw/EyBbHU2dtlpcdjOcdMlhbSsUhZXIg7Mvs+C/3WOojZK6iTZiumsOJBtOf/a8w0q tu8VwfPgxGuhYdQH9TQWcA7jQQdN21x7D4rS8qNucuhsa7Q+Mo0sRZ7TMS++WBmUO3CP B5iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BEY3pTAUXZHs/xukDhs1fndvTJrwhRrUcThvtZtFGr8=; b=DWb9zIj96IowdKGtf2NSPQCch01NonUUSoCt87dArnFal3wUis4Aa6Ew9IwJX2ZnhT U4qsgtSB/tfEbPgm1SbwAuc8IfKzGMk5sgH70GjQ1R0AiMmpzT/MzGbKmWwsipwLqveH KMbB6rDAvyu3JMuqkPBb+LMnEqgef9Uaxy/4FNpOlp4UrUX65rSwZHOyVUWzhSEzCwfo CNyw1snaqkX3KN4Lc2XivO49mKhvu4xlz2okC68k7Nl+LhgSuQFV7FTJcddGF/uBGwqp FFRLJbtjqAbi12aGlKi9h0ye1zwN7q7p7vzX3m0EXvtYYxN/vZvd2PfAo2xnSGBDRW2C 7Tcw== X-Gm-Message-State: AOAM531fKPj2SVSY24UJyxSRMivVfiQGiduQE6lKWD/64Vq5GvkKA8xv dWuT1nnLEMt5sjChLEhbt62y/jwwCQ84tBN8G5ORXw== X-Google-Smtp-Source: ABdhPJwf7TlTeR+gWzN5NSPTvy4uLSp1S8OuugUYJubl41951eHGGWpuKyRb1PwbBgWtkVULUX3XSsTwEPg4FQMMN/E= X-Received: by 2002:a25:55:0:b0:61a:4d80:55ce with SMTP id 82-20020a250055000000b0061a4d8055cemr3809090yba.41.1645126437462; Thu, 17 Feb 2022 11:33:57 -0800 (PST) MIME-Version: 1.0 References: <20220217055117.3233501-1-vigneshv@google.com> In-Reply-To: From: Vignesh Venkatasubramanian Date: Thu, 17 Feb 2022 11:33:46 -0800 Message-ID: To: James Zern Subject: Re: [FFmpeg-devel] [PATCH 1/3] avcodec/libaomenc: Add parameter for avif single image encoding X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, Feb 17, 2022 at 10:09 AM James Zern wrote: > > On Wed, Feb 16, 2022 at 9:51 PM Vignesh Venkatasubramanian > wrote: > > > > Add a parameter to libaom-av1 encoder to enforce some of the single > > image constraints in the AV1 encoder. Setting this flag will limit > > the encoder to producing exactly one frame and the sequence header > > that is produced by the encoder will be conformant to the AVIF > > specification [1]. > > > > Part of Fixing Trac ticket #7621 > > > > [1] https://aomediacodec.github.io/av1-avif > > > > Signed-off-by:: Vignesh Venkatasubramanian > > --- > > libavcodec/libaomenc.c | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > > > [...] > > @@ -1290,6 +1303,7 @@ static const AVOption options[] = { > > { "psnr", NULL, 0, AV_OPT_TYPE_CONST, {.i64 = AOM_TUNE_PSNR}, 0, 0, VE, "tune"}, > > { "ssim", NULL, 0, AV_OPT_TYPE_CONST, {.i64 = AOM_TUNE_SSIM}, 0, 0, VE, "tune"}, > > FF_AV1_PROFILE_OPTS > > + { "avif-image", "Encode in single frame mode for still AVIF images.", OFFSET(is_avif), AV_OPT_TYPE_BOOL, {.i64 = -1}, -1, 1, VE }, > > Can this instead be mapped to something that can be sent via aom-params? >From what i understand, aom-params can only be used to set key-value pairs that are set using the aom_codec_set_option() function call. For single image AVIF encodes, we are modifying some of the aom_codec_enc_cfg entries. There is no way to do that in a generic way other than to introduce a specific option like this. -- Vignesh _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".