From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A495F432B7 for ; Mon, 27 Jun 2022 16:44:34 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 95B7B68B8DA; Mon, 27 Jun 2022 19:44:33 +0300 (EEST) Received: from mail-yw1-f178.google.com (mail-yw1-f178.google.com [209.85.128.178]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 26A1768B8B6 for ; Mon, 27 Jun 2022 19:44:27 +0300 (EEST) Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-2ef5380669cso91346317b3.9 for ; Mon, 27 Jun 2022 09:44:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=raqf9zn38Zxoh1DJa0Rah/mfRGureu1SvKYjNAKIjRs=; b=c9U/r3PwvpDCVyIhPluNEry7CvDzi3VQ0ZJLXq30ff3BVHRXeLO4/0eSCfTYozHjTK ieMdauI2zY/XHOfyTKPsR0d6aB97AydafkfTUTcfWkvuQHQIZOIa75sxw0sSmaINdkkd G/fvZ7qwtEJSX2zZtWk+p719Ap5z6k5F/zgYsWB1sGDn/gU3WfMoSeXhTLvap0FjgTSd eXpZvym06Pt1o943oa/jijNRYgACHkx69qT7kPCyvAEe/6qOujP9iTalHxsom3lKUrk3 Cl1Ln1ybKVbG4DIWY+TkYbMe9LWTgz2NrVwqaXxxDHW3b1fnqz2TU1DbyzuW7zW7H7q8 Y2QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=raqf9zn38Zxoh1DJa0Rah/mfRGureu1SvKYjNAKIjRs=; b=G3F4CoCpUSHlhu3u3mTVhwSh/iDere0JY3kkaJIlr/Is6VjIGSOqF1tuPu79y/4kw+ r6KJZXbfTdAZB/LjSGOUi0/tRF/QFdO1XUiWkXp+d/Fl3nMxHyag52yZKrt0mbB6q6db tsqZ0zrkQjaHgxLOk5gzOqec+jTbokoMkRQMPDCzp/+g1kAFcwfSrEKsxEZTmhiUwXzv IVhq4ezK5g3yO2V7P5AJfGOXqj3TPCP20ZYp/JDeu4FmuRmPTQU5DXQ4Jb8XqF9NZ0lP hr1sOdKjYOee3bqjS0PU+KWc0aTd4bTP84HCf1uWm8uABc8mrojSNVZR+MriurZPBI1G oq/g== X-Gm-Message-State: AJIora+gO2LD3sdGci0h94vBoG81wx0LyBoshiciyqTJ0bBWcPqC5Xi3 QGx/bPOCAZYJBo1jo7nXMlWLI5xkjAzBx+KtmXRqqh4QV4w= X-Google-Smtp-Source: AGRyM1vjgONZ/LWNSm88iUTV1vmHFIjMqqHMWLEAAYXo/Bnw9kl+KB3vMFYjMb2JxV7p/KV3+eGOUut9Ha5iu7yNzwI= X-Received: by 2002:a81:9103:0:b0:317:9522:e7d9 with SMTP id i3-20020a819103000000b003179522e7d9mr15897407ywg.61.1656348265292; Mon, 27 Jun 2022 09:44:25 -0700 (PDT) MIME-Version: 1.0 References: <20220424183514.986374-1-vigneshv@google.com> <085f0277-e678-4d20-f2bf-fbf55ed959d8@gyani.pro> In-Reply-To: From: Vignesh Venkatasubramanian Date: Mon, 27 Jun 2022 09:44:14 -0700 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avformat/mov: Only read the primary item for AVIF X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, Jun 21, 2022 at 10:12 AM Vignesh Venkatasubramanian wrote: > > On Mon, Jun 13, 2022 at 9:32 AM Vignesh Venkatasubramanian > wrote: > > > > On Fri, Jun 10, 2022 at 10:34 AM Vignesh Venkatasubramanian > > wrote: > > > > > > On Thu, Jun 9, 2022 at 12:50 AM Gyan Doshi wrote: > > > > > > > > > > > > > > > > On 2022-06-08 10:51 pm, Vignesh Venkatasubramanian wrote: > > > > > On Thu, Jun 2, 2022 at 1:35 PM James Zern wrote: > > > > >> On Wed, Jun 1, 2022 at 1:38 PM Vignesh Venkatasubramanian > > > > >> wrote: > > > > >>> On Wed, Jun 1, 2022 at 10:30 AM James Zern wrote: > > > > >>>> On Sun, Apr 24, 2022 at 11:35 AM Vignesh Venkatasubramanian > > > > >>>> wrote: > > > > >>>>> Update the still AVIF parser to only read the primary item. With this > > > > >>>>> patch, AVIF still images with exif/icc/alpha channel will no longer > > > > >>>>> fail to parse. > > > > >>>>> > > > > >>>>> For example, this patch enables parsing of files in: > > > > >>>>> https://github.com/AOMediaCodec/av1-avif/tree/master/testFiles/Microsoft > > > > >>>>> > > > > >>>> Can some of the failing files or similar ones be added to fate? > > > > >>> There are no fate tests for AVIF parsing as of now. I was thinking > > > > >>> about adding some for the muxing. But i am not sure what can be done > > > > >>> here for the parsing. > > > > >>> > > > > >> Thanks. Are there any for general mov/mp4 parsing that could be > > > > >> extended? This looks good otherwise. > > > > > From what i see, most of the mov tests only seem to be for muxing. I'm > > > > > not entirely certain about how to add a test for AVIF parsing. If > > > > > anybody has an idea, i'd be open to adding it. > > > > > > > > Basic test would use the framemd5 muxer to compare demuxed packets with > > > > a reference. > > > > See fate-ffmpeg-streamloop > > > > > > > > > > Thank you i have added a couple of fate tests. > > > > > > I am not sure how to add the AVIF files to the fate test server. I > > > have them on Google Drive here: > > > > > > https://drive.google.com/file/d/1diZoM0Ew7Co3Yh5w5y1J-3IiBYVmUv9J/view?usp=sharing > > > https://drive.google.com/file/d/1DdrD1mW36evt40a4RkeLYpx-oojmbc3z/view?usp=sharing > > > > > > These links should be publicly available without any sign in required. > > > Please let me know if there is another preferred way of sharing test > > > files and i can share it that way. > > > > > > > Also, i forgot to mention that these files have to be uploaded under a > > new directory called "avif" in the fate server. > > > > > Also for the record, these files were created by remuxing an existing > > > file in the fate suite. > > > > > > still_image.avif - contains the first frame from > > > av1-test-vectors/av1-1-b8-02-allintra.ivf > > > still_image_exif.avif - contains the first frame from > > > av1-test-vectors/av1-1-b8-02-allintra.ivf with dummy exif data. > > > > > > > Regards, > > > > Gyan > > > > _______________________________________________ > > > > ffmpeg-devel mailing list > > > > ffmpeg-devel@ffmpeg.org > > > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > > > > > To unsubscribe, visit link above, or email > > > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > > > > > > > > > > > > -- > > > Vignesh > > > > > > > > -- > > Vignesh > > Ping on this please. > > -- > Vignesh Another ping on this please. :) -- Vignesh _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".