From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 50BFA40056 for ; Wed, 18 May 2022 16:39:57 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7F07C68B473; Wed, 18 May 2022 19:39:54 +0300 (EEST) Received: from mail-yb1-f169.google.com (mail-yb1-f169.google.com [209.85.219.169]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7018568A214 for ; Wed, 18 May 2022 19:39:48 +0300 (EEST) Received: by mail-yb1-f169.google.com with SMTP id x2so4323966ybi.8 for ; Wed, 18 May 2022 09:39:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=WqkD8uRRQd32PtGtQYSvrePumISiVDZLmDCEr8y53Eo=; b=gbjg9lAhf6RFocfI5M84/sXUkHAredO1ZwZi/+SNdZxmwcxgAqx4+nwOpYt9HADtqB erzpASZSqzRoiIH+O1SqbCdGos1LCmMXB1Sl/sAxXGupbGzu1x66mhAadpBNEBdhcBfs sE8VfbTyLKP076WHFmsyZsNvt/VjugJdp+Y+CSeCCRCgqGu5HWBsA/Y5mbVUDut4+Llt g/SS1uA+9uJZpzTWg+qWtIux1iI0BR/pUySxNEB6mHwT0MQUQPxXFfZzjixPCYfOLumX 2hWgTtTUU0DHBnMWE2qWaZhkr4Pum2zep1UP7bvR4gfotGMBtyvpIsHHde/q/2YHWq2E QKjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=WqkD8uRRQd32PtGtQYSvrePumISiVDZLmDCEr8y53Eo=; b=To6WTT5KB2PEcZAe0nQBE5fKy5Z592LFpitMmebYMYfID7BsP5HguQVWYMgVPGVuKg QBXOpLrst1BbKF0yYy/c10+6pUd1bLZNb+lJWW9Akje70QBERWhUulD/wkkYVjjJUFUL vPIcD/wjf1wjU6xXh6DnJKBtvlXUguzoLtp3orjqLMOVsZrUZCD6KwNGeyHCfFRH6YPV dPcyHcKpXMWjFpUwCb4T+VGe1Y5mzUHBBj0UYr34GCrlXRv2RaJzwZOG2DKFNSooTDu1 VTmkOqDijjMPDFxlxRBbfiWaK2gesiLZyrxar6yjkoA34/wVJQ1prAOikdX43EoqClHe 6Y9A== X-Gm-Message-State: AOAM531G00ScFoK0KW75MYQFlOBNEykbsdczyXwWfmd4Iqz9t5DXbaZy 28MhZpRn35LTI5+It705slYFT0Nd3WowDIRkcnbrwUwtRZg= X-Google-Smtp-Source: ABdhPJxpxILAGtehndrcCzX7AaQcr6tArsVnxhPkDBaNYWh1SJQzRPO1vFnK4Vz3t5Sv5TjFzrmiylXTOQj9AOr88fg= X-Received: by 2002:a25:c794:0:b0:64d:efc2:70eb with SMTP id w142-20020a25c794000000b0064defc270ebmr449705ybe.203.1652891986594; Wed, 18 May 2022 09:39:46 -0700 (PDT) MIME-Version: 1.0 References: <20220517182439.545198-1-vigneshv@google.com> <8473e698-8fc3-ce17-05b8-fd0348d77c0b@gyani.pro> In-Reply-To: <8473e698-8fc3-ce17-05b8-fd0348d77c0b@gyani.pro> From: Vignesh Venkatasubramanian Date: Wed, 18 May 2022 09:39:35 -0700 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: Expose the allintra usage mode X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, May 18, 2022 at 2:29 AM Gyan Doshi wrote: > > > > On 2022-05-17 11:54 pm, Vignesh Venkatasubramanian wrote: > > libaom added an usage=allintra mode for doing better with still > > images. Expose that in the ffmpeg's wrapper. This is especially > > useful for encoding still AVIF images. > > > > Signed-off-by: Vignesh Venkatasubramanian > > --- > > libavcodec/libaomenc.c | 7 +++++-- > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > diff --git a/libavcodec/libaomenc.c b/libavcodec/libaomenc.c > > index 0411773bbf..7a601c120e 100644 > > --- a/libavcodec/libaomenc.c > > +++ b/libavcodec/libaomenc.c > > @@ -1298,8 +1298,11 @@ static const AVOption options[] = { > > { "enable-intrabc", "Enable intra block copy prediction mode", OFFSET(enable_intrabc), AV_OPT_TYPE_BOOL, {.i64 = -1}, -1, 1, VE}, > > { "enable-restoration", "Enable Loop Restoration filtering", OFFSET(enable_restoration), AV_OPT_TYPE_BOOL, {.i64 = -1}, -1, 1, VE}, > > { "usage", "Quality and compression efficiency vs speed trade-off", OFFSET(usage), AV_OPT_TYPE_INT, {.i64 = 0}, 0, INT_MAX, VE, "usage"}, > > - { "good", "Good quality", 0, AV_OPT_TYPE_CONST, {.i64 = 0 /* AOM_USAGE_GOOD_QUALITY */}, 0, 0, VE, "usage"}, > > - { "realtime", "Realtime encoding", 0, AV_OPT_TYPE_CONST, {.i64 = 1 /* AOM_USAGE_REALTIME */}, 0, 0, VE, "usage"}, > > + { "good", "Good quality", 0, AV_OPT_TYPE_CONST, {.i64 = 0 /* AOM_USAGE_GOOD_QUALITY */}, 0, 0, VE, "usage"}, > > + { "realtime", "Realtime encoding", 0, AV_OPT_TYPE_CONST, {.i64 = 1 /* AOM_USAGE_REALTIME */}, 0, 0, VE, "usage"}, > > Don't mix cosmetic changes with code changes. Should be a separate patch. > Removed from this patch. > Regards, > Gyan > > > +#ifdef AOM_USAGE_ALL_INTRA > > + { "allintra", "All Intra encoding", 0, AV_OPT_TYPE_CONST, {.i64 = 2 /* AOM_USAGE_ALL_INTRA */}, 0, 0, VE, "usage"}, > > +#endif > > { "tune", "The metric that the encoder tunes for. Automatically chosen by the encoder by default", OFFSET(tune), AV_OPT_TYPE_INT, {.i64 = -1}, -1, AOM_TUNE_SSIM, VE, "tune"}, > > { "psnr", NULL, 0, AV_OPT_TYPE_CONST, {.i64 = AOM_TUNE_PSNR}, 0, 0, VE, "tune"}, > > { "ssim", NULL, 0, AV_OPT_TYPE_CONST, {.i64 = AOM_TUNE_SSIM}, 0, 0, VE, "tune"}, > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". -- Vignesh _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".