From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9746E4026A for ; Thu, 21 Apr 2022 16:16:50 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7038F68B3AD; Thu, 21 Apr 2022 19:16:47 +0300 (EEST) Received: from mail-yw1-f180.google.com (mail-yw1-f180.google.com [209.85.128.180]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5525B68B383 for ; Thu, 21 Apr 2022 19:16:41 +0300 (EEST) Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-2ec0bb4b715so57633247b3.5 for ; Thu, 21 Apr 2022 09:16:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=whUc8HPRsMrFUZSOMyauuVLrZblwgRO/zxesTXvLiBU=; b=svAE121E2nthAR9GzaG07V+IeGcfxic/jUbbHIy2wtw9Fx1nJ5VdIzAoubsEw/vQeC L9b3o6m2Mno1OlxckrQ8kRPqAgIrOycCqKx46x1eNMJSo81PLrxvbS6Ut93SEk6f4J5b 46eSttKzi6E1yhcQPuXnI1Ubrp71JieNyKcfkNJiht/miDKO3T+Ed2l1AVNJ5GG8lMOc OnKn7pvfkul4oiytX/ZSKC9e9w+eeutsfWyYoSumbmZDf1qrQ5CZwp+sY28CBXKqfQnZ 1Zrr57hFvEMMx9ZYbHK8pl+vE+l/A36bXJs8dF/3DdWYQkfijJ1XakgBAHRu8MDf1dj2 7XnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=whUc8HPRsMrFUZSOMyauuVLrZblwgRO/zxesTXvLiBU=; b=o/u1gfIBnPjqjjphm+06HfdMsc9g+OXb0dvhZkvT3Y+kdqoZFrom2DSLpX4Sdz7aVc VDv0/jwQZBRZoH78jsb5RJnVUxdpB2cg9/MInrnyvk20h+nVH25TFxXqLKqJvan9kRfZ FzQjMWLp4n4g+9uWi/t1+jvTOcfuv5ABRBl7mHqzBoR2qhPFHYUYKzIaB9ZFDFmWAqxz QwG8m4QkbezD390tDiamj9bkShFr2BzYWNcmRwOw+7rVR3aI3as2xPheEd3etKR9KbRK e8EvF7Tw0aeztItQOFJA0RkSUmuPf2nnlKdGgaPjo4YW5vEAWcLd52/ASl8I8iv5b+Vn /eNA== X-Gm-Message-State: AOAM532FLFhQ7PopP0CbZ8kis+0+FMulUlzeuL6dBnQj34Ip3UmuBnnO saiwPAqd0j77rTHA9bwqtz5HqO/KWdozB0mCBXzHUGNdXsr66w== X-Google-Smtp-Source: ABdhPJzD4pkHYWuzTgpzyt/TcDD0+ZGHVFT2thngmTYP974TVZdcoJHJ7pdfJys6HACNUfMQ8QvaWpyTKZ10VuKRMbc= X-Received: by 2002:a81:4c47:0:b0:2f4:daab:946c with SMTP id z68-20020a814c47000000b002f4daab946cmr442655ywa.434.1650557799238; Thu, 21 Apr 2022 09:16:39 -0700 (PDT) MIME-Version: 1.0 References: <20220419205704.3548965-1-vigneshv@google.com> <62f20540-ad9f-cda3-20ff-9c4952e220a4@gyani.pro> In-Reply-To: From: Vignesh Venkatasubramanian Date: Thu, 21 Apr 2022 09:16:28 -0700 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avformat/mov: Add support for still image AVIF parsing X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, Apr 21, 2022 at 2:08 AM Gyan Doshi wrote: > > > > On 2022-04-20 09:54 am, Gyan Doshi wrote: > > > > > > On 2022-04-20 02:49 am, Paul B Mahol wrote: > >> On Tue, Apr 19, 2022 at 10:57 PM Vignesh Venkatasubramanian < > >> vigneshv-at-google.com@ffmpeg.org> wrote: > >> > >>> Add support for parsing AVIF still images. This patches supports > >>> AVIF still images that have exactly 1 item (i.e.) no alpha channel. > >>> Essentially, we will have to parse the "iloc" box and populate > >>> the mov index. > >>> > >>> With this patch, we can decode still AVIF images like so: > >>> ffmpeg -i image.avif image.png > >>> > >>> Partially fixes trac ticket #7621 > >>> > >> LGTM > > > > Will push tomorrow if no one else has. > > Can you provide a sample AVIF image and command that this patch allows > decoding of? > > I tried a couple of samples from Netflix[1] and MS[2] and none worked, > even with forcing MOV demuxer ("moov atom not found" or "error reading > header"). Thanks for verifying. The test files you tried are invalid/not supported by this patch. Please see the explanation below. > > [1]: http://download.opencontent.netflix.com/?prefix=AV1/Chimera/AVIF/ These files are not valid AVIF since they don't have the major brand set to "mif1" and not "avif". They are also missing a few other mandatory boxes. libavif (the reference AVIF library) also is not able to parse these files. These files were likely made when the AVIF specification was not yet finalized. $ ./avifdec --info Chimera-AV1-8bit-1280x720-3363kbps-100.avif ERROR: Failed to decode image: BMFF parsing failed Diagnostics: * [Strict] Item ID 1 of type 'av01' is missing mandatory pixi property > [2]: > https://github.com/AOMediaCodec/av1-avif/tree/master/testFiles/Microsoft > These files have EXIF metadata and will contain more than one item entry in the iloc box. This patch does not support that (however, i have a follow-up patch to fix this). The files in this directory return AVERROR_PATCHWELCOME as intended. For a set of working AVIF files that are supported by this patch you can try the files under "Link-U" and "Netflix" subdirectories of this repo: https://github.com/AOMediaCodec/av1-avif/tree/master/testFiles/Link-U https://github.com/AOMediaCodec/av1-avif/tree/master/testFiles/Netflix/avif The command is as mentioned in the commit message: ./ffmpeg -i output.png Please let me know if you have more questions. Thank you! > Regards, > Gyan > > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". -- Vignesh _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".