From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 087E343036 for ; Wed, 18 May 2022 17:38:10 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0C62468B470; Wed, 18 May 2022 20:38:07 +0300 (EEST) Received: from mail-yb1-f173.google.com (mail-yb1-f173.google.com [209.85.219.173]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E246268B226 for ; Wed, 18 May 2022 20:37:59 +0300 (EEST) Received: by mail-yb1-f173.google.com with SMTP id v71so4919798ybi.4 for ; Wed, 18 May 2022 10:37:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=ZAskTK8qjtIbB8YHK070wmlMNy1wIizYxmT5EOSK89U=; b=BDHeyu8EVEbENQtfLvOTiXUvo0MiTvUpF5cjxi88u5u/FvWVuWBdcSNSPe7lwTrgQL o/sLq47ekSmFbpmHIG31B3Vbtq6t+JUdaLKiTgATaVExdpf3JXDb6q5DCMdwdCGkR00f 04O4G908xHKOWNlw8xHSVXvMBYj/tOCWW94u3R5ujdKpoxmb5EfbhsfZCjDY56vQNcwV AQhznGQD8HFZhwiVwyTYt2i+sWL/7NXyPx0paFLF0PYIBh0UyGPCXOZvCgla8wCAYIbG ZkSZ97iSr17QU+T8wR+zYD8XHKd9lHNSJ6PXhzLIk0ODVtQMTbGyf8uvsyRD5V0Pv0gw 7t1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=ZAskTK8qjtIbB8YHK070wmlMNy1wIizYxmT5EOSK89U=; b=DfukX0PpuBlOYzruJrqxVejCvSViSHiYHcEGLfhXIbI0SH0b9F/Q50ov96u0sjb4AY 7N6gGK29OrXYdW80hyfe7PVESoxfNv39EI7LJQf0aFifxkgRyksIR2EVhqHpkIZ4bpEI BHE6Tavjh4vx/kO1VFMvAuMC0R3tswn2CEmYtNgu5QeRPBrV6hNPm7X3UzPC5djH1+3X HEFroy+SJ1/5cR/PQT+0zSEamOVk7+6fYnObbn0SQKHvvbJY4keoVjvDJjgM/pdgkRx+ uNbtsj1Y/9txM3bKzVcSbFGGnFRswXnwLeDY0Q35WbeiAKSU+xk8WjNYA4Fi2YwrnD7B lXyw== X-Gm-Message-State: AOAM531xdF/ckn7wMjxJjfSYQPozGYUHXPb2snoAS2tndHrDyU73aAAg HoEorbbyXztgHzUynhQy5aw0SZfgBl5Yp91Dd2eqNlGVq2o= X-Google-Smtp-Source: ABdhPJzErdrjO6YvSXc8iB7PNwsHzEC94m9W/OSGRZT6oE9ujIANostZmChT79QhJdlqd3sXGuV8B29Roz8UKwDc+Vo= X-Received: by 2002:a25:c794:0:b0:64d:efc2:70eb with SMTP id w142-20020a25c794000000b0064defc270ebmr690747ybe.203.1652895477134; Wed, 18 May 2022 10:37:57 -0700 (PDT) MIME-Version: 1.0 References: <20220518163956.1145583-1-vigneshv@google.com> In-Reply-To: From: Vignesh Venkatasubramanian Date: Wed, 18 May 2022 10:37:46 -0700 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: Expose the allintra usage mode X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, May 18, 2022 at 10:01 AM James Almer wrote: > > > > On 5/18/2022 1:39 PM, Vignesh Venkatasubramanian wrote: > > libaom added an usage=allintra mode for doing better with still > > images. Expose that in the ffmpeg's wrapper. This is especially > > useful for encoding still AVIF images. > > > > Signed-off-by: Vignesh Venkatasubramanian > > --- > > libavcodec/libaomenc.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/libavcodec/libaomenc.c b/libavcodec/libaomenc.c > > index 0411773bbf..d93d1b5e3c 100644 > > --- a/libavcodec/libaomenc.c > > +++ b/libavcodec/libaomenc.c > > @@ -1300,6 +1300,9 @@ static const AVOption options[] = { > > { "usage", "Quality and compression efficiency vs speed trade-off", OFFSET(usage), AV_OPT_TYPE_INT, {.i64 = 0}, 0, INT_MAX, VE, "usage"}, > > { "good", "Good quality", 0, AV_OPT_TYPE_CONST, {.i64 = 0 /* AOM_USAGE_GOOD_QUALITY */}, 0, 0, VE, "usage"}, > > { "realtime", "Realtime encoding", 0, AV_OPT_TYPE_CONST, {.i64 = 1 /* AOM_USAGE_REALTIME */}, 0, 0, VE, "usage"}, > > +#ifdef AOM_USAGE_ALL_INTRA > > There's no need to wrap this if you're not using the actual define below. > Realtime above was added without a wrapper because libaom versions that > don't support usage == 1 just ignore the value if given (or error out). > I expect the same for this allintra one. > > It's better from an API pov that lavc always accepts the "allintra" > constant value for the usage avoption, and not depend on the libaom > version used at link time. > Makes sense. Removed the #ifdef. > > + { "allintra", "All Intra encoding", 0, AV_OPT_TYPE_CONST, {.i64 = 2 /* AOM_USAGE_ALL_INTRA */}, 0, 0, VE, "usage"}, > > +#endif > > { "tune", "The metric that the encoder tunes for. Automatically chosen by the encoder by default", OFFSET(tune), AV_OPT_TYPE_INT, {.i64 = -1}, -1, AOM_TUNE_SSIM, VE, "tune"}, > > { "psnr", NULL, 0, AV_OPT_TYPE_CONST, {.i64 = AOM_TUNE_PSNR}, 0, 0, VE, "tune"}, > > { "ssim", NULL, 0, AV_OPT_TYPE_CONST, {.i64 = AOM_TUNE_SSIM}, 0, 0, VE, "tune"}, > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". -- Vignesh _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".