From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AE56947BD1 for ; Tue, 3 Oct 2023 22:57:03 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D1FAF68CB9F; Wed, 4 Oct 2023 01:57:01 +0300 (EEST) Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B3E8768CAB0 for ; Wed, 4 Oct 2023 01:56:54 +0300 (EEST) Received: by mail-qt1-f172.google.com with SMTP id d75a77b69052e-4195fe5cf73so64881cf.1 for ; Tue, 03 Oct 2023 15:56:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696373813; x=1696978613; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rCy9PHmi1QFnOMSjr2KIkgHrFaEqh+88nDhmRuhmDO0=; b=ry3yoSOkEJj2xkzqGj+yvlUj49m6pwVUo9xVRf9LK627rxg5SXuThLIse7tiynWCYr 0pfpJ+X4BcECZYf3ACY6RT3qFaBoeucDkVYdp+RxF3lmvVE1tWenioEmN48zSio0ZAbo vYv57Gawf4LtTCMFHFxYdfy/l24JOMUTrC7+3kjOGr8JJEhHxtEkschzRtKHlr45HATd ZgJv9eHR0boyrZpIgWbwBdJP5PomrijJCy9sAqSvI2STTETjrc4Ji+FiAw+0Bi4ECHgj t3Lbgn/1uQAx2pHah5o6dZRv0W5yq5+kzb7OI6oqSer4zFnpk5sg5yVZP+yFkXC4COgz JiDg== X-Gm-Message-State: AOJu0YwbkaHX5qgeMxtcuOCbJqR6oAhPKf9qSQevoQFkm8V6VnvwoXHN LSkAANcA58/fcIZN9ZjVlGPpP/J9BLmVtPYt0zniEvrwTfRddxGpwpY= X-Google-Smtp-Source: AGHT+IG0gCqhlDFlc6N3eIaFGG3eMwra2xhWFOD/RhbPoES5kGF8S/nuNtpwdU2VPyfKNUEFFt5ZRCF9BSSdX4of8cM= X-Received: by 2002:a05:622a:1887:b0:403:96e3:4745 with SMTP id v7-20020a05622a188700b0040396e34745mr100771qtc.20.1696373812887; Tue, 03 Oct 2023 15:56:52 -0700 (PDT) MIME-Version: 1.0 References: <20230926173742.2623244-1-vigneshv@google.com> In-Reply-To: <20230926173742.2623244-1-vigneshv@google.com> Date: Tue, 3 Oct 2023 15:56:41 -0700 Message-ID: To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH] avformat/mov: Add support for demuxing still HEIC images X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vignesh Venkat via ffmpeg-devel Reply-To: FFmpeg development discussions and patches Cc: Vignesh Venkat Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: T24gVHVlLCBTZXAgMjYsIDIwMjMgYXQgMTA6MzfigK9BTSBWaWduZXNoIFZlbmthdGFzdWJyYW1h bmlhbgo8dmlnbmVzaHZAZ29vZ2xlLmNvbT4gd3JvdGU6Cj4KPiBUaGV5IGFyZSBzaW1pbGFyIHRv IEFWSUYgaW1hZ2VzIChib3RoIHVzZSB0aGUgSEVJRiBjb250YWluZXIpLgo+IFRoZSBvbmx5IGFk ZGl0aW9uYWwgd29yayBuZWVkZWQgaXMgdG8gcGFyc2UgdGhlIGh2Y0MgYm94IGFuZCBwdXQKPiBp dCBpbiB0aGUgZXh0cmFkYXRhLgo+Cj4gV2l0aCB0aGlzIHBhdGNoIGFwcGxpZWQsIGZmbXBlZyAo d2hlbiBidWlsdCB3aXRoIGFuIEhFVkMgZGVjb2RlcikKPiBpcyBhYmxlIHRvIGRlY29kZSB0aGUg ZmlsZXMgaW4KPiBodHRwczovL2dpdGh1Yi5jb20vbm9raWF0ZWNoL2hlaWYvdHJlZS9naC1wYWdl cy9jb250ZW50L2ltYWdlcwo+Cj4gUGFydGlhbGx5IGZpeGVzIHRyYWMgdGlja2V0ICM2NTIxLgo+ Cj4gU2lnbmVkLW9mZi1ieTogVmlnbmVzaCBWZW5rYXRhc3VicmFtYW5pYW4gPHZpZ25lc2h2QGdv b2dsZS5jb20+Cj4gLS0tCj4gIGxpYmF2Zm9ybWF0L2lzb20uaCB8ICAyICsrCj4gIGxpYmF2Zm9y bWF0L21vdi5jICB8IDM4ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystCj4g IDIgZmlsZXMgY2hhbmdlZCwgMzkgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+Cj4gZGlm ZiAtLWdpdCBhL2xpYmF2Zm9ybWF0L2lzb20uaCBiL2xpYmF2Zm9ybWF0L2lzb20uaAo+IGluZGV4 IDNkMzc1ZDdhNDYuLmIzMGI5ZGE2NWUgMTAwNjQ0Cj4gLS0tIGEvbGliYXZmb3JtYXQvaXNvbS5o Cj4gKysrIGIvbGliYXZmb3JtYXQvaXNvbS5oCj4gQEAgLTMyNyw2ICszMjcsOCBAQCB0eXBlZGVm IHN0cnVjdCBNT1ZDb250ZXh0IHsKPiAgICAgICAgICBpbnQ2NF90IGV4dGVudF9vZmZzZXQ7Cj4g ICAgICB9ICphdmlmX2luZm87Cj4gICAgICBpbnQgYXZpZl9pbmZvX3NpemU7Cj4gKyAgICBpbnQ2 NF90IGh2Y0Nfb2Zmc2V0Owo+ICsgICAgaW50IGh2Y0Nfc2l6ZTsKPiAgICAgIGludCBpbnRlcmxl YXZlZF9yZWFkOwo+ICB9IE1PVkNvbnRleHQ7Cj4KPiBkaWZmIC0tZ2l0IGEvbGliYXZmb3JtYXQv bW92LmMgYi9saWJhdmZvcm1hdC9tb3YuYwo+IGluZGV4IDE5OTZlMDAyOGMuLmNlYzljYjVmZTEg MTAwNjQ0Cj4gLS0tIGEvbGliYXZmb3JtYXQvbW92LmMKPiArKysgYi9saWJhdmZvcm1hdC9tb3Yu Ywo+IEBAIC0xMjE4LDcgKzEyMTgsOCBAQCBzdGF0aWMgaW50IG1vdl9yZWFkX2Z0eXAoTU9WQ29u dGV4dCAqYywgQVZJT0NvbnRleHQgKnBiLCBNT1ZBdG9tIGF0b20pCj4gICAgICAgICAgYy0+aXNv bSA9IDE7Cj4gICAgICBhdl9sb2coYy0+ZmMsIEFWX0xPR19ERUJVRywgIklTTzogRmlsZSBUeXBl IE1ham9yIEJyYW5kOiAlLjRzXG4iLChjaGFyICopJnR5cGUpOwo+ICAgICAgYXZfZGljdF9zZXQo JmMtPmZjLT5tZXRhZGF0YSwgIm1ham9yX2JyYW5kIiwgdHlwZSwgMCk7Cj4gLSAgICBjLT5pc19z dGlsbF9waWN0dXJlX2F2aWYgPSAhc3RybmNtcCh0eXBlLCAiYXZpZiIsIDQpOwo+ICsgICAgYy0+ aXNfc3RpbGxfcGljdHVyZV9hdmlmID0gIXN0cm5jbXAodHlwZSwgImF2aWYiLCA0KSB8fAo+ICsg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIXN0cm5jbXAodHlwZSwgIm1pZjEiLCA0KTsK PiAgICAgIG1pbm9yX3ZlciA9IGF2aW9fcmIzMihwYik7IC8qIG1pbm9yIHZlcnNpb24gKi8KPiAg ICAgIGF2X2RpY3Rfc2V0X2ludCgmYy0+ZmMtPm1ldGFkYXRhLCAibWlub3JfdmVyc2lvbiIsIG1p bm9yX3ZlciwgMCk7Cj4KPiBAQCAtNDkxMSw2ICs0OTEyLDE2IEBAIHN0YXRpYyBpbnQgYXZpZl9h ZGRfc3RyZWFtKE1PVkNvbnRleHQgKmMsIGludCBpdGVtX2lkKQo+ICAgICAgc3QtPnByaXZfZGF0 YSA9IHNjOwo+ICAgICAgc3QtPmNvZGVjcGFyLT5jb2RlY190eXBlID0gQVZNRURJQV9UWVBFX1ZJ REVPOwo+ICAgICAgc3QtPmNvZGVjcGFyLT5jb2RlY19pZCA9IEFWX0NPREVDX0lEX0FWMTsKPiAr ICAgIGlmIChjLT5odmNDX29mZnNldCA+PSAwKSB7Cj4gKyAgICAgICAgaW50IHJldDsKPiArICAg ICAgICBpbnQ2NF90IHBvcyA9IGF2aW9fdGVsbChjLT5mYy0+cGIpOwo+ICsgICAgICAgIHN0LT5j b2RlY3Bhci0+Y29kZWNfaWQgPSBBVl9DT0RFQ19JRF9IRVZDOwo+ICsgICAgICAgIGF2aW9fc2Vl ayhjLT5mYy0+cGIsIGMtPmh2Y0Nfb2Zmc2V0LCBTRUVLX1NFVCk7Cj4gKyAgICAgICAgcmV0ID0g ZmZfZ2V0X2V4dHJhZGF0YShjLT5mYywgc3QtPmNvZGVjcGFyLCBjLT5mYy0+cGIsIGMtPmh2Y0Nf c2l6ZSk7Cj4gKyAgICAgICAgaWYgKHJldCA8IDApCj4gKyAgICAgICAgICAgIHJldHVybiByZXQ7 Cj4gKyAgICAgICAgYXZpb19zZWVrKGMtPmZjLT5wYiwgcG9zLCBTRUVLX1NFVCk7Cj4gKyAgICB9 Cj4gICAgICBzYy0+ZmZpbmRleCA9IHN0LT5pbmRleDsKPiAgICAgIGMtPnRyYWtfaW5kZXggPSBz dC0+aW5kZXg7Cj4gICAgICBzdC0+YXZnX2ZyYW1lX3JhdGUubnVtID0gc3QtPmF2Z19mcmFtZV9y YXRlLmRlbiA9IDE7Cj4gQEAgLTQ5NTMsNiArNDk2NCw4IEBAIHN0YXRpYyBpbnQgYXZpZl9hZGRf c3RyZWFtKE1PVkNvbnRleHQgKmMsIGludCBpdGVtX2lkKQo+Cj4gIHN0YXRpYyBpbnQgbW92X3Jl YWRfbWV0YShNT1ZDb250ZXh0ICpjLCBBVklPQ29udGV4dCAqcGIsIE1PVkF0b20gYXRvbSkKPiAg ewo+ICsgICAgYy0+aHZjQ19vZmZzZXQgPSAtMTsKPiArICAgIGMtPmh2Y0Nfc2l6ZSA9IDA7Cj4g ICAgICB3aGlsZSAoYXRvbS5zaXplID4gOCkgewo+ICAgICAgICAgIHVpbnQzMl90IHRhZzsKPiAg ICAgICAgICBpZiAoYXZpb19mZW9mKHBiKSkKPiBAQCAtNzgyNiw2ICs3ODM5LDI4IEBAIHN0YXRp YyBpbnQgbW92X3JlYWRfaWxvYyhNT1ZDb250ZXh0ICpjLCBBVklPQ29udGV4dCAqcGIsIE1PVkF0 b20gYXRvbSkKPiAgICAgIHJldHVybiBhdG9tLnNpemU7Cj4gIH0KPgo+ICtzdGF0aWMgaW50IG1v dl9yZWFkX2lwcnAoTU9WQ29udGV4dCAqYywgQVZJT0NvbnRleHQgKnBiLCBNT1ZBdG9tIGF0b20p Cj4gK3sKPiArICAgIGludCBzaXplID0gYXZpb19yYjMyKHBiKTsKPiArICAgIGlmIChhdmlvX3Js MzIocGIpICE9IE1LVEFHKCdpJywncCcsJ2MnLCdvJykpCj4gKyAgICAgICAgcmV0dXJuIEFWRVJS T1JfSU5WQUxJRERBVEE7Cj4gKyAgICBzaXplIC09IDg7Cj4gKyAgICB3aGlsZSAoc2l6ZSA+IDAp IHsKPiArICAgICAgICBpbnQgc3ViX3NpemUsIHN1Yl90eXBlOwo+ICsgICAgICAgIHN1Yl9zaXpl ID0gYXZpb19yYjMyKHBiKTsKPiArICAgICAgICBzdWJfdHlwZSA9IGF2aW9fcmwzMihwYik7Cj4g KyAgICAgICAgc3ViX3NpemUgLT0gODsKPiArICAgICAgICBzaXplIC09IHN1Yl9zaXplICsgODsK PiArICAgICAgICBpZiAoc3ViX3R5cGUgPT0gTUtUQUcoJ2gnLCd2JywnYycsJ0MnKSkgewo+ICsg ICAgICAgICAgICBjLT5odmNDX29mZnNldCA9IGF2aW9fdGVsbChwYik7Cj4gKyAgICAgICAgICAg IGMtPmh2Y0Nfc2l6ZSA9IHN1Yl9zaXplOwo+ICsgICAgICAgICAgICBicmVhazsKPiArICAgICAg ICB9Cj4gKyAgICAgICAgYXZpb19za2lwKHBiLCBzdWJfc2l6ZSk7Cj4gKyAgICB9Cj4gKyAgICBy ZXR1cm4gYXRvbS5zaXplOwo+ICt9Cj4gKwo+ICBzdGF0aWMgY29uc3QgTU9WUGFyc2VUYWJsZUVu dHJ5IG1vdl9kZWZhdWx0X3BhcnNlX3RhYmxlW10gPSB7Cj4gIHsgTUtUQUcoJ0EnLCdDJywnTCcs J1InKSwgbW92X3JlYWRfYWNsciB9LAo+ICB7IE1LVEFHKCdBJywnUCcsJ1InLCdHJyksIG1vdl9y ZWFkX2F2aWQgfSwKPiBAQCAtNzkzMyw2ICs3OTY4LDcgQEAgc3RhdGljIGNvbnN0IE1PVlBhcnNl VGFibGVFbnRyeSBtb3ZfZGVmYXVsdF9wYXJzZV90YWJsZVtdID0gewo+ICB7IE1LVEFHKCdwJywn YycsJ20nLCdDJyksIG1vdl9yZWFkX3BjbWMgfSwgLyogUENNIGNvbmZpZ3VyYXRpb24gYm94ICov Cj4gIHsgTUtUQUcoJ3AnLCdpJywndCcsJ20nKSwgbW92X3JlYWRfcGl0bSB9LAo+ICB7IE1LVEFH KCdlJywndicsJ2MnLCdDJyksIG1vdl9yZWFkX2dsYmwgfSwKPiAreyBNS1RBRygnaScsJ3AnLCdy JywncCcpLCBtb3ZfcmVhZF9pcHJwIH0sCj4gIHsgMCwgTlVMTCB9Cj4gIH07Cj4KPiAtLQo+IDIu NDIuMC41MTUuZzM4MGZjN2NjZDEtZ29vZwo+CgpBbnkgY29tbWVudHMvb2JqZWN0aW9ucyBvbiBt ZXJnaW5nIHRoaXM/CgotLSAKVmlnbmVzaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpmZm1wZWctZGV2ZWwgbWFpbGluZyBsaXN0CmZmbXBlZy1kZXZlbEBm Zm1wZWcub3JnCmh0dHBzOi8vZmZtcGVnLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ZmbXBlZy1kZXZl bAoKVG8gdW5zdWJzY3JpYmUsIHZpc2l0IGxpbmsgYWJvdmUsIG9yIGVtYWlsCmZmbXBlZy1kZXZl bC1yZXF1ZXN0QGZmbXBlZy5vcmcgd2l0aCBzdWJqZWN0ICJ1bnN1YnNjcmliZSIuCg==