From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CAF53432B7 for ; Mon, 27 Jun 2022 17:18:10 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A865868B8BF; Mon, 27 Jun 2022 20:18:07 +0300 (EEST) Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com [209.85.128.171]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7675068B8A4 for ; Mon, 27 Jun 2022 20:18:01 +0300 (EEST) Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-31bf327d4b5so2961047b3.13 for ; Mon, 27 Jun 2022 10:18:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=i4H3JJckZtkkSNfnvacfcwgU2n0Rad6tA5h3EGkqM8c=; b=D68ow8UPXsEpL19ly0f6hwDSE66wP473aHhpiTwosku+SEFy+h/J+GlyR/ZjtYDDce plFmHJ3J/7ZrK49a5jahSG7eUTDt2uRryAaM0VLMpb1ybMitgzODXLfu89yOG/Npirog sFP2LLXEMZSrgJ6JVhPMcstAsRwK9QxzVB6mwQLrASfC1FEoK1Ndk4uzT2nJ3uj8MRNx dYc2gno4VCLiTpGTqnfaitTrQqfndsUCQd1VuNG8HwiffP/UB3bHRMnvHsdOKl0iIwiC vDLA8oQSLM3BQgf5e+Bj7q7X8sO1FbYN3v/XmcDNgj2eylRZxGCxwhXFjxWPJm5+Vd2K RWpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=i4H3JJckZtkkSNfnvacfcwgU2n0Rad6tA5h3EGkqM8c=; b=C9yTEFHIPfwfsFaFvJQcqOTUOCXa7d/xgQvzbwgHQCvSTmC348y3KN6teaqfSXdZJh hJqR6chQRdiopjzsazJeZPqf+InL2X/vkzloJxFG4SrOyz4Nn19x8fsFetQYyTgO67xR XHiyPwXLgOoq/gGdQV2hO1zgpCu+sjXtvHX2yd0NwXz3GMBJG1hg8aJBjGc5k51hVFqN naU7Z1b/wOGpDckMRBcnR8BXeBd+nceusE4fpWHlRuBVXrIBUmVweV3zv/2J+HP+bIf0 0JGpus/0bSvmynpeacj8hiMvZT1ZTXuH+TxzEw5X81ArouZgImpCOaKMyT57UmZUh3TY k+qg== X-Gm-Message-State: AJIora8rUU1gY3o6lCGhGUiEMJtL3LUS3lWp1zMPzAxLYx+LbX9FZ8DI Cdhj+jzb0NnvpfxfTnBH8DM0mANkgAsPhuLxL0g70mnM3OY= X-Google-Smtp-Source: AGRyM1tB2jKKNNqzSN9osl+S8dusKLbbQ59XyyCrCBP/vlRFn5YkWCW2v+t55W/WIPB2/kNjPC6wmVDgLck83bVeK+I= X-Received: by 2002:a81:909:0:b0:317:684a:3f83 with SMTP id 9-20020a810909000000b00317684a3f83mr16671442ywj.139.1656350279458; Mon, 27 Jun 2022 10:17:59 -0700 (PDT) MIME-Version: 1.0 References: <20220601180556.949526-1-vigneshv@google.com> In-Reply-To: From: Vignesh Venkatasubramanian Date: Mon, 27 Jun 2022 10:17:46 -0700 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avformat/movenc: Support alpha channel for AVIF X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, Jun 27, 2022 at 9:48 AM James Almer wrote: > > On 6/27/2022 1:43 PM, Vignesh Venkatasubramanian wrote: > > On Tue, Jun 21, 2022 at 10:12 AM Vignesh Venkatasubramanian > > wrote: > >> > >> On Mon, Jun 13, 2022 at 10:17 AM James Zern > >> wrote: > >>> > >>> On Wed, Jun 1, 2022 at 11:06 AM Vignesh Venkatasubramanian > >>> wrote: > >>>> > >>>> AVIF specification allows for alpha channel as an auxiliary item (in > >>>> case of still images) or as an auxiliary track (in case of animated > >>>> images). Add support for both of these. The AVIF muxer will take > >>>> exactly two streams (when alpha is present) as input (first one being > >>>> the YUV planes and the second one being the alpha plane). > >>>> > >>>> The input has to come from two different images (one of it color and > >>>> the other one being alpha), or it can come from a single file > >>>> source with the alpha channel extracted using the "alphaextract" > >>>> filter. > >>>> > >>>> Example using alphaextract: > >>>> ffmpeg -i rgba.png -filter_complex "[0:v]alphaextract[a]" -map 0 -map "[a]" -still-picture 1 avif_with_alpha.avif > >>>> > >>>> Example using two sources (first source can be in any pixel format and > >>>> the second source has to be in monochrome grey pixel format): > >>>> ffmpeg -i color.avif -i grey.avif -map 0 -map 1 -c copy avif_with_alpha.avif > >>>> > >>>> The generated files pass the compliance checks in Compliance Warden: > >>>> https://github.com/gpac/ComplianceWarden > >>>> > >>>> libavif (the reference avif library) is able to decode the files > >>>> generated using this patch. > >>>> > >>>> They also play back properly (with transparent background) in: > >>>> 1) Chrome > >>>> 2) Firefox (only still AVIF, no animation support) > >>>> > >>>> Signed-off-by: Vignesh Venkatasubramanian > >>>> --- > >>>> libavformat/movenc.c | 188 +++++++++++++++++++++++++++++-------------- > >>>> libavformat/movenc.h | 4 +- > >>>> 2 files changed, 130 insertions(+), 62 deletions(-) > >>>> > >>> > >>> lgtm. > >>> _______________________________________________ > >>> ffmpeg-devel mailing list > >>> ffmpeg-devel@ffmpeg.org > >>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > >>> > >>> To unsubscribe, visit link above, or email > >>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > >> > >> Any more comments on this? If not can this be merged please? :) > >> > > > > Another ping on this please. > > > >> -- > >> Vignesh > > I thought James Zern had push access, which is why i didn't apply it as > soon as he reviewed it. Sorry. > > Pushed it now. > Thanks! _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". -- Vignesh _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".