From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 63C6743BEF for ; Fri, 22 Jul 2022 18:21:15 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CE9B468B701; Fri, 22 Jul 2022 21:21:12 +0300 (EEST) Received: from mail-yb1-f172.google.com (mail-yb1-f172.google.com [209.85.219.172]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 637BF68B4C9 for ; Fri, 22 Jul 2022 21:21:06 +0300 (EEST) Received: by mail-yb1-f172.google.com with SMTP id i206so9401930ybc.5 for ; Fri, 22 Jul 2022 11:21:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=AzkGfqwNBJvPpw0R1c3zeu9NrUM204SsaeA1wKcoZ1c=; b=GbKk/rkjN8LjhI1H6Own6BGLtasJg8CxzDo5S0UzIfS9gNppGETE2cyQk+qYWxDfsh Kk/gPqvv/ofQdZLPOlHnMdkoQN+IHPl8vcyCWVMAdQhycSl1W8N2l9sdz0tJXEE+PjOl AkzHSsOeAukIH8mrF6iFxM/KjJa335V+CcpqJw5YOE3WxXrbror6bzNUaXth8WWkLbNy CLyVL2zE239PSXVHsZC+Gl99zmcSl6l1XqvC7fBGYCi60GMlsb1H0mY175278XD01+CG 1OIJ/hZAFOYTFt5ih/akNK22srXUqOf6eyQiWs+w6RDQtBgQiWKIW0Ls8iomGWCTGQpM wVWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=AzkGfqwNBJvPpw0R1c3zeu9NrUM204SsaeA1wKcoZ1c=; b=GLDHyu2kFcsnh0Uwdil5St6KInBoP9Yqn/XRxTzPdeKYETDep58DhXQZqVLbkcomcl RP1VKfLvFWdsn1VEx9gBkKdqB3gKtlN8d7oGAYSmHtPUvA4M8WhCiUymHzt2BR4ZSJ1X 0rDlanaUI19JVjLOyDtvxN7YitLycciLL2GyyzuwPFQ2lwpsJBg1Vl465HnNuIW7rOHb cFG63ZvyS/E90DhTOCpdOi4a31BIf928izK4IDjpxgmreThb7fa5vE8rw/cY0SCAiYPu 9HYHBfVzeDLC6jCvLwr4PcrL3tx2NeiurTdY0XRVUIWedbpMlHLqH4joDM2Np7fZ9k+p /v3A== X-Gm-Message-State: AJIora8jrORroFds3Bi4q9XmvoaR0R55OZs8zQOl/QzE9/eaNBcRJ0Xn tEJFttlVPT4+vB5c3U5J4yfFdxAXMTi8tnC8Fmu6bHYgofAAYA== X-Google-Smtp-Source: AGRyM1scY5YOCrQeVX4u1pEsecP7JFwAumj0yrRjSmOTnxfOeGc/Y3Xn3srfdgoRl2JM6ATsjoauD6sLUUGRFgZpPeY= X-Received: by 2002:a25:7c81:0:b0:66f:c8b4:9c92 with SMTP id x123-20020a257c81000000b0066fc8b49c92mr1068930ybc.189.1658514064536; Fri, 22 Jul 2022 11:21:04 -0700 (PDT) MIME-Version: 1.0 References: <20220630210434.1551769-1-vigneshv@google.com> In-Reply-To: From: Vignesh Venkatasubramanian Date: Fri, 22 Jul 2022 11:20:53 -0700 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: Rework the AVIF parser to handle multiple items X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, Jul 13, 2022 at 9:12 AM Vignesh Venkatasubramanian wrote: > > On Mon, Jul 11, 2022 at 3:25 PM James Zern > wrote: > > > > On Thu, Jun 30, 2022 at 2:04 PM Vignesh Venkatasubramanian > > wrote: > > > > > > Stores the item ids of all the items found in the file and > > > processes the primary item at the end of the meta box. This patch > > > does not change any behavior. It sets up the code for parsing > > > alpha channel (and possibly images with 'grid') in follow up > > > patches. > > > > > > Signed-off-by: Vignesh Venkatasubramanian > > > --- > > > libavformat/isom.h | 4 ++ > > > libavformat/mov.c | 148 ++++++++++++++++++++++++++++----------------- > > > 2 files changed, 97 insertions(+), 55 deletions(-) > > > > > > [...] > > > > @@ -4692,9 +4755,25 @@ static int mov_read_meta(MOVContext *c, > > AVIOContext *pb, MOVAtom atom) > > tag = avio_rl32(pb); > > atom.size -= 4; > > if (tag == MKTAG('h','d','l','r')) { > > + int ret; > > avio_seek(pb, -8, SEEK_CUR); > > atom.size += 8; > > - return mov_read_default(c, pb, atom); > > + ret = mov_read_default(c, pb, atom); > > + if (ret < 0) > > > > In some other cases these two lines are combined, if ((ret = ... > > > > Done. > > > + return ret; > > + if (c->is_still_picture_avif) { > > + int ret; > > + // Add a stream for the YUV planes (primary item). > > + ret = avif_add_stream(c, c->primary_item_id); > > + if (ret) > > > > This could be updated too and use '< 0' to match other code. > > > > Done. > > > + return ret; > > + // For still AVIF images, the meta box contains all the > > + // necessary information that would generally be > > provided by the > > + // moov box. So simply mark that we have found the moov box so > > + // that parsing can continue. > > + c->found_moov = 1; > > + } > > + return ret; > > } > > _______________________________________________ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > To unsubscribe, visit link above, or email > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > > > > -- > Vignesh Any further comments on this one? Please note that i have abandoned the second patch in this list. But this one is still up for merging. -- Vignesh _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".