From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A1986401F5 for ; Tue, 21 Jun 2022 17:12:31 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E740E68B66C; Tue, 21 Jun 2022 20:12:28 +0300 (EEST) Received: from mail-yb1-f175.google.com (mail-yb1-f175.google.com [209.85.219.175]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1242768B0EE for ; Tue, 21 Jun 2022 20:12:22 +0300 (EEST) Received: by mail-yb1-f175.google.com with SMTP id i15so20726030ybp.1 for ; Tue, 21 Jun 2022 10:12:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=57hT1ZPzUh3U0gy+VMpTWOo7ijhk1e8/BRwbm+zR+Ys=; b=BS4/p8sUOsiTiVgvy9ygM4iEMUle3TkMy48peI21DfY++RT+DtSLstZnmLkosvBzvA v2pFdpCq4xdcQPXTan9wZiukFB0pbc7x+T8lj48Nghi1refKM8Gr4p8IrkxSEfam/g9/ waahWwAsgrS6I7fdxKm3s0QxUGgP4mkoqC9CeNGBGRiKQu0375RF5CpvCmix46jxy18V pI0fZXmPxoObTF8Df7KcyAyRVj3UofR7a4QYmQtq2ncvx1svME171uikzdw2X46ekysT CUbjjiFbW1BM2o3Orpvt4Hlmw6dJlMJfCm8AcqrrBZ35NdVIGBOdTq6NulsbIOjNw+vw HYBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=57hT1ZPzUh3U0gy+VMpTWOo7ijhk1e8/BRwbm+zR+Ys=; b=zPlAW7677qvGs0MEB/pFvWirVYSZx81A1bWcQejj58x9ywlqxWMIlf94NpK6WSl/+D MR7UmCKVWiH+6BseTEI1vqeOqEomJY3KspacFIRGUr/Q1rIOlxKOJbUi8owpFxqYStvx byKCnK+ot0z/8tkqHpLVRo/QQjhEwcVPv1hSICzFOAA2uyHSEDWlOaPmLWq5dC52elD1 2khZhOz60a91rvnRmcZ8J4XvXy3+sbmj8q3tJBkCPeNmGepBuTc/2l+Y/UD6JFic7gTY fqRZJvVAtZ7tzOraqguabFsPEi/5CfFYBBn/vsMcvJsznzDixZJi2B/LPem7wvRzsDsj 3ckg== X-Gm-Message-State: AJIora8M0ylb+AX/FAmVxIB2HV2r3nsw1Y3vaMSwex21wrDqLS5SMvxv bsa9Erh1be90eVLJpZd2cw8kg+Rthln6mZHbEbzbRzM9v24= X-Google-Smtp-Source: AGRyM1szAhHpbiSRw96aPW6svn1GRiBd2nySS1dPDHUDknaO0CS9SALU/XDRzmxSyNXhOfAiKs0bn8/p7pMyAPUkX/Q= X-Received: by 2002:a25:d653:0:b0:668:f4c5:4a84 with SMTP id n80-20020a25d653000000b00668f4c54a84mr15039468ybg.172.1655831539641; Tue, 21 Jun 2022 10:12:19 -0700 (PDT) MIME-Version: 1.0 References: <20220601180556.949526-1-vigneshv@google.com> In-Reply-To: From: Vignesh Venkatasubramanian Date: Tue, 21 Jun 2022 10:12:07 -0700 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avformat/movenc: Support alpha channel for AVIF X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, Jun 13, 2022 at 10:17 AM James Zern wrote: > > On Wed, Jun 1, 2022 at 11:06 AM Vignesh Venkatasubramanian > wrote: > > > > AVIF specification allows for alpha channel as an auxiliary item (in > > case of still images) or as an auxiliary track (in case of animated > > images). Add support for both of these. The AVIF muxer will take > > exactly two streams (when alpha is present) as input (first one being > > the YUV planes and the second one being the alpha plane). > > > > The input has to come from two different images (one of it color and > > the other one being alpha), or it can come from a single file > > source with the alpha channel extracted using the "alphaextract" > > filter. > > > > Example using alphaextract: > > ffmpeg -i rgba.png -filter_complex "[0:v]alphaextract[a]" -map 0 -map "[a]" -still-picture 1 avif_with_alpha.avif > > > > Example using two sources (first source can be in any pixel format and > > the second source has to be in monochrome grey pixel format): > > ffmpeg -i color.avif -i grey.avif -map 0 -map 1 -c copy avif_with_alpha.avif > > > > The generated files pass the compliance checks in Compliance Warden: > > https://github.com/gpac/ComplianceWarden > > > > libavif (the reference avif library) is able to decode the files > > generated using this patch. > > > > They also play back properly (with transparent background) in: > > 1) Chrome > > 2) Firefox (only still AVIF, no animation support) > > > > Signed-off-by: Vignesh Venkatasubramanian > > --- > > libavformat/movenc.c | 188 +++++++++++++++++++++++++++++-------------- > > libavformat/movenc.h | 4 +- > > 2 files changed, 130 insertions(+), 62 deletions(-) > > > > lgtm. > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". Any more comments on this? If not can this be merged please? :) -- Vignesh _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".