From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 67724437D2 for ; Tue, 28 Jun 2022 18:58:21 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A55F868B997; Tue, 28 Jun 2022 21:58:19 +0300 (EEST) Received: from mail-yw1-f177.google.com (mail-yw1-f177.google.com [209.85.128.177]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D03B068B817 for ; Tue, 28 Jun 2022 21:58:13 +0300 (EEST) Received: by mail-yw1-f177.google.com with SMTP id 00721157ae682-31bf3656517so36009667b3.12 for ; Tue, 28 Jun 2022 11:58:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=0HZjdHvDEJ2PfrX9XNixTCJnkJ2r3x/I8Rsl+uTHlRg=; b=HqAjRXLe6lME5pAkkMZAK6EZGEPN1vCBwDM/3Czp9QU3xY3qTSYdtn4jaDjGvrmHDw Cbym1wDaKce3C0JEFIhX7mgF5EbijU1aQjJ7q2SI9oU64J2DfKABb0zLJiUg7dRwoB4F UQ8nc/O/U7Dvpsqgc23TmzSAEJ1cbO2bYDfwiI48g4fWitiRYEjiyELbr1FQZa97y7jL E1bM+6zWmCUXQj5qjZmWIpAcQwYP2/EIzpiteTEiP3ji9HSCQlBWmDfJCj/5mdU7PBLL 6GFOnuK3ByCy8StnVjlRlnEJ8h5e9SYZobQc22gppyfq+JCEgzoPFR5YVzzIyPmtVd1K ZNWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=0HZjdHvDEJ2PfrX9XNixTCJnkJ2r3x/I8Rsl+uTHlRg=; b=vVA4qXyKS6j5xyzVp+bkKxIPF6S7Udf8hhsTHgqh7AKVlmy54qWg7FmeSwgVvbw2lp w12VwvFhvsAkDc/S2wXxKyXioRT2B2hWReuT/FN9JMw5HO0ERSdd6N0W+9kdJmtPO0Jl u57EQARSb3stFjx+xyfGHwXFI255yUVeYWRB3uG1gCRaI46t3Yo5smviNVyy/VrYd0ie //Zo1rExkG1mpF/Pt4zzBOG+ZVRHJEn9V9I/Lpy6YDhQDHbcacZw9KwinAurcLVJIBqE ghX9SSOCugH4qarR+bHLcw8URAYRtZ7P0GbiDk44H/sMSznQ+nv7Rw71TjDnVgUHH5Nu /g2Q== X-Gm-Message-State: AJIora+S9EVvFq1P4mCNuoDAH4/VZcRxV5U1vUVRO7Bpo08RsOYQEu6A idfAyw363RgbqYOfExmwrgBtXGvhMSRNjsOwG3aRzkS921k= X-Google-Smtp-Source: AGRyM1ulxI+j/Sw/pjXk1pEZ5klu1D3QofcSJum56pzp55XTUQTm1IYt2pJ0lmiaVANN6OQwVK5mX7qouH62raXLNUg= X-Received: by 2002:a81:6ed5:0:b0:313:9109:b86 with SMTP id j204-20020a816ed5000000b0031391090b86mr24022944ywc.509.1656442692198; Tue, 28 Jun 2022 11:58:12 -0700 (PDT) MIME-Version: 1.0 References: <20220424183514.986374-1-vigneshv@google.com> <085f0277-e678-4d20-f2bf-fbf55ed959d8@gyani.pro> In-Reply-To: From: Vignesh Venkatasubramanian Date: Tue, 28 Jun 2022 11:58:00 -0700 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avformat/mov: Only read the primary item for AVIF X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, Jun 28, 2022 at 11:21 AM James Zern wrote: > > On Mon, Jun 13, 2022 at 9:32 AM Vignesh Venkatasubramanian > wrote: > > > > On Fri, Jun 10, 2022 at 10:34 AM Vignesh Venkatasubramanian > > wrote: > > > > > > On Thu, Jun 9, 2022 at 12:50 AM Gyan Doshi wrote: > > > > > > > > > > > > > > > > On 2022-06-08 10:51 pm, Vignesh Venkatasubramanian wrote: > > > > > On Thu, Jun 2, 2022 at 1:35 PM James Zern wrote: > > > > >> On Wed, Jun 1, 2022 at 1:38 PM Vignesh Venkatasubramanian > > > > >> wrote: > > > > >>> On Wed, Jun 1, 2022 at 10:30 AM James Zern wrote: > > > > >>>> On Sun, Apr 24, 2022 at 11:35 AM Vignesh Venkatasubramanian > > > > >>>> wrote: > > > > >>>>> Update the still AVIF parser to only read the primary item. With this > > > > >>>>> patch, AVIF still images with exif/icc/alpha channel will no longer > > > > >>>>> fail to parse. > > > > >>>>> > > > > >>>>> For example, this patch enables parsing of files in: > > > > >>>>> https://github.com/AOMediaCodec/av1-avif/tree/master/testFiles/Microsoft > > > > >>>>> > > > > >>>> Can some of the failing files or similar ones be added to fate? > > > > >>> There are no fate tests for AVIF parsing as of now. I was thinking > > > > >>> about adding some for the muxing. But i am not sure what can be done > > > > >>> here for the parsing. > > > > >>> > > > > >> Thanks. Are there any for general mov/mp4 parsing that could be > > > > >> extended? This looks good otherwise. > > > > > From what i see, most of the mov tests only seem to be for muxing. I'm > > > > > not entirely certain about how to add a test for AVIF parsing. If > > > > > anybody has an idea, i'd be open to adding it. > > > > > > > > Basic test would use the framemd5 muxer to compare demuxed packets with > > > > a reference. > > > > See fate-ffmpeg-streamloop > > > > > > > > > > Thank you i have added a couple of fate tests. > > > > > > I am not sure how to add the AVIF files to the fate test server. I > > > have them on Google Drive here: > > > > > > https://drive.google.com/file/d/1diZoM0Ew7Co3Yh5w5y1J-3IiBYVmUv9J/view?usp=sharing > > > https://drive.google.com/file/d/1DdrD1mW36evt40a4RkeLYpx-oojmbc3z/view?usp=sharing > > > > > > These links should be publicly available without any sign in required. > > > Please let me know if there is another preferred way of sharing test > > > files and i can share it that way. > > > > > > > Also, i forgot to mention that these files have to be uploaded under a > > new directory called "avif" in the fate server. > > > > Can you send a separate patch with the tests disabled and marked by a > TODO to enable them after the files are uploaded? > https://ffmpeg.org/developer.html#Adding-files-to-the-fate_002dsuite-dataset I have updated this patch to comment out the actual tests (with a FIXME note). I can send separate patch once the files are added to the server to uncomment the tests and remove the FIXME. > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". -- Vignesh _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".