Re: [FFmpeg-devel] [PATCH] avformat/mov: Only read the primary item for AVIF

[Vignesh Venkatasubramanian <vigneshv-at-google.com@ffmpeg.org>]

On Tue, Jun 28, 2022 at 11:21 AM James Zern
<jzern-at-google.com@ffmpeg.org> wrote:
>
> On Mon, Jun 13, 2022 at 9:32 AM Vignesh Venkatasubramanian
> <vigneshv-at-google.com@ffmpeg.org> wrote:
> >
> > On Fri, Jun 10, 2022 at 10:34 AM Vignesh Venkatasubramanian
> > <vigneshv@google.com> wrote:
> > >
> > > On Thu, Jun 9, 2022 at 12:50 AM Gyan Doshi <ffmpeg@gyani.pro> wrote:
> > > >
> > > >
> > > >
> > > > On 2022-06-08 10:51 pm, Vignesh Venkatasubramanian wrote:
> > > > > On Thu, Jun 2, 2022 at 1:35 PM James Zern <jzern@google.com> wrote:
> > > > >> On Wed, Jun 1, 2022 at 1:38 PM Vignesh Venkatasubramanian
> > > > >> <vigneshv@google.com> wrote:
> > > > >>> On Wed, Jun 1, 2022 at 10:30 AM James Zern <jzern@google.com> wrote:
> > > > >>>> On Sun, Apr 24, 2022 at 11:35 AM Vignesh Venkatasubramanian
> > > > >>>> <vigneshv-at-google.com@ffmpeg.org> wrote:
> > > > >>>>> Update the still AVIF parser to only read the primary item. With this
> > > > >>>>> patch, AVIF still images with exif/icc/alpha channel will no longer
> > > > >>>>> fail to parse.
> > > > >>>>>
> > > > >>>>> For example, this patch enables parsing of files in:
> > > > >>>>> https://github.com/AOMediaCodec/av1-avif/tree/master/testFiles/Microsoft
> > > > >>>>>
> > > > >>>> Can some of the failing files or similar ones be added to fate?
> > > > >>> There are no fate tests for AVIF parsing as of now. I was thinking
> > > > >>> about adding some for the muxing. But i am not sure what can be done
> > > > >>> here for the parsing.
> > > > >>>
> > > > >> Thanks. Are there any for general mov/mp4 parsing that could be
> > > > >> extended? This looks good otherwise.
> > > > >  From what i see, most of the mov tests only seem to be for muxing. I'm
> > > > > not entirely certain about how to add a test for AVIF parsing. If
> > > > > anybody has an idea, i'd be open to adding it.
> > > >
> > > > Basic test would use the framemd5 muxer to compare demuxed packets with
> > > > a reference.
> > > > See fate-ffmpeg-streamloop
> > > >
> > >
> > > Thank you i have added a couple of fate tests.
> > >
> > > I am not sure how to add the AVIF files to the fate test server. I
> > > have them on Google Drive here:
> > >
> > > https://drive.google.com/file/d/1diZoM0Ew7Co3Yh5w5y1J-3IiBYVmUv9J/view?usp=sharing
> > > https://drive.google.com/file/d/1DdrD1mW36evt40a4RkeLYpx-oojmbc3z/view?usp=sharing
> > >
> > > These links should be publicly available without any sign in required.
> > > Please let me know if there is another preferred way of sharing test
> > > files and i can share it that way.
> > >
> >
> > Also, i forgot to mention that these files have to be uploaded under a
> > new directory called "avif" in the fate server.
> >
>
> Can you send a separate patch with the tests disabled and marked by a
> TODO to enable them after the files are uploaded?
> https://ffmpeg.org/developer.html#Adding-files-to-the-fate_002dsuite-dataset

I have updated this patch to comment out the actual tests (with a
FIXME note). I can send separate patch once the files are added to the
server to uncomment the tests and remove the FIXME.

> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".



-- 
Vignesh
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".