From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A596D40473 for ; Fri, 22 Apr 2022 18:58:57 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9B0FC68B347; Fri, 22 Apr 2022 21:58:54 +0300 (EEST) Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com [209.85.219.174]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DB57468B1F1 for ; Fri, 22 Apr 2022 21:58:48 +0300 (EEST) Received: by mail-yb1-f174.google.com with SMTP id i20so16115527ybj.7 for ; Fri, 22 Apr 2022 11:58:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=lgkjvXE4hwymIcBNtR6xFuUntWQXGWvpIRVZylKa2Z4=; b=COtyvBYW6rOaEgtkwjAXI8ZAjiTqoW7M0uszMaqHCwJBPlvO/VmLvcAbIGozVxSY0O Rn4xmR5apZ3EsO6CMJ/IRmW1XlmnSZ0LJjuWHVeXIzxL0fTY4gn+kMyFETAtaRMbBJva 8ENrw7xrGLVC0/8tYYZZoD69QEonwTTWjnmEOWXRVUDLJdoanmEEK9rHQNe2cCJBQn/b Bc0YEyURDUPFLYRZHsqwSSzKm8eHg/0Qm7CiKIz5U3t6uV9A7FLEloIutzJJIyYMgzGt 5B21q0o3qQZDbWtOhLN2GtvC6YXPtrwSfnNx3g14WQblK5yYMSXaMW/OcCyZc9NI2apL EsWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=lgkjvXE4hwymIcBNtR6xFuUntWQXGWvpIRVZylKa2Z4=; b=guu61l6M8lfdcY0jJLGKHVQ4Vo0AnqglhGTa+rH4UcsU1opOrlmtXxOkGkt5tTNasr yd+1ygn0VWgUOncjnGKLCAU3BxRl43h/L+Hdt2p+xEBseiYYhwXoRA/AEG+0eT6VKGaQ TMgSViUxRMuEW0+oSqaVQtMBc9ChEmdCaytTC75GDIGHkVBcfVJmew/BjaDDC5e1b8uE 8kErie5jgEF10mmrnp5u9u+tY+bdXmqLkr+n688ewGahgbaRUoxsRw8n9KZxyCoKRacr OiM3ejtfby3huqa9uDvtaK0XNuZjIor/FJrWcjIy6fz+hHSbF5LsnBe9OhmhQ9q1Sy0v X0cQ== X-Gm-Message-State: AOAM5309Y9/Vm5Hnt1G0ksjXyauT0v5++K/p8DfzDd99Ss6sSFwwyXWt 3aCm+nv8MbFytu9SmzL5VNdCheX3BuFzGklX4sQGfTEJ9V8= X-Google-Smtp-Source: ABdhPJxwHM9I17vffKDHy8JiiFfrlW5biHeCsvzenrie4ab5mjqpuC2x4c0Q9Hn6l91Hg+L4yssfVXpoFnm9NxLHkUc= X-Received: by 2002:a25:34ca:0:b0:645:716c:8cd1 with SMTP id b193-20020a2534ca000000b00645716c8cd1mr6222016yba.83.1650653926969; Fri, 22 Apr 2022 11:58:46 -0700 (PDT) MIME-Version: 1.0 References: <20220419205704.3548965-1-vigneshv@google.com> <62f20540-ad9f-cda3-20ff-9c4952e220a4@gyani.pro> <49b6da7c-854c-19ce-46cf-caefa96c70f2@gyani.pro> In-Reply-To: <49b6da7c-854c-19ce-46cf-caefa96c70f2@gyani.pro> From: Vignesh Venkatasubramanian Date: Fri, 22 Apr 2022 11:58:35 -0700 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avformat/mov: Add support for still image AVIF parsing X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, Apr 21, 2022 at 9:18 PM Gyan Doshi wrote: > > > > On 2022-04-21 09:46 pm, Vignesh Venkatasubramanian wrote: > > On Thu, Apr 21, 2022 at 2:08 AM Gyan Doshi wrote: > >> > >> > >> On 2022-04-20 09:54 am, Gyan Doshi wrote: > >>> > >>> On 2022-04-20 02:49 am, Paul B Mahol wrote: > >>>> On Tue, Apr 19, 2022 at 10:57 PM Vignesh Venkatasubramanian < > >>>> vigneshv-at-google.com@ffmpeg.org> wrote: > >>>> > >>>>> Add support for parsing AVIF still images. This patches supports > >>>>> AVIF still images that have exactly 1 item (i.e.) no alpha channel. > >>>>> Essentially, we will have to parse the "iloc" box and populate > >>>>> the mov index. > >>>>> > >>>>> With this patch, we can decode still AVIF images like so: > >>>>> ffmpeg -i image.avif image.png > >>>>> > >>>>> Partially fixes trac ticket #7621 > >>>>> > >>>> LGTM > >>> Will push tomorrow if no one else has. > >> Can you provide a sample AVIF image and command that this patch allows > >> decoding of? > >> > >> I tried a couple of samples from Netflix[1] and MS[2] and none worked, > >> even with forcing MOV demuxer ("moov atom not found" or "error reading > >> header"). > > Thanks for verifying. The test files you tried are invalid/not > > supported by this patch. Please see the explanation below. > > > >> [1]: http://download.opencontent.netflix.com/?prefix=AV1/Chimera/AVIF/ > > These files are not valid AVIF since they don't have the major brand > > set to "mif1" and not "avif". They are also missing a few other > > mandatory boxes. libavif (the reference AVIF library) also is not able > > to parse these files. These files were likely made when the AVIF > > specification was not yet finalized. > > > > $ ./avifdec --info Chimera-AV1-8bit-1280x720-3363kbps-100.avif > > ERROR: Failed to decode image: BMFF parsing failed > > Diagnostics: > > * [Strict] Item ID 1 of type 'av01' is missing mandatory pixi property > > > >> [2]: > >> https://github.com/AOMediaCodec/av1-avif/tree/master/testFiles/Microsoft > >> > > These files have EXIF metadata and will contain more than one item > > entry in the iloc box. This patch does not support that (however, i > > have a follow-up patch to fix this). The files in this directory > > return AVERROR_PATCHWELCOME as intended. > > > > For a set of working AVIF files that are supported by this patch you > > can try the files under "Link-U" and "Netflix" subdirectories of this repo: > > > > https://github.com/AOMediaCodec/av1-avif/tree/master/testFiles/Link-U > > > > https://github.com/AOMediaCodec/av1-avif/tree/master/testFiles/Netflix/avif > Ok, these work. > > > The command is as mentioned in the commit message: > > ./ffmpeg -i output.png > > > > Please let me know if you have more questions. Thank you! > > Add informative log msgs in the patchwelcome blocks. > Done. > Are there plans to add support for transforms like cropping, rotation? > I have follow-up patches for fixing some of the AVERROR_PATCHWELCOME cases. I don't have working code for transforms. It is something that i will look into in the future once the basic AVIF encode/decode support lands in ffmpeg. > Regards, > Gyan > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". -- Vignesh _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".