Re: [FFmpeg-devel] [PATCH] avformat/mov: Add support for demuxing still HEIC images - Vignesh Venkat via ffmpeg-devel

From: Vignesh Venkat via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: Vittorio Giovara <vittorio.giovara@gmail.com>
Cc: Vignesh Venkat <vigneshv@google.com>,
	FFmpeg development discussions and patches
	<ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avformat/mov: Add support for demuxing still HEIC images
Date: Wed, 4 Oct 2023 09:36:23 -0700
Message-ID: <CAOJaEPJG8wF0sdz=+o+RU8hQDQOCgwnDqmq5VqHg2Hrf96SgBg@mail.gmail.com> (raw)
In-Reply-To: <CABLWnS_k46N_gKMi7uvAXkRoh9-n2N6Zy7x-weLjG7OC=q9VGA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1906 bytes --]

On Tue, Oct 3, 2023 at 9:40 PM Vittorio Giovara
<vittorio.giovara@gmail.com> wrote:
>
>
>
> On Wed, Oct 4, 2023 at 12:02 AM Vignesh Venkat via ffmpeg-devel <ffmpeg-devel@ffmpeg.org> wrote:
>>
>> On Tue, Oct 3, 2023 at 6:32 PM Vittorio Giovara
>> <vittorio.giovara@gmail.com> wrote:
>> >
>> > On Tue, Oct 3, 2023 at 8:30 PM Steven Liu <lingjiujianke@gmail.com> wrote:
>> >
>> > > > > 2.42.0.515.g380fc7ccd1-goog
>> > > > >
>> > > >
>> > > > Any comments/objections on merging this?
>> > >
>> > >
>> > > Can this patch support tiled hevc coded or sequence heif？=
>> > >
>> >
>> > I believe that will be possible only after AVStreamGroup is implemented.
>> >
>>
>> Yes, this patch only supports still HEIC images that don't have alpha
>> and grids (tiles).
>>
>> Tiles and Alpha support will be possible only after AVStreamGroup is
>> implemented. I will look into HEIC sequences in a follow-up.
>>
>> > Vignesh is there a sample available? Could we add a test?
>>
>> I tested it from the files in
>> https://github.com/nokiatech/heif/tree/gh-pages/content/images. I am
>> not sure about HEVC licensing and if we are allowed to copy some of
>> those files in the ffmpeg fate server. Would generating a random image
>> with ffmpeg and encoding it as HEIC be good enough?
>
>
> I would prefer a real world example and FATE has a bunch of conformance samples already.
> Adding the ones from https://github.com/nokiatech/heif_conformance shouldn't be a problem.
> Ideally the sample test should be added to this same patch.

Great, i have added two samples. Can you please upload C002.heic and
C003.heic from the heif_conformance repository to the fate server
under the "heif-conformance" sub-directory. I have also attached those
two files in this email for reference. I will update the patch with
the fate tests.

> --
> Vittorio

-- 
Vignesh

[-- Attachment #2: C002.heic --]
[-- Type: image/heif, Size: 111897 bytes --]

[-- Attachment #3: C003.heic --]
[-- Type: image/heif, Size: 224452 bytes --]

[-- Attachment #4: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".