Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Vignesh Venkatasubramanian <vigneshv-at-google.com@ffmpeg.org>
To: FFmpeg development discussions and patches
	<ffmpeg-devel@ffmpeg.org>,
	 Vignesh Venkatasubramanian <vigneshv@google.com>
Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/mov: Support parsing of still AVIF Alpha Channel
Date: Sat, 2 Jul 2022 09:32:01 -0700
Message-ID: <CAOJaEPJ9mdVdDv+aAzBBK6ZaFYdkeSNFhLUeRn4X7SNmHDf=zg@mail.gmail.com> (raw)
In-Reply-To: <165675449715.31466.4432489889968017112@lain.khirnov.net>

On Sat, Jul 2, 2022 at 2:35 AM Anton Khirnov <anton@khirnov.net> wrote:
>
> Quoting Vignesh Venkatasubramanian (2022-06-30 23:04:34)
> > Parse the alpha channel for still AVIF images and expose it as a
> > separate track. This is the simplest way of supporting AVIF alpha
> > channel in a codec independent manner (similar to how ffmpeg
> > supports animated AVIF with alpha channel).
> >
> > One can use the alphamerge filter to get a transparent image with
> > a single command. For example:
> >
> > ffmpeg -i image_with_alpha.avif -filter_complex alphamerge image_with_alpha.png
> >
> > Signed-off-by: Vignesh Venkatasubramanian <vigneshv@google.com>
> > ---
> >  libavformat/isom.h |  1 +
> >  libavformat/mov.c  | 66 ++++++++++++++++++++++++++++++++++++++++++++++
> >  2 files changed, 67 insertions(+)
>
> I am against this patch, this is a digusting hack.
>
> These are not two streams, it is a single stream and should be exposed
> as such.
>

Yes, while it is a hack, it is also the simplest way of supporting
AVIF images with alpha. Since AVIF alpha images require two separate
decoders, i could not think of any other solution that does not
involve modifying the underlying av1 codec itself.

If there are any alternative solutions where we can expose a single
stream that needs two codecs, then i am open to implementing that.

Otherwise, this solution improves the current situation where there is
no way for the user to extract the alpha channel (albeit in a hacky
way).

> --
> Anton Khirnov



-- 
Vignesh
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2022-07-02 16:32 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-30 21:04 [FFmpeg-devel] [PATCH 1/2] avformat/mov: Rework the AVIF parser to handle multiple items Vignesh Venkatasubramanian
2022-06-30 21:04 ` [FFmpeg-devel] [PATCH 2/2] avformat/mov: Support parsing of still AVIF Alpha Channel Vignesh Venkatasubramanian
2022-07-02  9:34   ` Anton Khirnov
2022-07-02 16:32     ` Vignesh Venkatasubramanian [this message]
2022-07-02 19:34       ` Jan Ekström
2022-07-02 21:15         ` Vignesh Venkatasubramanian
2022-07-03 12:17           ` Jan Ekström
2022-07-03 16:52             ` Vignesh Venkatasubramanian
2022-07-05 16:53           ` Anton Khirnov
2022-07-12 15:17             ` Vignesh Venkatasubramanian
2022-07-11 22:25 ` [FFmpeg-devel] [PATCH 1/2] avformat/mov: Rework the AVIF parser to handle multiple items James Zern
2022-07-13 16:11   ` Vignesh Venkatasubramanian
2022-07-13 16:12   ` Vignesh Venkatasubramanian
2022-07-22 18:20     ` Vignesh Venkatasubramanian
2022-07-26 19:02       ` James Zern
2022-07-27 16:12         ` Vignesh Venkatasubramanian
2022-07-27 19:37           ` James Zern
2022-07-27 19:40           ` Andreas Rheinhardt
2022-07-28 18:25             ` Vignesh Venkatasubramanian
2022-07-28 18:25             ` Vignesh Venkatasubramanian
2022-08-02 16:54               ` James Zern
2022-08-09 20:20                 ` James Zern
2022-07-27 16:12         ` Vignesh Venkatasubramanian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOJaEPJ9mdVdDv+aAzBBK6ZaFYdkeSNFhLUeRn4X7SNmHDf=zg@mail.gmail.com' \
    --to=vigneshv-at-google.com@ffmpeg.org \
    --cc=ffmpeg-devel@ffmpeg.org \
    --cc=vigneshv@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git