* [FFmpeg-devel] [PATCH] avformat/movenc: Write auxi box for animated AVIF with alpha
@ 2022-09-19 23:03 Vignesh Venkatasubramanian
2022-09-20 19:38 ` James Zern
0 siblings, 1 reply; 6+ messages in thread
From: Vignesh Venkatasubramanian @ 2022-09-19 23:03 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Vignesh Venkatasubramanian
According to the HEIF specification Section 7.5.3.1, tracks with
handler_type 'auxv' must contain a 'auxi' box in its
SampleEntry to notify the nature of the auxiliary track to the
decoder.
The content is the same as the 'auxC' box. So paramterize and re-use
the existing function.
Signed-off-by: Vignesh Venkatasubramanian <vigneshv@google.com>
---
libavformat/movenc.c | 27 +++++++++++++++------------
1 file changed, 15 insertions(+), 12 deletions(-)
diff --git a/libavformat/movenc.c b/libavformat/movenc.c
index c8b2e141cb..754f95912a 100644
--- a/libavformat/movenc.c
+++ b/libavformat/movenc.c
@@ -2179,6 +2179,16 @@ static int mov_write_ccst_tag(AVIOContext *pb)
return update_size(pb, pos);
}
+static int mov_write_aux_tag(AVIOContext *pb, const char *aux_type)
+{
+ int64_t pos = avio_tell(pb);
+ avio_wb32(pb, 0); /* size */
+ ffio_wfourcc(pb, aux_type);
+ avio_wb32(pb, 0); /* Version & flags */
+ avio_write(pb, "urn:mpeg:mpegB:cicp:systems:auxiliary:alpha\0", 44);
+ return update_size(pb, pos);
+}
+
static int mov_write_video_tag(AVFormatContext *s, AVIOContext *pb, MOVMuxContext *mov, MOVTrack *track)
{
int ret = AVERROR_BUG;
@@ -2363,8 +2373,11 @@ static int mov_write_video_tag(AVFormatContext *s, AVIOContext *pb, MOVMuxContex
if (avid)
avio_wb32(pb, 0);
- if (track->mode == MODE_AVIF)
+ if (track->mode == MODE_AVIF) {
mov_write_ccst_tag(pb);
+ if (s->nb_streams > 0 && track == &mov->tracks[1])
+ mov_write_aux_tag(pb, "auxi");
+ }
return update_size(pb, pos);
}
@@ -3044,16 +3057,6 @@ static int mov_write_pixi_tag(AVIOContext *pb, MOVMuxContext *mov, AVFormatConte
return update_size(pb, pos);
}
-static int mov_write_auxC_tag(AVIOContext *pb)
-{
- int64_t pos = avio_tell(pb);
- avio_wb32(pb, 0); /* size */
- ffio_wfourcc(pb, "auxC");
- avio_wb32(pb, 0); /* Version & flags */
- avio_write(pb, "urn:mpeg:mpegB:cicp:systems:auxiliary:alpha\0", 44);
- return update_size(pb, pos);
-}
-
static int mov_write_ipco_tag(AVIOContext *pb, MOVMuxContext *mov, AVFormatContext *s)
{
int64_t pos = avio_tell(pb);
@@ -3066,7 +3069,7 @@ static int mov_write_ipco_tag(AVIOContext *pb, MOVMuxContext *mov, AVFormatConte
if (!i)
mov_write_colr_tag(pb, &mov->tracks[0], 0);
else
- mov_write_auxC_tag(pb);
+ mov_write_aux_tag(pb, "auxC");
}
return update_size(pb, pos);
}
--
2.37.3.968.ga6b4b080e4-goog
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [FFmpeg-devel] [PATCH] avformat/movenc: Write auxi box for animated AVIF with alpha
2022-09-19 23:03 [FFmpeg-devel] [PATCH] avformat/movenc: Write auxi box for animated AVIF with alpha Vignesh Venkatasubramanian
@ 2022-09-20 19:38 ` James Zern
2022-09-20 21:17 ` Vignesh Venkatasubramanian
2022-09-20 21:17 ` Vignesh Venkatasubramanian
0 siblings, 2 replies; 6+ messages in thread
From: James Zern @ 2022-09-20 19:38 UTC (permalink / raw)
To: FFmpeg development discussions and patches; +Cc: Vignesh Venkatasubramanian
On Mon, Sep 19, 2022 at 4:03 PM Vignesh Venkatasubramanian
<vigneshv-at-google.com@ffmpeg.org> wrote:
>
> According to the HEIF specification Section 7.5.3.1, tracks with
It might be worth adding ISO/IEC 23008-12 for added precision.
> handler_type 'auxv' must contain a 'auxi' box in its
> SampleEntry to notify the nature of the auxiliary track to the
> decoder.
>
> The content is the same as the 'auxC' box. So paramterize and re-use
parameterize
> the existing function.
>
> Signed-off-by: Vignesh Venkatasubramanian <vigneshv@google.com>
> ---
> libavformat/movenc.c | 27 +++++++++++++++------------
> 1 file changed, 15 insertions(+), 12 deletions(-)
>
lgtm.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 6+ messages in thread
* [FFmpeg-devel] [PATCH] avformat/movenc: Write auxi box for animated AVIF with alpha
2022-09-20 19:38 ` James Zern
@ 2022-09-20 21:17 ` Vignesh Venkatasubramanian
2022-09-21 19:14 ` James Zern
2022-09-20 21:17 ` Vignesh Venkatasubramanian
1 sibling, 1 reply; 6+ messages in thread
From: Vignesh Venkatasubramanian @ 2022-09-20 21:17 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Vignesh Venkatasubramanian
According to the HEIF specification (ISO/IEC 23008-12) Section
7.5.3.1, tracks with handler_type 'auxv' must contain a 'auxi' box
in its SampleEntry to notify the nature of the auxiliary track to the
decoder.
The content is the same as the 'auxC' box. So parameterize and re-use
the existing function.
Signed-off-by: Vignesh Venkatasubramanian <vigneshv@google.com>
---
libavformat/movenc.c | 27 +++++++++++++++------------
1 file changed, 15 insertions(+), 12 deletions(-)
diff --git a/libavformat/movenc.c b/libavformat/movenc.c
index c8b2e141cb..754f95912a 100644
--- a/libavformat/movenc.c
+++ b/libavformat/movenc.c
@@ -2179,6 +2179,16 @@ static int mov_write_ccst_tag(AVIOContext *pb)
return update_size(pb, pos);
}
+static int mov_write_aux_tag(AVIOContext *pb, const char *aux_type)
+{
+ int64_t pos = avio_tell(pb);
+ avio_wb32(pb, 0); /* size */
+ ffio_wfourcc(pb, aux_type);
+ avio_wb32(pb, 0); /* Version & flags */
+ avio_write(pb, "urn:mpeg:mpegB:cicp:systems:auxiliary:alpha\0", 44);
+ return update_size(pb, pos);
+}
+
static int mov_write_video_tag(AVFormatContext *s, AVIOContext *pb, MOVMuxContext *mov, MOVTrack *track)
{
int ret = AVERROR_BUG;
@@ -2363,8 +2373,11 @@ static int mov_write_video_tag(AVFormatContext *s, AVIOContext *pb, MOVMuxContex
if (avid)
avio_wb32(pb, 0);
- if (track->mode == MODE_AVIF)
+ if (track->mode == MODE_AVIF) {
mov_write_ccst_tag(pb);
+ if (s->nb_streams > 0 && track == &mov->tracks[1])
+ mov_write_aux_tag(pb, "auxi");
+ }
return update_size(pb, pos);
}
@@ -3044,16 +3057,6 @@ static int mov_write_pixi_tag(AVIOContext *pb, MOVMuxContext *mov, AVFormatConte
return update_size(pb, pos);
}
-static int mov_write_auxC_tag(AVIOContext *pb)
-{
- int64_t pos = avio_tell(pb);
- avio_wb32(pb, 0); /* size */
- ffio_wfourcc(pb, "auxC");
- avio_wb32(pb, 0); /* Version & flags */
- avio_write(pb, "urn:mpeg:mpegB:cicp:systems:auxiliary:alpha\0", 44);
- return update_size(pb, pos);
-}
-
static int mov_write_ipco_tag(AVIOContext *pb, MOVMuxContext *mov, AVFormatContext *s)
{
int64_t pos = avio_tell(pb);
@@ -3066,7 +3069,7 @@ static int mov_write_ipco_tag(AVIOContext *pb, MOVMuxContext *mov, AVFormatConte
if (!i)
mov_write_colr_tag(pb, &mov->tracks[0], 0);
else
- mov_write_auxC_tag(pb);
+ mov_write_aux_tag(pb, "auxC");
}
return update_size(pb, pos);
}
--
2.37.3.968.ga6b4b080e4-goog
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [FFmpeg-devel] [PATCH] avformat/movenc: Write auxi box for animated AVIF with alpha
2022-09-20 21:17 ` Vignesh Venkatasubramanian
@ 2022-09-21 19:14 ` James Zern
2022-09-22 21:12 ` James Zern
0 siblings, 1 reply; 6+ messages in thread
From: James Zern @ 2022-09-21 19:14 UTC (permalink / raw)
To: FFmpeg development discussions and patches
On Tue, Sep 20, 2022 at 2:17 PM Vignesh Venkatasubramanian
<vigneshv-at-google.com@ffmpeg.org> wrote:
>
> According to the HEIF specification (ISO/IEC 23008-12) Section
> 7.5.3.1, tracks with handler_type 'auxv' must contain a 'auxi' box
> in its SampleEntry to notify the nature of the auxiliary track to the
> decoder.
>
> The content is the same as the 'auxC' box. So parameterize and re-use
> the existing function.
>
> Signed-off-by: Vignesh Venkatasubramanian <vigneshv@google.com>
> ---
> libavformat/movenc.c | 27 +++++++++++++++------------
> 1 file changed, 15 insertions(+), 12 deletions(-)
>
lgtm.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avformat/movenc: Write auxi box for animated AVIF with alpha
2022-09-21 19:14 ` James Zern
@ 2022-09-22 21:12 ` James Zern
0 siblings, 0 replies; 6+ messages in thread
From: James Zern @ 2022-09-22 21:12 UTC (permalink / raw)
To: FFmpeg development discussions and patches
On Wed, Sep 21, 2022 at 12:14 PM James Zern <jzern@google.com> wrote:
>
> On Tue, Sep 20, 2022 at 2:17 PM Vignesh Venkatasubramanian
> <vigneshv-at-google.com@ffmpeg.org> wrote:
> >
> > According to the HEIF specification (ISO/IEC 23008-12) Section
> > 7.5.3.1, tracks with handler_type 'auxv' must contain a 'auxi' box
> > in its SampleEntry to notify the nature of the auxiliary track to the
> > decoder.
> >
> > The content is the same as the 'auxC' box. So parameterize and re-use
> > the existing function.
> >
> > Signed-off-by: Vignesh Venkatasubramanian <vigneshv@google.com>
> > ---
> > libavformat/movenc.c | 27 +++++++++++++++------------
> > 1 file changed, 15 insertions(+), 12 deletions(-)
> >
>
> lgtm.
applied.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avformat/movenc: Write auxi box for animated AVIF with alpha
2022-09-20 19:38 ` James Zern
2022-09-20 21:17 ` Vignesh Venkatasubramanian
@ 2022-09-20 21:17 ` Vignesh Venkatasubramanian
1 sibling, 0 replies; 6+ messages in thread
From: Vignesh Venkatasubramanian @ 2022-09-20 21:17 UTC (permalink / raw)
To: James Zern; +Cc: FFmpeg development discussions and patches
On Tue, Sep 20, 2022 at 12:38 PM James Zern <jzern@google.com> wrote:
>
> On Mon, Sep 19, 2022 at 4:03 PM Vignesh Venkatasubramanian
> <vigneshv-at-google.com@ffmpeg.org> wrote:
> >
> > According to the HEIF specification Section 7.5.3.1, tracks with
>
> It might be worth adding ISO/IEC 23008-12 for added precision.
>
Done.
> > handler_type 'auxv' must contain a 'auxi' box in its
> > SampleEntry to notify the nature of the auxiliary track to the
> > decoder.
> >
> > The content is the same as the 'auxC' box. So paramterize and re-use
>
> parameterize
>
oops, fixed.
> > the existing function.
> >
> > Signed-off-by: Vignesh Venkatasubramanian <vigneshv@google.com>
> > ---
> > libavformat/movenc.c | 27 +++++++++++++++------------
> > 1 file changed, 15 insertions(+), 12 deletions(-)
> >
>
> lgtm.
--
Vignesh
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-09-22 21:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-19 23:03 [FFmpeg-devel] [PATCH] avformat/movenc: Write auxi box for animated AVIF with alpha Vignesh Venkatasubramanian
2022-09-20 19:38 ` James Zern
2022-09-20 21:17 ` Vignesh Venkatasubramanian
2022-09-21 19:14 ` James Zern
2022-09-22 21:12 ` James Zern
2022-09-20 21:17 ` Vignesh Venkatasubramanian
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git