From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CE7A543748 for ; Wed, 27 Jul 2022 16:12:42 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C8E0E68B8CC; Wed, 27 Jul 2022 19:12:41 +0300 (EEST) Received: from mail-yw1-f174.google.com (mail-yw1-f174.google.com [209.85.128.174]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7EAA668B872 for ; Wed, 27 Jul 2022 19:12:35 +0300 (EEST) Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-31f41584236so72392797b3.5 for ; Wed, 27 Jul 2022 09:12:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc; bh=TcEnyYKtLvB98+FlNgM3vlZuo3u7qoaltAL1s12GjoU=; b=sfBMinj8ufq9oevAkw5+eCg18AhJ2FBogDU5Hf4ko42flPFl1MNlQbMZbCTJKzgxtd CqMqdWkbW3Ja5kQZ1ZmgWxy4mjdi6w2lZPsZmx834f60y8tuaqvepsPQEjPnPi1Mk85X /2KMLSFZDPNRamll5N89rIBQvQoeL5NtzYOqVjoODN8Wtw753WsfYLYIUCwzvJwF00Nu sQvu2Suwncm0gltUSl2lHBfTmtk2dLsSr/BRwvbreojfzUOI3hT1cbKwF3EA3UneS8+a 1uGeaLsh1nwnwrvhGkKnoXmZZIPU9+/9ZtWQoLDInl9lXdvVAPELfqvr0nyxWpnELir4 3sDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc; bh=TcEnyYKtLvB98+FlNgM3vlZuo3u7qoaltAL1s12GjoU=; b=eEkQMMP+f2eeR/hJb38Bxkz7vCSQ9khec81593uAhgNdUCVzbiZHX0+iob31v/hda7 QEA6kxkdNF/29Pojb4egg7X+cwZrqtOeYJhDKJC0eobVc8u5fdx8QkEv0oDrbVo5Ly+4 gzgFwS7KtPjWMw6m+dWrUGeT08NOerspzAQK7zwHq18gG/nMWUWv09D4rW7znvjToUJs N0BCx8Qaeh1ubJ18VugLQh8Y+uhPcNI90P6h6CA4UBEWYkvSuqg+sy56uxSV+wMTlJMM Dwg8xUGJLJRb3e++GcBVlEDYvozgaw+WAnFLiHqQ2vm9SKgSNa848yr/nfOKjAGNvkAv Im2w== X-Gm-Message-State: AJIora8fZO/kJxCiLgtlXRz950n1onfgl4O51w9hyipPRhA+XjEFG2Ex Dy8xCrEhHcJ+ZtIy4C/er6R0iyp7hMI+1zN36eTmDpiVrxkOBA== X-Google-Smtp-Source: AGRyM1s3ZTAJaombsJrC3ZJx3fTpZHqqIowoCwrXxXo3GZFd242gQCnMEYyNzwn0Tps58oFNvhr6dWYRfbvGkjigqdM= X-Received: by 2002:a81:4a89:0:b0:31c:cd9a:c875 with SMTP id x131-20020a814a89000000b0031ccd9ac875mr20134940ywa.411.1658938353615; Wed, 27 Jul 2022 09:12:33 -0700 (PDT) MIME-Version: 1.0 References: <20220630210434.1551769-1-vigneshv@google.com> In-Reply-To: From: Vignesh Venkatasubramanian Date: Wed, 27 Jul 2022 09:12:22 -0700 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: Rework the AVIF parser to handle multiple items X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, Jul 26, 2022 at 12:02 PM James Zern wrote: > > On Fri, Jul 22, 2022 at 11:21 AM Vignesh Venkatasubramanian > wrote: > > > > On Wed, Jul 13, 2022 at 9:12 AM Vignesh Venkatasubramanian > > wrote: > > > > > > On Mon, Jul 11, 2022 at 3:25 PM James Zern > > > wrote: > > > > > > > > On Thu, Jun 30, 2022 at 2:04 PM Vignesh Venkatasubramanian > > > > wrote: > > > > > > > > > > Stores the item ids of all the items found in the file and > > > > > processes the primary item at the end of the meta box. This patch > > > > > does not change any behavior. It sets up the code for parsing > > > > > alpha channel (and possibly images with 'grid') in follow up > > > > > patches. > > > > > > > > > > Signed-off-by: Vignesh Venkatasubramanian > > > > > --- > > > > > libavformat/isom.h | 4 ++ > > > > > libavformat/mov.c | 148 ++++++++++++++++++++++++++++----------------- > > > > > 2 files changed, 97 insertions(+), 55 deletions(-) > > > > > > > > > > [...] > > > > > > > > @@ -4692,9 +4755,25 @@ static int mov_read_meta(MOVContext *c, > > > > AVIOContext *pb, MOVAtom atom) > > > > tag = avio_rl32(pb); > > > > atom.size -= 4; > > > > if (tag == MKTAG('h','d','l','r')) { > > > > + int ret; > > > > avio_seek(pb, -8, SEEK_CUR); > > > > atom.size += 8; > > > > - return mov_read_default(c, pb, atom); > > > > + ret = mov_read_default(c, pb, atom); > > > > + if (ret < 0) > > > > > > > > In some other cases these two lines are combined, if ((ret = ... > > > > > > > > > > Done. > > > > > > > + return ret; > > > > + if (c->is_still_picture_avif) { > > > > + int ret; > > > > + // Add a stream for the YUV planes (primary item). > > > > + ret = avif_add_stream(c, c->primary_item_id); > > > > + if (ret) > > > > > > > > This could be updated too and use '< 0' to match other code. > > > > > > > > > > Done. > > > > > > > + return ret; > > > > + // For still AVIF images, the meta box contains all the > > > > + // necessary information that would generally be > > > > provided by the > > > > + // moov box. So simply mark that we have found the moov box so > > > > + // that parsing can continue. > > > > + c->found_moov = 1; > > > > + } > > > > + return ret; > > > > } > > > > _______________________________________________ > > > > ffmpeg-devel mailing list > > > > ffmpeg-devel@ffmpeg.org > > > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > > > > > To unsubscribe, visit link above, or email > > > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > > > > > > > > > > > > -- > > > Vignesh > > > > Any further comments on this one? > > > > Please note that i have abandoned the second patch in this list. But > > this one is still up for merging. > > > > This looks like it needs to be rebased. I'll take a look after that. Done. > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". -- Vignesh _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".