From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1A41141049 for ; Mon, 13 Jun 2022 16:32:34 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2C01568B5F8; Mon, 13 Jun 2022 19:32:33 +0300 (EEST) Received: from mail-yw1-f181.google.com (mail-yw1-f181.google.com [209.85.128.181]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 31A1F68B596 for ; Mon, 13 Jun 2022 19:32:26 +0300 (EEST) Received: by mail-yw1-f181.google.com with SMTP id 00721157ae682-30ec2aa3b6cso3492987b3.11 for ; Mon, 13 Jun 2022 09:32:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=UVyVePqMIXFtWh8UQmzzDU3pFf80rhJWD6mWk4ymWsY=; b=Hny1H4fYNgQGrhQtr7GGga/dXl7m7bUm3HE3Oa+zR4x6YVUDN3He+NccyX+CbY+MJ1 KDqKQz6McWdsy6ued/n6SYHnjxo9WKrhHN9cHxYX/6mir7MpIsW+T4Kf+amyZ2o8zNtV tJYgK6+g0AqS8MUEhrVOWuBVCZUPsxIKkFIR8xI8G+qIfuwsGAKfvLSw1+1psW0w4b5I 0v8+bhwCks8KQGtGAjg76EgMUEvIHKaT3aHdBDx96VNz0SLjNAKZUuv+bmh/6mh7l4Gl 4w1YTf1K6ZOr9dSgZ9SbFQCvl0/xZaRAzgoe29ONG9in3lOGsUQijPHkOVf16oab9ESt Eggw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=UVyVePqMIXFtWh8UQmzzDU3pFf80rhJWD6mWk4ymWsY=; b=F7wv2pSz33NMcoD2AGEyZBRk53TNdx7nQ4KSRGbHdhJtwM0sxleoJs1J5msHkrBc8+ 1icACJoOhoegW8ighoEBFxSb44SKb18ob2j4pksA432J5Wb4GEledlZFF3FPvlV9tXgn YFm5Zf9dFkJR+lbCawf5hV2lTOqLgVee7EQXGEE0TS71J2lVjJY9NxpIvaRTfxhAgtfL scgR9MSQCf94usXUWVYQozppLz71Eg/D+/kTTT8nRDvHoKWSVMx6jgIbby0ExM6OuEzt kKYXbKWMlRtjf2rmctUI44y7C6S0f/bJG3SDspUN/hmQW6APMnzz7csTE4cBUtuSwK8k XNqA== X-Gm-Message-State: AJIora85Qcx3M1TA/vQgVr6KTpy2RFAj5GO7DhgwyJKjsX3OjQOCtrSt C1uYC8Ns+MNeKGVUiaVUEk3BrB1LCsmXoHcDf8/ko1MDihU= X-Google-Smtp-Source: AGRyM1vXpe0zl/8mWnqCL/MirGFHGtAZ8qA4boEiAuf+vl9eNOAi+9Py7h1YZDs144VCqWfFWAezwqUj5aAGPQr54xw= X-Received: by 2002:a81:918a:0:b0:30c:2e05:155b with SMTP id i132-20020a81918a000000b0030c2e05155bmr663561ywg.150.1655137944113; Mon, 13 Jun 2022 09:32:24 -0700 (PDT) MIME-Version: 1.0 References: <20220424183514.986374-1-vigneshv@google.com> <085f0277-e678-4d20-f2bf-fbf55ed959d8@gyani.pro> In-Reply-To: From: Vignesh Venkatasubramanian Date: Mon, 13 Jun 2022 09:32:12 -0700 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avformat/mov: Only read the primary item for AVIF X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, Jun 10, 2022 at 10:34 AM Vignesh Venkatasubramanian wrote: > > On Thu, Jun 9, 2022 at 12:50 AM Gyan Doshi wrote: > > > > > > > > On 2022-06-08 10:51 pm, Vignesh Venkatasubramanian wrote: > > > On Thu, Jun 2, 2022 at 1:35 PM James Zern wrote: > > >> On Wed, Jun 1, 2022 at 1:38 PM Vignesh Venkatasubramanian > > >> wrote: > > >>> On Wed, Jun 1, 2022 at 10:30 AM James Zern wrote: > > >>>> On Sun, Apr 24, 2022 at 11:35 AM Vignesh Venkatasubramanian > > >>>> wrote: > > >>>>> Update the still AVIF parser to only read the primary item. With this > > >>>>> patch, AVIF still images with exif/icc/alpha channel will no longer > > >>>>> fail to parse. > > >>>>> > > >>>>> For example, this patch enables parsing of files in: > > >>>>> https://github.com/AOMediaCodec/av1-avif/tree/master/testFiles/Microsoft > > >>>>> > > >>>> Can some of the failing files or similar ones be added to fate? > > >>> There are no fate tests for AVIF parsing as of now. I was thinking > > >>> about adding some for the muxing. But i am not sure what can be done > > >>> here for the parsing. > > >>> > > >> Thanks. Are there any for general mov/mp4 parsing that could be > > >> extended? This looks good otherwise. > > > From what i see, most of the mov tests only seem to be for muxing. I'm > > > not entirely certain about how to add a test for AVIF parsing. If > > > anybody has an idea, i'd be open to adding it. > > > > Basic test would use the framemd5 muxer to compare demuxed packets with > > a reference. > > See fate-ffmpeg-streamloop > > > > Thank you i have added a couple of fate tests. > > I am not sure how to add the AVIF files to the fate test server. I > have them on Google Drive here: > > https://drive.google.com/file/d/1diZoM0Ew7Co3Yh5w5y1J-3IiBYVmUv9J/view?usp=sharing > https://drive.google.com/file/d/1DdrD1mW36evt40a4RkeLYpx-oojmbc3z/view?usp=sharing > > These links should be publicly available without any sign in required. > Please let me know if there is another preferred way of sharing test > files and i can share it that way. > Also, i forgot to mention that these files have to be uploaded under a new directory called "avif" in the fate server. > Also for the record, these files were created by remuxing an existing > file in the fate suite. > > still_image.avif - contains the first frame from > av1-test-vectors/av1-1-b8-02-allintra.ivf > still_image_exif.avif - contains the first frame from > av1-test-vectors/av1-1-b8-02-allintra.ivf with dummy exif data. > > > Regards, > > Gyan > > _______________________________________________ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > To unsubscribe, visit link above, or email > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > > > > -- > Vignesh -- Vignesh _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".