Re: [FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

[Vignesh Venkatasubramanian <vigneshv-at-google.com@ffmpeg.org>]

On Wed, May 4, 2022 at 10:10 AM "zhilizhao(赵志立)" <quinkblack@foxmail.com> wrote:
>
>
>
> > On May 5, 2022, at 12:45 AM, Vignesh Venkatasubramanian <vigneshv-at-google.com@ffmpeg.org> wrote:
> >
> >>>
> >>> -    mov_write_track_udta_tag(pb, mov, st);
> >>> +    if (track->mode != MODE_AVIF)
> >>> +        mov_write_track_udta_tag(pb, mov, st);
> >>
> >> Please check if the check can be removed. mov_write_track_udta_tag() does nothing
> >> for mode other than MOV/MP4.
> >>
> >
> > mov_write_track_udta_tag() writes itunes meta and loci tags when mode
> > is not MOV/MP4. So this check is necessary.
> >
>
> I think you are referring to ‘mov_write_udta_tag', not
> ‘mov_write_track_udta_tag', no?

Ah yes you are right. mov_write_track_udta_tag doesn't do anything for
non-MOV/MP4. I have removed the check.

> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".



-- 
Vignesh
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".