From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B4000429E7 for ; Fri, 10 Jun 2022 17:34:45 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6E5A568B380; Fri, 10 Jun 2022 20:34:43 +0300 (EEST) Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com [209.85.128.175]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 04B1868A966 for ; Fri, 10 Jun 2022 20:34:37 +0300 (EEST) Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-31332df12a6so131276197b3.4 for ; Fri, 10 Jun 2022 10:34:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=C2/Zp1ogdgPrPx4a5y9jSNFYG9zl60kpXCUd1SqwTGw=; b=BfIUrLCBs+9dw/Ojiffj+IlBz5piWBvwzIqqJ46uhh72+rmW7p11DEY4yVJr7Jng00 ipW02JRlx89UNY3K/GSKTvu4b10O9JJNzvSyiPz8uZWI9LuvtuviU9WCvCEpPP8zRUOc s2a5omJHehKP/anfKGA0Y/GZVUzsWx71F+Hpi9+4sz9JLTkD3biCDgpXxSYWF1JWGjAY MTCVS7blYFeAXLCvDHbEULTylN/G8z/OUDFb+Q/gz1A5ZA5E6VDQWWh5ykmJyigN79oW oCnVM0JWzbxm+fasZxEEDtbYbW8vdqtDsG41jZM2jTif0f5mBHkDLMQWvRfskfDl3pHf H6/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=C2/Zp1ogdgPrPx4a5y9jSNFYG9zl60kpXCUd1SqwTGw=; b=45MNSoNpN5/NkLj34jMECuVTHoTZ+O0aQEgE7CSze/KFHONqDXsy9yKggVg8K7imv+ ioiHwjZqmlE+efKhJcCp14YZ6/Wfh4vxCr7ZSA6S582q+u2H3tgEq4aDIqLN/CwzZzA6 42UBNbMfDW8RE7ROHqEPj8YQ+n3A29bBgkQCLzULJRXymwHW0gN67vtZxyfOke47fY2k ZB9gsV1NRERQ9zww7pLvDnS8fLITWvxu3vC/awEFYVuIHTuMgYSF5IaRSYm6TniPZvks K5HGN05SNM764tP+j7Q6LIDicLTSCxgUWGFd2K6sZkuVdlitqJKMCN10ldIpiV/omnSa 4gsA== X-Gm-Message-State: AOAM531Q7R8lhUlIclJh6vdcYXu/MbQNRjVr3MsJj+sjAz/6Nd6zXWZ0 cVaEXMyolj9MYZqdxRGh2ovuX3CBjQXqH6zPuvr1sbPEaEuwmQ== X-Google-Smtp-Source: ABdhPJy8YzSz7lOHFPbcisosVFzAH93yQL0f6v7o4uDYPN49OogHbYqNZlzGgufStwa3OSU7LRkYCbNUb1J7fQnxDgg= X-Received: by 2002:a81:918c:0:b0:310:61f:40d1 with SMTP id i134-20020a81918c000000b00310061f40d1mr44219766ywg.89.1654882475323; Fri, 10 Jun 2022 10:34:35 -0700 (PDT) MIME-Version: 1.0 References: <20220424183514.986374-1-vigneshv@google.com> <085f0277-e678-4d20-f2bf-fbf55ed959d8@gyani.pro> In-Reply-To: <085f0277-e678-4d20-f2bf-fbf55ed959d8@gyani.pro> From: Vignesh Venkatasubramanian Date: Fri, 10 Jun 2022 10:34:24 -0700 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avformat/mov: Only read the primary item for AVIF X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, Jun 9, 2022 at 12:50 AM Gyan Doshi wrote: > > > > On 2022-06-08 10:51 pm, Vignesh Venkatasubramanian wrote: > > On Thu, Jun 2, 2022 at 1:35 PM James Zern wrote: > >> On Wed, Jun 1, 2022 at 1:38 PM Vignesh Venkatasubramanian > >> wrote: > >>> On Wed, Jun 1, 2022 at 10:30 AM James Zern wrote: > >>>> On Sun, Apr 24, 2022 at 11:35 AM Vignesh Venkatasubramanian > >>>> wrote: > >>>>> Update the still AVIF parser to only read the primary item. With this > >>>>> patch, AVIF still images with exif/icc/alpha channel will no longer > >>>>> fail to parse. > >>>>> > >>>>> For example, this patch enables parsing of files in: > >>>>> https://github.com/AOMediaCodec/av1-avif/tree/master/testFiles/Microsoft > >>>>> > >>>> Can some of the failing files or similar ones be added to fate? > >>> There are no fate tests for AVIF parsing as of now. I was thinking > >>> about adding some for the muxing. But i am not sure what can be done > >>> here for the parsing. > >>> > >> Thanks. Are there any for general mov/mp4 parsing that could be > >> extended? This looks good otherwise. > > From what i see, most of the mov tests only seem to be for muxing. I'm > > not entirely certain about how to add a test for AVIF parsing. If > > anybody has an idea, i'd be open to adding it. > > Basic test would use the framemd5 muxer to compare demuxed packets with > a reference. > See fate-ffmpeg-streamloop > Thank you i have added a couple of fate tests. I am not sure how to add the AVIF files to the fate test server. I have them on Google Drive here: https://drive.google.com/file/d/1diZoM0Ew7Co3Yh5w5y1J-3IiBYVmUv9J/view?usp=sharing https://drive.google.com/file/d/1DdrD1mW36evt40a4RkeLYpx-oojmbc3z/view?usp=sharing These links should be publicly available without any sign in required. Please let me know if there is another preferred way of sharing test files and i can share it that way. Also for the record, these files were created by remuxing an existing file in the fate suite. still_image.avif - contains the first frame from av1-test-vectors/av1-1-b8-02-allintra.ivf still_image_exif.avif - contains the first frame from av1-test-vectors/av1-1-b8-02-allintra.ivf with dummy exif data. > Regards, > Gyan > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". -- Vignesh _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".