From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CC5CC4513F for ; Fri, 11 Aug 2023 16:01:55 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 88CA368C8D9; Fri, 11 Aug 2023 19:01:52 +0300 (EEST) Received: from mail-oi1-f179.google.com (mail-oi1-f179.google.com [209.85.167.179]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id EE95068C6A3 for ; Fri, 11 Aug 2023 19:01:45 +0300 (EEST) Received: by mail-oi1-f179.google.com with SMTP id 5614622812f47-3a7aedc57ffso1785042b6e.2 for ; Fri, 11 Aug 2023 09:01:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691769703; x=1692374503; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=Puao3juNaoIJZaVOdlxr/asMqoJAoNcxg77bZNTTDDc=; b=ETobNgY7DlubEr/YsTy9LPVIlM3KIfjtUq+0Z2dbSaNJmzoPv2JaLYDSIkvKng3w8u djbt37OFRdsz47O7mUA5hBTWxcbF3qvCyhk3SqCopdMxzH6WhAt9yL65hjetV98foevD XUVpsiFVElIBDwFd0sAQ0xNdbxp7+4bHmt2tfaVLj3jhxYNFRwlAXVx79sh6ezGeM5H2 VNaduCsdiNY5l7HLSHMBj/bOK+btSgbhuGk4UOecDEH+7VBiwLf3pEg0Ru0wAdzvJh4Z rRY9A5017kPI1ytLgJkZpRycGMMYsLEmSEaa7c1rj02I3s0Gia7A/ZoC61Tn9/FvIvga TSNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691769703; x=1692374503; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Puao3juNaoIJZaVOdlxr/asMqoJAoNcxg77bZNTTDDc=; b=ZheoPnkHwZB3rPbrp6R/0s8L5z3pA0e1P9SdLCUyVF+1c7XoXTeONxX7dXXksmkRQg L7VArFYQPYHNzFkC37svQ5MS0o9aUbQ0ewVWKMoIjIfA9r708DXDFOc1BOzYFkBoYHHi rW1/jykZU2yS7QRZSbjTa22SdS1RxGTzzEX8v5qowqJEcP4jt5UGtw1HAfKs3DwkEjOB eBipOrWD6rVFftvAppcYyTGlysJjucZg4jXJpltyBdguX6ElEzZUyyHB0cKxZk+AEOfv wsOtVTlkNnJekuLVJh4D/SZ2gy1i5l5NUYJNbmZ/M1NoKFqSRWE6bgTuIzEdS6mhYwnm sfNw== X-Gm-Message-State: AOJu0YyBHUEgeejaT9UQK/vTOhJLKnTqdb94ReWGgKTHKepiVXRimQ7l /BiTO2hkVmvqnsuWa7aXt7W1zzwJ2TJ7dXOb879QkUw17ltgaivFHZygiA== X-Google-Smtp-Source: AGHT+IGjE4BvOQWiJ6bDWS48LfYY9Ix+0He9iyu41uFBR9pNy9Mtv3wr+B2l82ASv01bXyoIp07reKVh1UmKAYlTLAs= X-Received: by 2002:a05:6808:1144:b0:3a7:a299:1201 with SMTP id u4-20020a056808114400b003a7a2991201mr3070049oiu.23.1691769702368; Fri, 11 Aug 2023 09:01:42 -0700 (PDT) MIME-Version: 1.0 From: Random Joe Date: Fri, 11 Aug 2023 19:01:31 +0300 Message-ID: To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH] avcodec/cuviddec: update parser ulMaxNumDecodeSurfaces X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Fixes video output stutter caused by different number of buffers in decoder vs parser introduced in 402d98c . Signed-off-by: Random Joe --- libavcodec/cuviddec.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/libavcodec/cuviddec.c b/libavcodec/cuviddec.c index 814bc53f70..1b62832eca 100644 --- a/libavcodec/cuviddec.c +++ b/libavcodec/cuviddec.c @@ -360,7 +360,14 @@ static int CUDAAPI cuvid_handle_video_sequence(void *opaque, CUVIDEOFORMAT* form } } - return 1; + // make CUVIDDECODECREATEINFO::ulNumDecodeSurfaces = CUVIDPARSERPARAMS::ulMaxNumDecodeSurfaces + // returning a value > 1 , will notify the driver to set the parser ulMaxNumDecodeSurfaces + // to this return value . + + if(ctx->cuparseinfo.ulMaxNumDecodeSurfaces != cuinfo.ulNumDecodeSurfaces) + return cuinfo.ulNumDecodeSurfaces; + else + return 1; } static int CUDAAPI cuvid_handle_picture_decode(void *opaque, CUVIDPICPARAMS* picparams) @@ -1022,7 +1029,9 @@ static av_cold int cuvid_decode_init(AVCodecContext *avctx) goto error; } - ctx->cuparseinfo.ulMaxNumDecodeSurfaces = ctx->nb_surfaces; + // set ulMaxNumDecodeSurfaces to a dummy value of 1 as recommended in NVDEC Programming Guide + // set the optimal value in pfnSequenceCallback where CUVIDEOFORMAT::min_num_decode_surfaces is reported + ctx->cuparseinfo.ulMaxNumDecodeSurfaces = 1; ctx->cuparseinfo.ulMaxDisplayDelay = (avctx->flags & AV_CODEC_FLAG_LOW_DELAY) ? 0 : CUVID_MAX_DISPLAY_DELAY; ctx->cuparseinfo.pUserData = avctx; ctx->cuparseinfo.pfnSequenceCallback = cuvid_handle_video_sequence; -- 2.39.2 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".