From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 4D6674E74C for ; Fri, 30 Jan 2026 12:06:51 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'FrtRMDKchC1BAOI+Kc6LIzHqX1GT1JOxJZrzeBiStd8=', expected b'kvajTV+favgK5xODZZ8R9yqJwz3G3UAL2Og8LwZFIy4=')) header.d=gmail.com header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1769774790; h=mime-version : references : in-reply-to : date : message-id : to : content-type : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : from; bh=fxfxsVnLUKKv+KQriOnLcTFD8nOTkaZEcIyXTGq2CEQ=; b=U6SZBTe5BEeeCQAGDbakBpGEy02VVLRYlZxbohkiDW/YJgB64OCDD+pB0FaFqrK+kPHyu TbzVUFV+pyliXd4fKQofmxz1wNwsJeuO9dT3NpCkzS6wQ3VO0iTUvysIx9jgeT5toYhGWRQ lLo7S0qcjAU6//61wIzGdZS2nhhhOKDISc2uFGAdkqKkslT1mpL2mbzRUqIwidlo84klt4W KRgrZA+CxySo0ShulqP0QTg78OU3R8AOvSzwTlUJQLl0cgnnWFyPW/r9GCUwJg1ADZRjDiY DmDZkcIoW/n7TutEhRZ24zwXObxqlvsEvzgA2ySEL8PS021ehEB4stuPSRrQ== Received: from [172.20.0.4] (unknown [172.20.0.4]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id AF227690F55; Fri, 30 Jan 2026 14:06:30 +0200 (EET) ARC-Seal: i=2; cv=fail; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1769774774; b=ub0vfbD/zNHdFMxpjtZiBrAZ/iTpqIvd9rnWfmqGSihIb8FfFqYcdFzUz6y3qnMndYEX+ oOfTmpweJY3ef0KNakGgiCjguj2kdcwilo5IMzfwT78uJqXexFfx0uItn5jtVJLbKhL7Gx0 d1A+VBR8lvU0wL9KuLhqTNPeiAPsrfH/Vxb1Mr7i4Eoh2czrdjK+IGsxdG7YTOEXCETfnFv UXYQ09nUWu0gVNK4qOP7ad0oV7AFM3KVSpcAT61E5bECLuuO4RERNVQ09YFJyNU6n95Caw0 FiRgTYz5DzRROUJRYcixjH0EaZOnirw4pZP3oE2OBd8DBDhcIawAjVvn4JVA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1769774774; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=FrtRMDKchC1BAOI+Kc6LIzHqX1GT1JOxJZrzeBiStd8=; b=KjeE8gUTShGHicEb9q2tlieL08CHH80uRlEfbHk6CqwKAXG6AV7EFepPA2ORRf1l9SCg1 mHNI73mJRM6afdRZdQVnHs+9ydEivc4GUkHZtLgQpC1r0PLHfWPsrBrq/x0/7xUPndc9PZU 0VZrXfNw2djdCaT4V5EqE03mjeAn0WBi9/osiaAhHuQfcl0T3eyzAqL/2ICaov2QJUGYWIQ EqMWeJkZiiRKpF0cXsy0Idooofw7qtVxhAOKMEiGhabhdiNZytEKrLYaLTFh2D8l4TswzI5 8uc3T2pGI6HjDs07a++nVKN07oOhtKrJsI6pYqY72jHD1T9gCUPy9IxtbTaQ== ARC-Authentication-Results: i=2; ffmpeg.org; dkim=fail header.d=gmail.com; arc=fail; dmarc=fail header.from=gmail.com policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=fail header.d=gmail.com; arc=fail (Most recent ARC-Message-Signature did not validate); dmarc=fail (Used From Domain Record) header.from=gmail.com policy.dmarc=quarantine Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id CE907690E2F for ; Fri, 30 Jan 2026 14:05:59 +0200 (EET) Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-b6ce6d1d3dcso786280a12.3 for ; Fri, 30 Jan 2026 04:05:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1769774757; cv=none; d=google.com; s=arc-20240605; b=Y4u7uX+PFTv+VtIjNARrIhzfCZQeBwprx5EkItlSfE6cnDrZKxqmTj514Kzv8q67VL nLBx/3JUwWvAfgVDRc9A8bWhL+GdMmXaNr7fNQQobDDLA2QwW5ZQu7YCag0w7VzedtYs yv0NEFeEJDv9qieiaWJGiwF3q+JBLmlMRxvmRvo5+d7ZfMTwh+v5CL0UTf/vw3eRySkX vEb2BRHSq8OEBrmDZmUJXspPmvXccD1UgUoKyhq5NfNqGQVNNQtkQ1uTZrBLTx/P+l48 SBqtzi+ouy0SZxbgZ4v5OTck2Ro0fCwVyaomLQ1+JERb6n2PS9TdCYlvd4eAxkamZPto phgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=kvajTV+favgK5xODZZ8R9yqJwz3G3UAL2Og8LwZFIy4=; fh=YOA8vD9MJZuwZ71F/05pj6KdCjf6jQRmzLS+CATXUQk=; b=WoSYHErajKfkYiU0At3/N3JlHO/fWiwRRiDTXSxpLIt1qa1ZRjOj81UylavpANXYtU YHfxpVMN/cNmEqk2loL/zeKKTSgAXqNBG8Qjg+3BEC/cYAA+GjhgEceEvtJK9J/71cFW 9HQAbfD8LbBh8TDf+1OVxH2bskMtZGeVJ1jmDnXkv1cyGAGO3D8ukrrJI+NGAC4ZuWqT 3nvH9RYLADTwcpto3TGi3ho/pf21DyPPCmeRigV1WidZ8YN8FddE3cQ/2cOK4U+6LT09 epHfzh8hos0hwJv1UFRgfMhWeBEO0ZkxAH4euB4ezTm5bERVB4Ir2/2oWer1OCm8ZcRw i6xQ==; darn=ffmpeg.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769774757; x=1770379557; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=kvajTV+favgK5xODZZ8R9yqJwz3G3UAL2Og8LwZFIy4=; b=OgqmT3zGeljXw/UfZ5FcR2KP1U/CG6d7yYru8AECbCRTpK9B0tgQtO0UzlGri9F2rx r34qLGjKD/ZvD8iLMWs5TYlYyM0P2Jh38CQSFOl4e76asryDxPQ+pEpMqsmGLWMGCvOE lTCSeTU4jfCPngFrHPaNWtIZN2bU0qm9nCQKxY9TIvWy4ZFEIEsICWC2LJSVDz/veaJO qKxO5Uz6Grob83+BSKRbh8C1c+m7StY/UOe3rXi7OwWEiURJytf296uuBOG4AapInXN9 fmIjF7x9RcIQ7SJJ18sKxgB7Mn3bZQhrajRkF9WGpMvLPjSATmqEJmjO35wWsvb4UW3w yiVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769774757; x=1770379557; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kvajTV+favgK5xODZZ8R9yqJwz3G3UAL2Og8LwZFIy4=; b=kg/nWeD9vqTrfQqXPdrmGCNiOUeKSf7Ab33dVTbvQgZVbZSsq5DDeNad5E33wUAMm4 6D3woJM41MhUYehi6am7vLTRzXAFjqxWEhq8qhxkIRYlp+KxNG22ZlsDppB4u9U5H0em o0TpwEs2NtNTd53o5oPMMtWsovEByXvHNolepvNE7NFBV/a53dNscQ+pIjPAawRakuyw 5nuliNHhvLerWgAgktGZtQ9eNd3VX64qJga1RpHOTTFPdxLfOFiGkvVgddaht4jrYaLj gvnapQYTq0pa01yRfm6GPGfOs5JwxTBdhBwFmbOmkEY310mUxpoMcMUgJm+9g8LLhQxa TOIw== X-Gm-Message-State: AOJu0YxpSeJ1R4bisJYioVeKffOgVGZD643Pq5IXmaA3/wqi1k624pdg 45qkx7ABIRqc8m4Ay3GUKdVt1IlxacNbBwAZWN1ForEVw205i8YfwP/qWlkxgLySouv/sSXDYi3 W24SPRzMCshoZgXdcvCM+0vVbkKXPgeBpL1fG X-Gm-Gg: AZuq6aJVIWfDr1vA+4f37OMvuEXQFTg21fsXklNmkC/Rrjth6IfuPz2tQWGBr26TRFM UySo9kmyLcad51jftjT1rRgq+01rIJlxe+LlJ+AWCxfnwMrMiex1qtvamgIydW9xg5qK7s11c4k xOZFD8mobqwaJtdYRvWC6VmEBkTtlE2ntGaerPHRP5Pmv1Q2BYMqc0OMVmzLptczaQmPyFyFD8A uX+ofrwirw1JME1+2GqgjWOLNm1tLyA6gkcorGjmH+lw1zV6fjgymQoaLpP0RKRDM5Kss5+BA== X-Received: by 2002:a17:90b:2244:b0:32e:749d:fcb7 with SMTP id 98e67ed59e1d1-3543b33884cmr2706532a91.13.1769774757242; Fri, 30 Jan 2026 04:05:57 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: Date: Fri, 30 Jan 2026 17:35:47 +0530 X-Gm-Features: AZwV_QgBijre2QE1HWV-uek2nuHG_2dTRaE18olVmt5j9RCxQk3kvRA0lN2PxCM Message-ID: To: ffmpeg-devel@ffmpeg.org Content-Type: multipart/mixed; boundary="000000000000bd5e34064999cbdb" Message-ID-Hash: TARKAEIVAUBHEQSVHVQ3UEII4JJN5S6Z X-Message-ID-Hash: TARKAEIVAUBHEQSVHVQ3UEII4JJN5S6Z X-MailFrom: SRS0=Zoxk=AD=gmail.com=devrajajmera077@ffmpeg.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation X-Content-Filtered-By: Mailman/MimeDel 3.3.10 X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] Re: [PATCH] lavf/whip: improve RTP muxer error message List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Devraj Ajmera via ffmpeg-devel Cc: Devraj Ajmera Archived-At: List-Archive: List-Post: --000000000000bd5e34064999cbdb Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > I think the av_unreachable() should be used with a reason > > So maybe av_unreachable("RTP muxer should be enabled"); > > BTW, it seems you use wrong indent here. Thanks for the suggestion. I have updated the code to use av_unreachable() with an explicit reason string, and fixed the indentation to match the existing FFmpeg style. An updated patch reflecting these changes has been generated and sent. Regards, Devraj On Fri, Jan 30, 2026 at 11:02=E2=80=AFAM Devraj Ajmera wrote: > > configure already deps the rtp_muxer via whip_muxer_select, so it shoul= d > never hit this error. > > > So maybe use av_unreachable() to replace current error handling? > > That makes sense. Since configure already enforces the RTP dependency via > whip_muxer_select, this code path should indeed be unreachable at runtime= . > > I have updated the code to replace the current error handling with > av_unreachable() accordingly, and will send an updated patch reflecting > this change. > > Regards, > Devraj > > On Sat, Jan 24, 2026 at 9:04=E2=80=AFPM Devraj Ajmera > wrote: > >> Hi Jack, >> >> > configure already deps the rtp_muxer via whip_muxer_select, so it >> should never hit this error. >> > So maybe use av_unreachable() to replace current error handling? >> >> That makes sense. If configure already enforces the RTP dependency via >> whip_muxer_select, then this code path should indeed be unreachable. >> >> Using av_unreachable() here sounds reasonable. I will prepare an updated >> patch replacing the current error handling accordingly. >> >> Noted. >> >> Regards, >> Devraj >> >> On Fri, Jan 23, 2026 at 12:01=E2=80=AFPM Devraj Ajmera >> wrote: >> >>> Hi Timo, >>> >>> Thanks for the insightful comment. >>> >>> You are right that if WHIP hard-depends on RTP, this might be better >>> handled at configure time rather than at runtime. The intent of this >>> patch was limited to improving the clarity of the existing error path, >>> without changing behavior. >>> >>> I agree this deserves a closer look. Would you prefer addressing this >>> by tightening the configure dependencies for the WHIP muxer, or by >>> adjusting the error handling (e.g. AVERROR_BUG) in this code path? >>> >>> Thanks, >>> Devraj >>> >>> On Fri, Jan 23, 2026 at 11:42=E2=80=AFAM Devraj Ajmera < >>> devrajajmera077@gmail.com> wrote: >>> >>>> Hi Jack, >>>> >>>> Thanks for the review. >>>> >>>> You are right, the "WHIP:" prefix is unnecessary since av_log already >>>> has context. >>>> I have updated the patch accordingly and sent a revised version. >>>> >>>> Regards, >>>> Devraj Ajmera >>>> >>>> On Tue, Jan 20, 2026 at 5:15=E2=80=AFPM Devraj Ajmera < >>>> devrajajmera077@gmail.com> wrote: >>>> >>>>> Hello, >>>>> >>>>> This patch improves the error message shown when the RTP muxer >>>>> cannot be guessed in the WHIP muxer, making the failure reason >>>>> clearer to users. >>>>> >>>>> Regards, >>>>> Devraj Ajmera >>>>> >>>> --000000000000bd5e34064999cbdb Content-Type: application/octet-stream; name="0001-lavf-whip-mark-RTP-muxer-lookup-as-unreachable.patch" Content-Disposition: attachment; filename="0001-lavf-whip-mark-RTP-muxer-lookup-as-unreachable.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_ml0tym300 RnJvbSAzZTVjMzBiNzkzOTdjYWRlNmIwNTY5M2M4OGZkNmFiNGRjMzk3ZjMzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBkZXZyYWogYWptZXJhIDxkZXZyYWpham1lcmEwNzdAZ21haWwu Y29tPgpEYXRlOiBGcmksIDMwIEphbiAyMDI2IDEwOjA2OjI3ICswNTMwClN1YmplY3Q6IFtQQVRD SF0gbGF2Zi93aGlwOiBtYXJrIFJUUCBtdXhlciBsb29rdXAgYXMgdW5yZWFjaGFibGUKCi0tLQog bGliYXZmb3JtYXQvd2hpcC5jIHwgMTAgKysrKy0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDQgaW5z ZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saWJhdmZvcm1hdC93aGlw LmMgYi9saWJhdmZvcm1hdC93aGlwLmMKaW5kZXggYzM1MDc0MDVmYS4uN2Y0M2RiZjFhNyAxMDA2 NDQKLS0tIGEvbGliYXZmb3JtYXQvd2hpcC5jCisrKyBiL2xpYmF2Zm9ybWF0L3doaXAuYwpAQCAt MTU0OCwxMiArMTU0OCwxMCBAQCBzdGF0aWMgaW50IGNyZWF0ZV9ydHBfbXV4ZXIoQVZGb3JtYXRD b250ZXh0ICpzKQogICAgIFdISVBDb250ZXh0ICp3aGlwID0gcy0+cHJpdl9kYXRhOwogICAgIHdo aXAtPnVkcC0+ZmxhZ3MgfD0gQVZJT19GTEFHX05PTkJMT0NLOwogCi0gICAgY29uc3QgQVZPdXRw dXRGb3JtYXQgKnJ0cF9mb3JtYXQgPSBhdl9ndWVzc19mb3JtYXQoInJ0cCIsIE5VTEwsIE5VTEwp OwotICAgIGlmICghcnRwX2Zvcm1hdCkgewotICAgICAgICBhdl9sb2cod2hpcCwgQVZfTE9HX0VS Uk9SLCJGYWlsZWQgdG8gZ3Vlc3MgUlRQIG11eGVyLCBlbnN1cmUgUlRQIGlzIGVuYWJsZWQgaW4g YnVpbGRcbiIpOwotICAgICAgICByZXQgPSBBVkVSUk9SKEVOT1NZUyk7Ci0gICAgICAgIGdvdG8g ZW5kOwotICAgIH0KKyAgIGNvbnN0IEFWT3V0cHV0Rm9ybWF0ICpydHBfZm9ybWF0ID0gYXZfZ3Vl c3NfZm9ybWF0KCJydHAiLCBOVUxMLCBOVUxMKTsKKyAgICAgICBpZiAoIXJ0cF9mb3JtYXQpIHsK KyAgICAgICAgICAgYXZfdW5yZWFjaGFibGUoIlJUUCBtdXhlciBzaG91bGQgYmUgZW5hYmxlZCIp OworICAgICAgICB9CiAKICAgICAvKiBUaGUgVURQIGJ1ZmZlciBzaXplLCBtYXkgZ3JlYXRlciB0 aGFuIE1UVS4gKi8KICAgICBidWZmZXJfc2l6ZSA9IE1BWF9VRFBfQlVGRkVSX1NJWkU7Ci0tIAoy LjUyLjAud2luZG93cy4xCgo= --000000000000bd5e34064999cbdb Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org --000000000000bd5e34064999cbdb--