[FFmpeg-devel] Re: [PATCH] lavf/whip: improve RTP muxer error message

[Devraj Ajmera via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>]

Hi Jack,

Just a gentle ping on the updated patch that replaces the RTP muxer
error handling with av_unreachable(), incorporating your feedback
about the reason string and indentation.

Please let me know if anything else is needed.

Thanks,
Devraj


On Fri, Jan 30, 2026 at 5:35 PM Devraj Ajmera <devrajajmera077@gmail.com>
wrote:

> > I think the av_unreachable() should be used with a reason
> >
> > So maybe av_unreachable("RTP muxer should be enabled");
> >
> > BTW, it seems you use wrong indent here.
>
> Thanks for the suggestion.
>
> I have updated the code to use av_unreachable() with an explicit
> reason string, and fixed the indentation to match the existing
> FFmpeg style.
>
> An updated patch reflecting these changes has been generated
> and sent.
>
> Regards,
> Devraj
>
> On Fri, Jan 30, 2026 at 11:02 AM Devraj Ajmera <devrajajmera077@gmail.com>
> wrote:
>
>> > configure already deps the rtp_muxer via whip_muxer_select, so it
>> should never hit this error.
>>
>> > So maybe use av_unreachable() to replace current error handling?
>>
>> That makes sense. Since configure already enforces the RTP dependency via
>> whip_muxer_select, this code path should indeed be unreachable at runtime.
>>
>> I have updated the code to replace the current error handling with
>> av_unreachable() accordingly, and will send an updated patch reflecting
>> this change.
>>
>> Regards,
>> Devraj
>>
>> On Sat, Jan 24, 2026 at 9:04 PM Devraj Ajmera <devrajajmera077@gmail.com>
>> wrote:
>>
>>> Hi Jack,
>>>
>>> > configure already deps the rtp_muxer via whip_muxer_select, so it
>>> should never hit this error.
>>> > So maybe use av_unreachable() to replace current error handling?
>>>
>>> That makes sense. If configure already enforces the RTP dependency via
>>> whip_muxer_select, then this code path should indeed be unreachable.
>>>
>>> Using av_unreachable() here sounds reasonable. I will prepare an updated
>>> patch replacing the current error handling accordingly.
>>>
>>> Noted.
>>>
>>> Regards,
>>> Devraj
>>>
>>> On Fri, Jan 23, 2026 at 12:01 PM Devraj Ajmera <
>>> devrajajmera077@gmail.com> wrote:
>>>
>>>> Hi Timo,
>>>>
>>>> Thanks for the insightful comment.
>>>>
>>>> You are right that if WHIP hard-depends on RTP, this might be better
>>>> handled at configure time rather than at runtime. The intent of this
>>>> patch was limited to improving the clarity of the existing error path,
>>>> without changing behavior.
>>>>
>>>> I agree this deserves a closer look. Would you prefer addressing this
>>>> by tightening the configure dependencies for the WHIP muxer, or by
>>>> adjusting the error handling (e.g. AVERROR_BUG) in this code path?
>>>>
>>>> Thanks,
>>>> Devraj
>>>>
>>>> On Fri, Jan 23, 2026 at 11:42 AM Devraj Ajmera <
>>>> devrajajmera077@gmail.com> wrote:
>>>>
>>>>> Hi Jack,
>>>>>
>>>>> Thanks for the review.
>>>>>
>>>>> You are right, the "WHIP:" prefix is unnecessary since av_log already
>>>>> has context.
>>>>> I have updated the patch accordingly and sent a revised version.
>>>>>
>>>>> Regards,
>>>>> Devraj Ajmera
>>>>>
>>>>> On Tue, Jan 20, 2026 at 5:15 PM Devraj Ajmera <
>>>>> devrajajmera077@gmail.com> wrote:
>>>>>
>>>>>> Hello,
>>>>>>
>>>>>> This patch improves the error message shown when the RTP muxer
>>>>>> cannot be guessed in the WHIP muxer, making the failure reason
>>>>>> clearer to users.
>>>>>>
>>>>>> Regards,
>>>>>> Devraj Ajmera
>>>>>>
>>>>>
_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org