From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 5CD784BC20 for ; Fri, 30 Jan 2026 05:34:41 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'3raBwiaROWdUqWyN6gvP7qIcZjdwlLo/ipppKin9c1Y=', expected b'fjSIGQmVCQAcFVwquQjFzBsRZmQd3cNnM+9eYjHy6yE=')) header.d=gmail.com header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1769751220; h=mime-version : references : in-reply-to : date : message-id : to : content-type : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : from; bh=B/Cb56jVEbqjb7IxOq6Hz/NfDLo1g3ODKiW3ax4ejBM=; b=g3smjNUDcNH9eGM6iyl81i9+LHIeDMBsbxYQaO9tGFdzRnRSI5f+wkzMrLRvHJSaffHSR 3jqss4V+LRvsoC5V2XP04cqIwL/1uednfM66cCNZ1Zt/CxpX1tS2Gd3lBAhQG8p+U69ylQZ 9TsALmjGBLyk38VEpGnE2pvPMhJOq+wHUZfMyw6HVcgMUiwCZnxbnau37CG737L3xbXPajt NTH+PVGobo8VgkaWtKy1vcvACvpmeLx7ijCpUqYy5lZCvlRR07nhscOE6PdXvuUC1SmmcVX ak6HZxp0+z21zUmhhs3xkQgpw1jQejV0JYitBErH9ANQRemsoJmUeWjsgdqw== Received: from [172.20.0.4] (unknown [172.20.0.4]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 33D3E690FAC; Fri, 30 Jan 2026 07:33:40 +0200 (EET) ARC-Seal: i=2; cv=fail; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1769751184; b=D0yhoBHD22KU1ND7vxKrCGIduUcvH0FPQOdUKFFXkqlNQhT4dOwmuPOAdrc+qizg9QxqJ dPLwCFVBF1JgsiQ34ed2qceKrPnu6eizkWZOrvg7LNapRFi4LrdImapjWlZpcU0QY3erdbn uMa8HQ9TkiDs2Lp+hrA/SzyyRL09inFmhebbh2o5VwxQU/eTQfyBx1tq3G8h6eSQhAs3+0G PquEsoqSjOgGo3yN5XFzHxs0u7muIhxIK0vrggc7NbUup6GY40xoNXg8yW62lyz37k4SOq4 4ZeG328LJEL97ozAm2UFFTP2jlrfotlq9jYzJmqNu6LCRi1QAYWeCzVO5lgQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1769751184; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=3raBwiaROWdUqWyN6gvP7qIcZjdwlLo/ipppKin9c1Y=; b=VOiKKUDbSlOb0XApPD4TBKGRMSJU2wIEukMCV9hettwnvprccvIzudCoPJjiEUyPoXLJ0 jdqoIbkVBZfHVScFeHKxZ3cjyCRgFdqGFH2a43Ws8HHFPUKlDjynp29RH8YRe2DY2LN62Pg s3t7N6Mne/aNdGsXRg3qWMGvoQhXAbAsfoQIWaAc7s2cAZrsE5oeeBN9bbRAYbzUKxJwdtm BQtK1Q/+mJaqGG0SaE3+u8BybTz1Uhgs6jDhTDvJgrR+4kw90mmlSSpA4EW0I4E6CNhSEil IgOeM8ZxxJJheMr28TaZAsGIPY3tJ9T9/uT0XYhc2wbNS1/5Pe/rjrRMPX3w== ARC-Authentication-Results: i=2; ffmpeg.org; dkim=fail header.d=gmail.com; arc=fail; dmarc=fail header.from=gmail.com policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=fail header.d=gmail.com; arc=fail (Most recent ARC-Message-Signature did not validate); dmarc=fail (Used From Domain Record) header.from=gmail.com policy.dmarc=quarantine Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 1E4FD690F22 for ; Fri, 30 Jan 2026 07:32:48 +0200 (EET) Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-81e8a9d521dso991972b3a.2 for ; Thu, 29 Jan 2026 21:32:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1769751166; cv=none; d=google.com; s=arc-20240605; b=PJQrf1tHgvKqPbPsELXR0LTxWM+rguXqOsc0tYid3Cq5RM1sXaASBNYnTqqF1sl0aH zp3BMdko4R/Tt0p4uT96hUxap5g8t4zEsky+bQ/e87SDuljLOebHAPBb8P3TTq1CDSRV 6nI96d3UCyfRCZXX+0oPq23YaxOfSOPy2FhwrRrgL372ZBBKLd5j7sWLuHQLiv7e1+TB E2q1Qr/yy92UJIE1FZmh53Ubk1UE76yHMmw/qNQSxnBR8lw+TKVJ88B0Bbp2BP0SreRd YLv2Ig+9wbCvosI3a/LKZe75oXjMAHhyQWwOFvGE/jSonS0zorpQN23eIGm6RWGWOFpe Ruig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=fjSIGQmVCQAcFVwquQjFzBsRZmQd3cNnM+9eYjHy6yE=; fh=YOA8vD9MJZuwZ71F/05pj6KdCjf6jQRmzLS+CATXUQk=; b=l20DWoILpwQEFsCiU8Mb2+c6ZeaoOw4cIK/mltHoefRfj+PyG7MDvNSENORgSkQLjw g/ktOOuoiazRphSOV3wQwYxb0psDKrGlpPMWYgny0M8eZ/CzqyotV+79UPpFNiq2YLw1 ZhKxr3BD/NV7K7iPnJH4ox5KiiOn9TJQTLr6VFHKdaiiGJ3hlAEsapLblvmoFUdBUiAy 1ptMrgHT3HImAiuA5AJe99OpOmBtn5/syZ8jO8gMms4yWofz8WGA8VVTyX9XmAL6VCM/ Mw7T2XkM90QjdfwIA4H/0ozSLF6cXKw7hpnhkAaJhpZf31PcbJ/5goBjVac0OGg7RGBk mOwg==; darn=ffmpeg.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769751166; x=1770355966; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=fjSIGQmVCQAcFVwquQjFzBsRZmQd3cNnM+9eYjHy6yE=; b=BkwCOakcEiinm4eUHbMoJo0uiKcf1/KW/p1ny9UxN/yH0xNBVJZ+sIz/4H8tFhev0d TNai+x+T20X0+sPhKy7fsVE2S+PXU4O/pbQxx4s3JagPWgpfHbR4ThICwkSALW1vgpzt gYyJGXfjWLDzjINegbMK37uqWUQLJbFX6+FGZZtGA7ljCW7yox8WoGwZOVVmN6WMXLiO nTkaFqkVsI4c5SCA/sXw5Nu09Y8G3WX3R+PvbQxSTbm8U9tQNyKoEu8RiDkpzFHHokwP 4T5dBmnwT8b88pP8vhWJ+7KYIgvhLpMie7NV7/uyb4I2aEsAl5x/ksb1fUpAiinTO5fw xylQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769751166; x=1770355966; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fjSIGQmVCQAcFVwquQjFzBsRZmQd3cNnM+9eYjHy6yE=; b=Kj+kuZ3M23xYYx+ja02qDpaFkhZ4Jjx5S5Cgha8hcR5xzvpF5CD0VimBacrLJeTiYe StaYftHWDzplwF5J7bSOde4UmcprF8RvIWLV2zQqj+Ve5LDO4fI8cbb4P42IS5v5Bu1j nwXvqqnAQEXyIpgKhgh10P6UtM9Pgsvk87VIYt7o/ZAYcnNw33WJWjCyRduxVayY6tbk yL6fv8K/cOeq5JyoSBWL6pIl7pYCUIDGl6tBj3Qzn8Rc+tI1yCxPDCK7ZpQed9NyyFhr +grrOXbeat7HMd4+X+4CfW2NOP2ur/eDbNXZ4J+C4AXKLBvFpc0lZgSZbQdvcNv1ovHZ qxng== X-Gm-Message-State: AOJu0Yzxs71DIaWD1pyC6bNs+0OUPFxsEBPYHIG0xfUut+7gC7NRUb48 NIeAjEeU9eDMRzf4w9gtYiWay39b9wbNq/gH2fptg649r7DdlDl4aUKHNMwraGAhcSXjH5lzJ3d X9WGu4MaK881wO+7TmuHv9bLcPYnyatpBrFY0 X-Gm-Gg: AZuq6aI2SFRUdRpLsdQhX6HGQ2f8iCT16eqD9w2atnKm2WQcxCDQ5r+XXdCfy5F3OYR uhFNZanJUKVfp/mIvEvw5072eeR9loNnv0UWLW8kX5fvpF/P8VQQlMQbD932yEcC6k81AbuGRqe b/sgX/CkyaqtYIDo62gu36k2oCS5jpl2zBwy0DnpK64DFmr+yAsKIhX0xX+luejCN9WlZygP0ly bCOoohqrGC6CbgHaMR1sJv3JzMuzGrVQ4PEyrFYElpKZMczq2A75zPYLQjC/fvrsNVjr0s= X-Received: by 2002:a05:6a20:d528:b0:38d:e6f8:fd96 with SMTP id adf61e73a8af0-392e0163730mr1291109637.60.1769751164588; Thu, 29 Jan 2026 21:32:44 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: Date: Fri, 30 Jan 2026 11:02:34 +0530 X-Gm-Features: AZwV_QgOnpdftU2ptSEN5Zy0xwAZQIpIUXLMsbrnk_liMz2ead6tNhnHHsrvIUc Message-ID: To: ffmpeg-devel@ffmpeg.org Content-Type: multipart/mixed; boundary="00000000000081acf90649944d99" Message-ID-Hash: WHBQRI4ARBP4FTKV4MARCQUWCBI67WTO X-Message-ID-Hash: WHBQRI4ARBP4FTKV4MARCQUWCBI67WTO X-MailFrom: SRS0=Zoxk=AD=gmail.com=devrajajmera077@ffmpeg.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation X-Content-Filtered-By: Mailman/MimeDel 3.3.10 X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] Re: [PATCH] lavf/whip: improve RTP muxer error message List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Devraj Ajmera via ffmpeg-devel Cc: Devraj Ajmera Archived-At: List-Archive: List-Post: --00000000000081acf90649944d99 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > configure already deps the rtp_muxer via whip_muxer_select, so it should never hit this error. > So maybe use av_unreachable() to replace current error handling? That makes sense. Since configure already enforces the RTP dependency via whip_muxer_select, this code path should indeed be unreachable at runtime. I have updated the code to replace the current error handling with av_unreachable() accordingly, and will send an updated patch reflecting this change. Regards, Devraj On Sat, Jan 24, 2026 at 9:04=E2=80=AFPM Devraj Ajmera wrote: > Hi Jack, > > > configure already deps the rtp_muxer via whip_muxer_select, so it shoul= d > never hit this error. > > So maybe use av_unreachable() to replace current error handling? > > That makes sense. If configure already enforces the RTP dependency via > whip_muxer_select, then this code path should indeed be unreachable. > > Using av_unreachable() here sounds reasonable. I will prepare an updated > patch replacing the current error handling accordingly. > > Noted. > > Regards, > Devraj > > On Fri, Jan 23, 2026 at 12:01=E2=80=AFPM Devraj Ajmera > wrote: > >> Hi Timo, >> >> Thanks for the insightful comment. >> >> You are right that if WHIP hard-depends on RTP, this might be better >> handled at configure time rather than at runtime. The intent of this >> patch was limited to improving the clarity of the existing error path, >> without changing behavior. >> >> I agree this deserves a closer look. Would you prefer addressing this >> by tightening the configure dependencies for the WHIP muxer, or by >> adjusting the error handling (e.g. AVERROR_BUG) in this code path? >> >> Thanks, >> Devraj >> >> On Fri, Jan 23, 2026 at 11:42=E2=80=AFAM Devraj Ajmera >> wrote: >> >>> Hi Jack, >>> >>> Thanks for the review. >>> >>> You are right, the "WHIP:" prefix is unnecessary since av_log already >>> has context. >>> I have updated the patch accordingly and sent a revised version. >>> >>> Regards, >>> Devraj Ajmera >>> >>> On Tue, Jan 20, 2026 at 5:15=E2=80=AFPM Devraj Ajmera >>> wrote: >>> >>>> Hello, >>>> >>>> This patch improves the error message shown when the RTP muxer >>>> cannot be guessed in the WHIP muxer, making the failure reason >>>> clearer to users. >>>> >>>> Regards, >>>> Devraj Ajmera >>>> >>> --00000000000081acf90649944d99 Content-Type: application/octet-stream; name="0001-lavf-whip-mark-RTP-muxer-lookup-as-unreachable.patch" Content-Disposition: attachment; filename="0001-lavf-whip-mark-RTP-muxer-lookup-as-unreachable.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_ml0fsnay0 RnJvbSA2ZjhmZGJiNmZkYzQ0OGE5M2I3NDA1ZTllODM1ZTIwYzcyMTgzYmUwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBkZXZyYWogYWptZXJhIDxkZXZyYWpham1lcmEwNzdAZ21haWwu Y29tPgpEYXRlOiBGcmksIDMwIEphbiAyMDI2IDEwOjA2OjI3ICswNTMwClN1YmplY3Q6IFtQQVRD SF0gbGF2Zi93aGlwOiBtYXJrIFJUUCBtdXhlciBsb29rdXAgYXMgdW5yZWFjaGFibGUKCi0tLQog bGliYXZmb3JtYXQvd2hpcC5jIHwgNiArKy0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlv bnMoKyksIDQgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGliYXZmb3JtYXQvd2hpcC5jIGIv bGliYXZmb3JtYXQvd2hpcC5jCmluZGV4IGMzNTA3NDA1ZmEuLjRmZjMyYTFhM2MgMTAwNjQ0Ci0t LSBhL2xpYmF2Zm9ybWF0L3doaXAuYworKysgYi9saWJhdmZvcm1hdC93aGlwLmMKQEAgLTE1NTAs MTAgKzE1NTAsOCBAQCBzdGF0aWMgaW50IGNyZWF0ZV9ydHBfbXV4ZXIoQVZGb3JtYXRDb250ZXh0 ICpzKQogCiAgICAgY29uc3QgQVZPdXRwdXRGb3JtYXQgKnJ0cF9mb3JtYXQgPSBhdl9ndWVzc19m b3JtYXQoInJ0cCIsIE5VTEwsIE5VTEwpOwogICAgIGlmICghcnRwX2Zvcm1hdCkgewotICAgICAg ICBhdl9sb2cod2hpcCwgQVZfTE9HX0VSUk9SLCJGYWlsZWQgdG8gZ3Vlc3MgUlRQIG11eGVyLCBl bnN1cmUgUlRQIGlzIGVuYWJsZWQgaW4gYnVpbGRcbiIpOwotICAgICAgICByZXQgPSBBVkVSUk9S KEVOT1NZUyk7Ci0gICAgICAgIGdvdG8gZW5kOwotICAgIH0KKyAgICBhdl91bnJlYWNoYWJsZSgp OworfQogCiAgICAgLyogVGhlIFVEUCBidWZmZXIgc2l6ZSwgbWF5IGdyZWF0ZXIgdGhhbiBNVFUu ICovCiAgICAgYnVmZmVyX3NpemUgPSBNQVhfVURQX0JVRkZFUl9TSVpFOwotLSAKMi41Mi4wLndp bmRvd3MuMQoK --00000000000081acf90649944d99 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org --00000000000081acf90649944d99--