From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id F1E7A42915 for ; Thu, 6 Oct 2022 06:04:05 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E2B0168BB75; Thu, 6 Oct 2022 09:04:02 +0300 (EEST) Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C430168BB26 for ; Thu, 6 Oct 2022 09:03:56 +0300 (EEST) Received: by mail-lj1-f175.google.com with SMTP id j23so918506lji.8 for ; Wed, 05 Oct 2022 23:03:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=qGTmWeXKcdzB5uTpqV3AKb5X577Vkc4CyEBgmnAc9pk=; b=lJJb7q8RZH342vPtUIRxJBPIeg4Ic6MIzv0142QQuXd1dI6J+cBgj7FVaVUEovJnUa jhgoFqZY6GykWLMOgjmxfFP1AVFf7gQrgczeUUm7AmF3+zG1XWWTc7eLYCB0jkRsvaSs QyF+itSLO6+orvTK1r+BucOaUpQMv+2Z48eD3tJ+316/8/GZJC8xNbppY175+vCqjVu1 f0K9+tuLg4hlfSU1qLnE7PTjGXbSsYVsWMT9QocLSlB8EfZh39vTT4UnhB4KtJikhXwO erZ2zMCPf5FsPC1Z/u+XcyvNScoggMvuLfw90nb3wCeVdZi2iKeO2/GXtQG1/CyL3Kdt zkfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qGTmWeXKcdzB5uTpqV3AKb5X577Vkc4CyEBgmnAc9pk=; b=6jHHloGaxVNVruqNHYuJ0Wr1O3A2I0wV8gMjRkgH+oEVoP+8J0MPHam6UaRpchzMyC A3gg3yy+VRy1fA+5QW7flvr8nnJoHNedWL/dx2fw1nMeFlfnghK2U9uFv4M2Df/9Omy5 VvQhkNV62wwDtZApwRRHObTZhyP3WBMfPrnOx8bUvvdXuCYNf3Ms9+Re59Mp+ZxDNTue hPQSymF6d1gBus5O/xTPQeTKzwaa3RzU71wDteaJp421xLz3cIQxmTDeh6dbkSIQiFpC pMaaGhazJPD37qIjRoOAw7rxwiDmpBV7mePRqIDLZeUFc5YYUX0p4F4U2/w0S07iqzYg cf8g== X-Gm-Message-State: ACrzQf06GAUJtN2RFMLZPyv5nt9oayUqmXt96mKsMT2YUJhFzarHnCRs osoEDzozwClSBwP554H+TLCsoAfjW1HGyJcxwsVTqlaw X-Google-Smtp-Source: AMsMyM4owaGWHnC8zjIwP/+RxDTkfy4C/JWoFbzuzb8rqU5PDXMKViz9HQmKuBl54LS0qQojxslLg6NllhupBzzj2dQ= X-Received: by 2002:a2e:9013:0:b0:26d:d19a:3664 with SMTP id h19-20020a2e9013000000b0026dd19a3664mr1216316ljg.88.1665036235548; Wed, 05 Oct 2022 23:03:55 -0700 (PDT) MIME-Version: 1.0 References: <20220927210605.692742-1-gustav.grusell@gmail.com> In-Reply-To: <20220927210605.692742-1-gustav.grusell@gmail.com> From: Gustav Grusell Date: Thu, 6 Oct 2022 08:03:43 +0200 Message-ID: To: ffmpeg-devel@ffmpeg.org X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libsvtav1: Add support for multipass encoding X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Any chance of someone finding the time to have a look at this? /Gustav On Tue, Sep 27, 2022 at 11:06 PM Gustav Grusell wrote: > Implements support for 2-pass CRF and 3-pass VBR by implementing > reading and writing of stats file, and passing the pass number on > to the encoder. For 3-pass VBR, the first pass should be run with > '-pass 1', the second with '-pass 3' and the third with '-pass 2'. > > Signed-off-by: Gustav Grusell > --- > libavcodec/libsvtav1.c | 82 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 82 insertions(+) > > diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c > index 2f5634cee0..73fece49b7 100644 > --- a/libavcodec/libsvtav1.c > +++ b/libavcodec/libsvtav1.c > @@ -24,6 +24,7 @@ > #include > #include > > +#include "libavutil/base64.h" > #include "libavutil/common.h" > #include "libavutil/frame.h" > #include "libavutil/imgutils.h" > @@ -312,6 +313,22 @@ static int config_enc_params(EbSvtAv1EncConfiguration > *param, > cpb_props->avg_bitrate = avctx->bit_rate; > } > > + if (avctx->flags & AV_CODEC_FLAG_PASS2) { > + if (param->rate_control_mode == SVT_AV1_RC_MODE_VBR) { > + if (avctx->flags & AV_CODEC_FLAG_PASS1) { > + param->pass = 2; > + } else { > + param->pass = 3; > + } > + } else { > + param->pass = 2; > + } > + } else if (avctx->flags & AV_CODEC_FLAG_PASS1) { > + param->pass = 1; > + } else { > + param->pass = 0; > + } > + > return 0; > } > > @@ -371,6 +388,34 @@ static av_cold int eb_enc_init(AVCodecContext *avctx) > return ret; > } > > + if (svt_enc->enc_params.pass >= 2) { > + int decode_size; > + > + if (!avctx->stats_in) { > + av_log(avctx, AV_LOG_ERROR, "No stats file for %s pass\n", > + svt_enc->enc_params.pass == 2 ? "second" : "third"); > + return AVERROR_INVALIDDATA; > + } > + > + svt_enc->enc_params.rc_stats_buffer.sz = strlen(avctx->stats_in) > * 3 / 4; > + svt_enc->enc_params.rc_stats_buffer.buf = av_malloc(svt_enc-> > enc_params.rc_stats_buffer.sz); > + if (!svt_enc->enc_params.rc_stats_buffer.buf) { > + av_log(avctx, AV_LOG_ERROR, > + "Stat buffer alloc (%"SIZE_SPECIFIER" bytes) failed\n", > + svt_enc->enc_params.rc_stats_buffer.sz); > + svt_enc->enc_params.rc_stats_buffer.sz = 0; > + return AVERROR(ENOMEM); > + } > + decode_size = > av_base64_decode(svt_enc->enc_params.rc_stats_buffer.buf, avctx->stats_in, > + svt_enc-> > enc_params.rc_stats_buffer.sz); > + if (decode_size < 0) { > + av_log(avctx, AV_LOG_ERROR, "Stat buffer decode failed\n"); > + return AVERROR_INVALIDDATA; > + } > + > + svt_enc->enc_params.rc_stats_buffer.sz = decode_size; > + } > + > svt_ret = svt_av1_enc_set_parameter(svt_enc->svt_handle, > &svt_enc->enc_params); > if (svt_ret != EB_ErrorNone) { > return svt_print_error(avctx, svt_ret, "Error setting encoder > parameters"); > @@ -544,6 +589,38 @@ static int eb_receive_packet(AVCodecContext *avctx, > AVPacket *pkt) > if (headerPtr->flags & EB_BUFFERFLAG_EOS) > svt_enc->eos_flag = EOS_RECEIVED; > > + if (svt_enc->eos_flag == EOS_RECEIVED) { > + if (svt_enc->enc_params.pass == 1) { > + SvtAv1FixedBuf first_pass_stat; > + EbErrorType ret = svt_av1_enc_get_stream_info( > + svt_enc->svt_handle, > + SVT_AV1_STREAM_INFO_FIRST_PASS_STATS_OUT, > + &first_pass_stat); > + if (ret == EB_ErrorNone) { > + size_t b64_size = AV_BASE64_SIZE(first_pass_stat.sz); > + avctx->stats_out = av_malloc(b64_size); > + if (!avctx->stats_out) { > + av_log(avctx, AV_LOG_ERROR, "Stat buffer alloc > (%"SIZE_SPECIFIER" bytes) failed\n", > + b64_size); > + return AVERROR(ENOMEM); > + } > + av_base64_encode(avctx->stats_out, b64_size, > first_pass_stat.buf, > + first_pass_stat.sz); > + } > + } > + if (svt_enc->enc_params.pass == 2) { > + size_t b64_size = AV_BASE64_SIZE(svt_enc-> > enc_params.rc_stats_buffer.sz); > + avctx->stats_out = av_malloc(b64_size); > + if (!avctx->stats_out) { > + av_log(avctx, AV_LOG_ERROR, "Stat buffer alloc > (%"SIZE_SPECIFIER" bytes) failed\n", > + b64_size); > + return AVERROR(ENOMEM); > + } > + av_base64_encode(avctx->stats_out, b64_size, > svt_enc->enc_params.rc_stats_buffer.buf, > + svt_enc->enc_params.rc_stats_buffer.sz); > + } > + } > + > ff_side_data_set_encoder_stats(pkt, headerPtr->qp * FF_QP2LAMBDA, > NULL, 0, pict_type); > > svt_av1_enc_release_out_buffer(&headerPtr); > @@ -564,6 +641,11 @@ static av_cold int eb_enc_close(AVCodecContext *avctx) > av_freep(&svt_enc->in_buf); > } > > + if (svt_enc->enc_params.rc_stats_buffer.buf) { > + av_freep(&svt_enc->enc_params.rc_stats_buffer.buf); > + svt_enc->enc_params.rc_stats_buffer.sz = 0; > + } > + > av_buffer_pool_uninit(&svt_enc->pool); > av_frame_free(&svt_enc->frame); > > -- > 2.34.1 > > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".