From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6D10B4017A for ; Thu, 3 Nov 2022 15:41:30 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6426768BFAF; Thu, 3 Nov 2022 17:41:28 +0200 (EET) Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2CC9368BF23 for ; Thu, 3 Nov 2022 17:41:22 +0200 (EET) Received: by mail-lf1-f54.google.com with SMTP id g12so3506600lfh.3 for ; Thu, 03 Nov 2022 08:41:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=F2xsD7JbII52HEweBzeMOjk6f08qeJo3g3IFibBcvU8=; b=kkDMCFTpKxZ2KDlM8E7ID/yj50v+hdwgajuQsh/GVok2Mbb7q6Hfa8XinUq1jljHKw l+yxi9rFBvX7czsKwg2+eeBt6jEnjtntetB8FlXGpJmGjIsTAMVydm22Zl0Fon7J8hBn c7suQhN1WCeJhHV7Po1mWQW9JZq1IZAA4UsEN2PElHBRbCmQ2+YkzJpK2xT10Ca1Oz2Z GH+MtRmZlUD4seYOr5KDdTj2w4o9hZpkD75UL/Uqanrc+ocW4eFDwFiOUfYhd9zuLR8o uEkyGNMgjjnXAoXipzonAp0wvcmJIzDpyq/ZvN+S19kwSevJzT9qD2p9OS5+AoV83scS wb4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=F2xsD7JbII52HEweBzeMOjk6f08qeJo3g3IFibBcvU8=; b=GSlTYUAKgluoxg8YNPkzm8BW5u/R3I3sIw6nIvwOyzu6PSoQfd2RZCswYhHctiZb5p aXCrECIjwrxa789YJ9f5FDp4WO1diV04PWDhm3No8Zy18h6iQxkCWvkXweLWtaMoQf5H tQTxHgJQt8g1lqJvDJqka72ss1niY0W8GZbciByUDCgr055YfeszephVx6xj+Q+spIdt XzuYKOo9pqbZCSwvB7QbqBhY2AXlqPvfzf8UMJDGLJvjAHUdIU4aQmwqKiCrAwgaqu/A snZgVcnbQERs5Poxan0mTEpcPUgTJKVqyfKFyxcvzyLBqSvTZQlkqbVL7MY6re3BKaC9 x5tQ== X-Gm-Message-State: ACrzQf1gt7SuD2z88j11BLVP7PcwasmX1dKJFdCr9gNv3jectXykLlpq OSe98kTW5K5UVlZHalr9W4C1IqvB1+wvf8znr1k7rOiYj4w= X-Google-Smtp-Source: AMsMyM4MCT0KaCVutGDPpx6B7UnMPVMt3CprZD6KnKvq9xw3tT0dOoST1RtXbQLoaaPxXvrTV0ag667dhsWCAnrUtfc= X-Received: by 2002:a05:6512:3b99:b0:4a2:6151:84fb with SMTP id g25-20020a0565123b9900b004a2615184fbmr13241423lfv.613.1667490080825; Thu, 03 Nov 2022 08:41:20 -0700 (PDT) MIME-Version: 1.0 References: <20220927210605.692742-1-gustav.grusell@gmail.com> In-Reply-To: From: Gustav Grusell Date: Thu, 3 Nov 2022 16:41:09 +0100 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libsvtav1: Add support for multipass encoding X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sun, Oct 30, 2022 at 11:21 PM Oneric wrote: > On Sun, Oct 30, 2022 at 14:10:29 +0100, Lynne wrote: > > Sep 27, 2022, 23:06 by gustav.grusell@gmail.com: > > > > > Implements support for 2-pass CRF and 3-pass VBR by implementing > > > reading and writing of stats file, and passing the pass number on > > > to the encoder. For 3-pass VBR, the first pass should be run with > > > '-pass 1', the second with '-pass 3' and the third with '-pass 2'. > > > > > > [...] > > > > 2-pass doesn't seem to work, the encoder complains it's not the final > pass. > > fwiw, 2-pass CRF and 3-pass VBR work for me on a short sample with this > patch applied on top of 882a17068fd8e62c7d38c14e6fb160d7c9fc446a and using > SVT-AV1 1.3.0. > > Ah good to hear the patch works also with SVT-AV1 1.3.0. I hadn't found the time to check this. > I'm not sure if 2-pass VBR is supposed to work, though I didn't look into > it too much. SVT-AV1 docs only mention 3-pass VBR[1] afaict and while > requesting output already in the second pass (`--pass 2` for SvtAv1EncApp > and `-pass 3` for patched ffmpeg) "works", the result misses the targeted > overall bitrate even more than singlepass VBR. > My understanding is also that SVT-AV1 does not support 2-pass VBR, like you say there is no mention of 2-pass VBR in the docs. The rate-control appendix gives some details about how the 3-pass VBR works, as far as I understand the second pass uses CRF so makes sense that it would miss the target bitrate. https://gitlab.com/AOMediaCodec/SVT-AV1/-/blob/master/Docs/Appendix-Rate-Control.md#vbr-rate-control-flow cheers, Gustav _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".