From: Yotam Ofek <yotam.ofek@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/aaccoder_twoloop: remove unread max scaler
Date: Tue, 2 Jul 2024 23:36:01 +0300
Message-ID: <CANJCQ3K3tBYRyPsoqUvPNJDFxdMxn1Rh6pyt+2XeM8VeET4kYA@mail.gmail.com> (raw)
In-Reply-To: <20240614102114.981720-1-yotam.ofek@gmail.com>
Bump :)
On Fri, Jun 14, 2024, 13:21 Yotam Ofek <yotam.ofek@gmail.com> wrote:
> ---
> libavcodec/aaccoder_twoloop.h | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/libavcodec/aaccoder_twoloop.h b/libavcodec/aaccoder_twoloop.h
> index c1dcdbb5ed..c56abc68a7 100644
> --- a/libavcodec/aaccoder_twoloop.h
> +++ b/libavcodec/aaccoder_twoloop.h
> @@ -101,7 +101,7 @@ static void
> search_for_quantizers_twoloop(AVCodecContext *avctx,
> */
> float sfoffs = av_clipf(log2f(120.0f / lambda) * 4.0f, -5, 10);
>
> - int fflag, minscaler, maxscaler, nminscaler;
> + int fflag, minscaler, nminscaler;
> int its = 0;
> int maxits = 30;
> int allz = 0;
> @@ -572,12 +572,10 @@ static void
> search_for_quantizers_twoloop(AVCodecContext *avctx,
> }
>
> minscaler = SCALE_MAX_POS;
> - maxscaler = 0;
> for (w = 0; w < sce->ics.num_windows; w += sce->ics.group_len[w])
> {
> for (g = 0; g < sce->ics.num_swb; g++) {
> if (!sce->zeroes[w*16+g]) {
> minscaler = FFMIN(minscaler, sce->sf_idx[w*16+g]);
> - maxscaler = FFMAX(maxscaler, sce->sf_idx[w*16+g]);
> }
> }
> }
> --
> 2.40.1
>
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-07-02 20:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 10:21 Yotam Ofek
2024-07-02 20:36 ` Yotam Ofek [this message]
2024-07-03 0:52 ` Lynne via ffmpeg-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANJCQ3K3tBYRyPsoqUvPNJDFxdMxn1Rh6pyt+2XeM8VeET4kYA@mail.gmail.com \
--to=yotam.ofek@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git