From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C80D343962 for ; Fri, 2 Dec 2022 00:46:24 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 835CE68BA08; Fri, 2 Dec 2022 02:46:21 +0200 (EET) Received: from mail-ua1-f42.google.com (mail-ua1-f42.google.com [209.85.222.42]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A6DCB68B43E for ; Fri, 2 Dec 2022 02:46:15 +0200 (EET) Received: by mail-ua1-f42.google.com with SMTP id y18so1188288uae.8 for ; Thu, 01 Dec 2022 16:46:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resi.io; s=google; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=YX3FAzULorThTZv8+QoY0/fN6ARMio7j2c8XGtMZndQ=; b=OdmUxWfmHo3OGxk5rhuQ/1S6ZuJhPZeI7zwiQD1B5ZH+3kjl6x0mYqnitafWT3ieRr LM9oSbpeBWlMi7AIEtA+KHJXBujVTf2SEpn51QUYVE7mbS1GwzXsxMrapLhXtzu0x3vi xha4KEccgNHsQn3QDWcAui2ULPBLtHfLhtkU4dAa2b47Fdt8vdej6WuYXJafiT5XdhNm u/LeE3P8LXw2Edc4a1+6TIOzyG9sFiumOeXSac7TNmUsOKq+pPVIZjQbdym8kk67vowG pURTOJQug4srNY8m2Uj73CQzH9Hp15WB/7pugcaw5BQFdxZ1SF5W3GSjkwZ5YI9/NdqG lxvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YX3FAzULorThTZv8+QoY0/fN6ARMio7j2c8XGtMZndQ=; b=4r5LIcqy8tD6p2AX3KdFIJWYBV7vmeAaQKA8MQAq+ofarWVzXvT5EVAS6XLqkXb1oV 9DadLUU6CSJuBuzrJqCVDFEUTiTrrP290/1Pev4AoDeoSEuQuWWy+fzGuSdfBwfPTgLd /4uOyfLXHNATDEqDCPTzejF2ojP/9gqFTkslNvIuiOZIp17ciY4Ei6drzI5Nw5Kltkz+ k/d0Jk+0YPKwfQ7jX6ZdsbD82+0jmPzAfj483Z1NrPkWHkAVtIK62O5yQca172liTEbH cIOLKumEUx65IJrLpK5QPjSCLoq0Obs+K8GQgXdjGNFn+GjqKGKSca6p2j/hxlCPhhdu yXaQ== X-Gm-Message-State: ANoB5pmJyddyIVIWKky2vB0dd7stY2Eu80CXGYdqDVTf8gUPRVrY847g IygK5MSHYCUvL4lGyWuPd1LinEoxPRk/TlhB4+wnIX7iFY9bDg== X-Google-Smtp-Source: AA0mqf47fHgAV45QPMJAqPMSNxDdYGBrIGVU7jJ6UraX7ux5Hj76qsUW9CrypsUAsjVe5N9DlMKvUDA3lg61sfw9d/A= X-Received: by 2002:ab0:6994:0:b0:411:502d:7c67 with SMTP id t20-20020ab06994000000b00411502d7c67mr40119430uaq.29.1669941973325; Thu, 01 Dec 2022 16:46:13 -0800 (PST) MIME-Version: 1.0 References: <20221201214029.24352-1-chris.ribble@resi.io> <376429bd-4154-a51d-7127-b69057b69934@passwd.hu> In-Reply-To: <376429bd-4154-a51d-7127-b69057b69934@passwd.hu> From: Chris Ribble Date: Thu, 1 Dec 2022 18:46:02 -0600 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] Revert "avformat/mov: disallow a zero sample size in trun atoms" X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, Dec 1, 2022 at 4:51 PM Marton Balint wrote: > > Can you explain why those files are considered valid, or why it makes > sense to generate such files? > > Thanks, > Marton > As far as I can tell, the file that a user provided with this problem was generated by an encoder (running FFmpeg 3.4) that started writing zero-sized samples when their video switcher + capture card stopped receiving audio input. I'm not arguing that it's good for files to be generated like this, but it's nice for FFmpeg to be able to process them all the same (i.e. the robustness principle). With this patch reverted, FFmpeg can accept an input file that is partially broken (with playback anomalies due to the presence of zero-sized samples) and produce a valid, working output mp4 (or DASH stream), just like it could in release 5.0 and older. One of the best things about FFmpeg is that it can fix invalid container metadata. I feel like losing that capability for this scenario is a regression. Thanks, Chris _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".