Re: [FFmpeg-devel] [PATCH v3] avformat/whip: mark as experimental

[Tristan Matthews <tmatth@videolan.org>]

Hi,

On Mon, Jun 9, 2025 at 9:47 AM Jack Lau
<jacklau1222gm-at-gmail.com@ffmpeg.org> wrote:
>
>
>
> > On Jun 9, 2025, at 21:19, Tristan Matthews <tmatth@videolan.org> wrote:
> >
> > Hi,
> >
> >
> > On Mon, Jun 9, 2025 at 6:25 AM Jack Lau via ffmpeg-devel
> > <ffmpeg-devel@ffmpeg.org> wrote:
> >>
> >>
> >>
> >>
> >> ---------- Forwarded message ----------
> >> From: Jack Lau <jacklau1222@qq.com>
> >> To: ffmpeg-devel@ffmpeg.org
> >> Cc: Jack Lau <jacklau1222@qq.com>
> >> Bcc:
> >> Date: Mon,  9 Jun 2025 18:24:46 +0800
> >> Subject: [PATCH v3] avformat/whip: mark as experimental
> >> Signed-off-by: Jack Lau <jacklau1222@qq.com>
> >> ---
> >> libavformat/whip.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/libavformat/whip.c b/libavformat/whip.c
> >> index 710f24fc5a..bb7b8657dc 100644
> >> --- a/libavformat/whip.c
> >> +++ b/libavformat/whip.c
> >> @@ -1907,7 +1907,7 @@ const FFOutputFormat ff_whip_muxer = {
> >>     .p.long_name        = NULL_IF_CONFIG_SMALL("WHIP(WebRTC-HTTP ingestion protocol) muxer"),
> >>     .p.audio_codec      = AV_CODEC_ID_OPUS,
> >>     .p.video_codec      = AV_CODEC_ID_H264,
> >> -    .p.flags            = AVFMT_GLOBALHEADER | AVFMT_NOFILE,
> >> +    .p.flags            = AVFMT_GLOBALHEADER | AVFMT_NOFILE | AVFMT_EXPERIMENTAL,
> >>     .p.priv_class       = &whip_muxer_class,
> >>     .priv_data_size     = sizeof(WHIPContext),
> >>     .init               = whip_init,
> >> --
> >> 2.49.0
> >>
> >
> > You may want to update the intended usage example in doc/muxers.texi
> > to include the `experimental` flag (probably in a separate patch).
> Thanks for the reminder!
> I’ve sent the separate patch in https://patchwork.ffmpeg.org/project/ffmpeg/patch/mailman.2674.1749476775.1384.ffmpeg-devel@ffmpeg.org/
> >

I was talking about the ffmpeg one-liner usage example specifically, here:
https://git.ffmpeg.org/gitweb/ffmpeg.git/blob/refs/heads/master:/doc/muxers.texi#l3896

Best,
-t
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".