Re: [FFmpeg-devel] [PATCH v10 0/6] Support enhanced flv in FFmpeg

[Tristan Matthews <tmatth@videolan.org>]

On Wed, Jun 7, 2023 at 8:02 PM Neal Gompa <ngompa13@gmail.com> wrote:
>
> On Tue, Jun 6, 2023 at 2:43 AM Steven Liu <lingjiujianke@gmail.com> wrote:
> >
> > Neal Gompa <ngompa13@gmail.com> 于2023年5月31日周三 13:47写道：
> > >
> > > On Mon, May 15, 2023 at 10:41 PM Neal Gompa <ngompa13@gmail.com> wrote:
> > > >
> > > > On Mon, May 15, 2023 at 4:32 AM Steven Liu <lq@chinaffmpeg.org> wrote:
> > > > >
> > > > > Reference file: https://github.com/veovera/enhanced-rtmp/blob/main/enhanced-rtmp-v1.pdf
> > > > > The Enhanced flv has been supported by OBS, Simple Realtime Server, mpegts.js.
> > > > > you can publish hevc, av1 or vp9 codec stream to Youtube over rtmp.
> > > > > The enhanced flv documentation contributors include
> > > > > Jean-Baptiste Kempf (FFmpeg, VideoLAN).
> > > > > So this should be support by ffmpeg too.
> > > > >
> > > > > v8:
> > > > >     Support vp9 codec according to enhanced flv.
> > > > >     Support PacketTypeCodedFrames type for hevc in flv.
> > > > > v9:
> > > > >     Add dependency codec object files for flvenc in Makefile.
> > > > >     Move the hevc,av1,vp9 codec out of FF_COMPLIANCE_UNOFFICIAL.
> > > > >
> > > > > v10:
> > > > >     modify first patch comment like the others before commit.
> > > > >     exheader mode should only happened in video stream this patchset.
> > > > >
> > > > > Steven Liu (6):
> > > > >   avformat/flvenc: support mux hevc in enhanced flv
> > > > >   avformat/flvdec: support demux hevc in enhanced flv
> > > > >   avformat/flvenc: support mux av1 in enhanced flv
> > > > >   avformat/flvdec: support demux av1 in enhanced flv
> > > > >   avformat/flvenc: support mux vp9 in enhanced flv
> > > > >   avformat/flvdec: support demux vp9 in enhanced flv
> > > > >
> > > > >  libavformat/Makefile |  2 +-
> > > > >  libavformat/flv.h    | 15 +++++++++
> > > > >  libavformat/flvdec.c | 73 +++++++++++++++++++++++++++++++++++++++-----
> > > > >  libavformat/flvenc.c | 58 +++++++++++++++++++++++++++++------
> > > > >  4 files changed, 130 insertions(+), 18 deletions(-)
> > > > >
> > > >
> > > > This version works for me. Thanks for this work!
> > > >
> > > > Tested-by: Neal Gompa <ngompa13@gmail.com>
> > > > Reviewed-by: Neal Gompa <ngompa13@gmail.com>
> > > >
> > >
> > > Is this patch set going to get pushed to master anytime soon?
> >
> > Hi Neal,
> >
> >     Do you agree move the enhanced flv support into experimental flags?
> >
>
> I don't think we should mark it experimental. Aside from the fact that
> other implementations haven't done that, it's in production now with
> YouTube.
>

Just wanted to add that v11 also worked for me (successfully tested
pushing RTMP 720p and 1080p AV1 from a live source, tried VP9 but
YouTube doesn't seem to support it as ingest). I can also confirm what
Steven reported that YouTube will output VP9 or AVC given AV1 RTMP
(from the "Stats for nerds" menu).

Great work!

Tested-by: Tristan Matthews <tmatth@videolan.org>
Reviewed-by: Tristan Matthews <tmatth@videolan.org>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".