From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A0E8142C16 for ; Fri, 30 Sep 2022 13:54:12 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 084DE68BBA3; Fri, 30 Sep 2022 16:54:09 +0300 (EEST) Received: from mail-qv1-f51.google.com (mail-qv1-f51.google.com [209.85.219.51]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9B1AE68A867 for ; Fri, 30 Sep 2022 16:54:02 +0300 (EEST) Received: by mail-qv1-f51.google.com with SMTP id l14so2818373qvq.8 for ; Fri, 30 Sep 2022 06:54:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date; bh=xpPFfdRDZZL3hI0mmxtHukZKl0h3KAux4vf1oiaNuos=; b=b/HnAnOqFteqkEsxrDw3JCJx0BEuxoV5FPoRdCulg7Y/R4vmRJRmbEGmCwTn7f8Oyi JWGp7uFP/cCW2ewRFDY5+HeKQV/doPw14E6PqQpoQjNyVK6oJe40jwA2SAxTyLiTAF0Z T/2mox2XBQjBe7zHrU50AVfan9jmvyDj62LghV6lXmKsoIhmUQR+5enQexGW54xXKeuK XCFNoDN4iIpv4qsVaYRxBP3mrMAJvH+ttIHURukeYZOjtfitwzh+nd+TzcGM92FSE9P3 +6WZkWnC6pD1kEK6oiA43EmAz3s+PcWrK7eZo8Zcac3SqGzYILxOyHaxH01Ra04vW1Pm TMFg== X-Gm-Message-State: ACrzQf33PptcTyX53p+FsL3m3N4WOFVqyWVI+323Oz6ukayhLGrBIksf NqdPpDg9kx+3dqSyUBP7nEAfD+WZy0vlKw== X-Google-Smtp-Source: AMsMyM64LX9u8Mngu2FAv3jFeLVAYDyQ7Gp2dSn8UtsspMSHpZZLgCYWaMvONRH5t34PA+902xOzVg== X-Received: by 2002:a05:6214:d62:b0:4af:9655:521b with SMTP id 2-20020a0562140d6200b004af9655521bmr6789231qvs.28.1664546041106; Fri, 30 Sep 2022 06:54:01 -0700 (PDT) Received: from mail-yb1-f182.google.com (mail-yb1-f182.google.com. [209.85.219.182]) by smtp.gmail.com with ESMTPSA id p3-20020a05622a00c300b0035d0a021dcasm2048166qtw.63.2022.09.30.06.53.59 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Sep 2022 06:54:00 -0700 (PDT) Received: by mail-yb1-f182.google.com with SMTP id s14so5362396ybe.7 for ; Fri, 30 Sep 2022 06:53:59 -0700 (PDT) X-Received: by 2002:a5b:443:0:b0:6bc:e3d1:8990 with SMTP id s3-20020a5b0443000000b006bce3d18990mr4381692ybp.191.1664546039414; Fri, 30 Sep 2022 06:53:59 -0700 (PDT) MIME-Version: 1.0 References: <20220831183207.2703227-1-tmatth@videolan.org> <20220908195737.1618147-1-tmatth@videolan.org> In-Reply-To: From: Tristan Matthews Date: Fri, 30 Sep 2022 09:53:48 -0400 X-Gmail-Original-Message-ID: Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 1/1] fate/opus: add silk LBRR test (refs #9890) X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, Sep 23, 2022 at 3:04 PM Tristan Matthews wrote: > > On Fri, Sep 23, 2022 at 8:15 AM Andreas Rheinhardt > wrote: > > > > Tristan Matthews: > > > On Thu, Sep 8, 2022 at 3:58 PM Tristan Matthews wrote: > > > > > >> This adds a fate test for a sample with LBRR packets. > > >> > > >> It requires that these files be uploaded: > > >> https://people.videolan.org/~tmatth/9890-fate/silk-lbrr.mka > > >> https://people.videolan.org/~tmatth/9890-fate/silk-lbrr.dec > > >> > > >> --- > > >> tests/fate/opus.mak | 3 ++- > > >> 1 file changed, 2 insertions(+), 1 deletion(-) > > >> > > >> diff --git a/tests/fate/opus.mak b/tests/fate/opus.mak > > >> index 573044ed15..7d359f414a 100644 > > >> --- a/tests/fate/opus.mak > > >> +++ b/tests/fate/opus.mak > > >> @@ -4,7 +4,7 @@ > > >> > > >> OPUS_CELT_SAMPLES = $(addprefix testvector, 01 11) tron.6ch.tinypkts > > >> OPUS_HYBRID_SAMPLES = $(addprefix testvector, 05 06) > > >> -OPUS_SILK_SAMPLES = $(addprefix testvector, 02 03 04) > > >> +OPUS_SILK_SAMPLES = $(addprefix testvector, 02 03 04) silk-lbrr > > >> OPUS_OTHER_SAMPLES = $(addprefix testvector, 07 08 09 10 12) > > >> > > >> define FATE_OPUS_TEST > > >> @@ -33,6 +33,7 @@ fate-opus-testvector09: CMP_TARGET = 0 > > >> fate-opus-testvector10: CMP_TARGET = 38 > > >> fate-opus-testvector11: CMP_TARGET = 0 > > >> fate-opus-testvector12: CMP_TARGET = 160 > > >> +fate-opus-silk-lbrr: CMP_TARGET = 0 > > >> fate-opus-tron.6ch.tinypkts: CMP_SHIFT = 1440 > > >> fate-opus-tron.6ch.tinypkts: CMP_TARGET = 0 > > >> > > >> -- > > >> 2.34.1 > > >> > > > > > > > > > Sorry this was supposed to be in response to > > > http://ffmpeg.org/pipermail/ffmpeg-devel/2022-August/300758.html (as it > > > depends on it) but I screwed up the git-send-email. > > > > > > > Does this sample have to be so long? > > I've shortened it from 4 seconds to 1 second (which is still long > enough to hear the bug when using an older build). > Note that most of the opus test vectors are on the order of 25 seconds. These shorter samples have been updated by James Almer, so this patch is good to go Best, -t > > Best, > Tristan > > > > > - Andreas > > _______________________________________________ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > To unsubscribe, visit link above, or email > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".