From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 930D7429F9 for ; Mon, 11 Apr 2022 15:49:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CE8E968B266; Mon, 11 Apr 2022 18:49:15 +0300 (EEST) Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 00C1168AE71 for ; Mon, 11 Apr 2022 18:49:08 +0300 (EEST) Received: by mail-qt1-f181.google.com with SMTP id ay4so696621qtb.11 for ; Mon, 11 Apr 2022 08:49:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=3T1Ho6g9AIKOUgy6+rs+PRfJNlIhWqseaPJN5hcuQk8=; b=dmMYPf+pE7cw+gcsTWDI0iqxnkYYuNZs7qvVtK1XS3Slf09rVewSd7aOhkO9fhQ5JU KVQ7N3Z0SVxSnhYz2j9t3J+vbpIi8HST9onX7wbgSovgWBBoPbDs+v25bja+XiwjH865 RkMGofmYfHY/iJ3hLx0PwO/kzypNcIczF4hLGWyyFmxh1Y8zjhNcQKQfNtBKWmpeXhe4 LsaRESCyVNdK4TlYDsj+7bzhfNHNIVW+A3zykvU9oJRglfKWxrhBtuVNE5M32h4y3RcP urTrS22KsPMsjv3qSmMquxfIV2oJL1YvzI+HlNws0QG9MPNuG+CUigNH3l4hRXgxrt+C aYZQ== X-Gm-Message-State: AOAM533BxQYMFy66p63XC2yP2qOjHni//CxcRcng+S8IY9+d60pt81zM mYG+Fh/wlh9RCHJcqxKNcBnjlchyWyqSHA== X-Google-Smtp-Source: ABdhPJzjcGBvFiQ+s3vTt67aIB53GCj1OSSvRFaK7znDN82hOh2LdT9J879p//wv5QSLsjKWVan/QA== X-Received: by 2002:ac8:44c1:0:b0:2ed:f66:804a with SMTP id b1-20020ac844c1000000b002ed0f66804amr9026470qto.102.1649692147487; Mon, 11 Apr 2022 08:49:07 -0700 (PDT) Received: from mail-yw1-f169.google.com (mail-yw1-f169.google.com. [209.85.128.169]) by smtp.gmail.com with ESMTPSA id g21-20020ac85815000000b002e06e2623a7sm24241078qtg.0.2022.04.11.08.49.07 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Apr 2022 08:49:07 -0700 (PDT) Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-2ec05db3dfbso49284627b3.7 for ; Mon, 11 Apr 2022 08:49:07 -0700 (PDT) X-Received: by 2002:a81:6284:0:b0:2ec:4997:608d with SMTP id w126-20020a816284000000b002ec4997608dmr1857498ywb.201.1649692146721; Mon, 11 Apr 2022 08:49:06 -0700 (PDT) MIME-Version: 1.0 References: <20220406051146.1701100-1-tmatth@videolan.org> In-Reply-To: From: Tristan Matthews Date: Mon, 11 Apr 2022 11:48:55 -0400 X-Gmail-Original-Message-ID: Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH 1/1] librtmp: make flashVer case consistent X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sat, Apr 9, 2022 at 2:45 PM Marton Balint wrote: > > > On Wed, 6 Apr 2022, Tristan Matthews wrote: > > > This is basically a cosmetic change (no functional difference). > > > > --- > > libavformat/librtmp.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavformat/librtmp.c b/libavformat/librtmp.c > > index 43013e46e0..b23adb9593 100644 > > --- a/libavformat/librtmp.c > > +++ b/libavformat/librtmp.c > > @@ -115,7 +115,7 @@ static int rtmp_open(URLContext *s, const char *uri, > int flags) > > if (ctx->app) len += strlen(ctx->app) + sizeof(" app="); > > if (ctx->tcurl) len += strlen(ctx->tcurl) + sizeof(" tcUrl="); > > if (ctx->pageurl) len += strlen(ctx->pageurl) + sizeof(" > pageUrl="); > > - if (ctx->flashver) len += strlen(ctx->flashver) + sizeof(" > flashver="); > > + if (ctx->flashver) len += strlen(ctx->flashver) + sizeof(" > flashVer="); > > Actually this whole rtmp_open function should be reworked to use an > AVBPrint buffer to generate the rtmp URL. The way it works now - > calculating the length first then creating the actual sting - is > very ugly. > > Oh yeah good call, I will follow up with that instead. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".