From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2932343A41 for ; Wed, 6 Jul 2022 14:18:00 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1660568BA7B; Wed, 6 Jul 2022 17:17:58 +0300 (EEST) Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3F34C68BA07 for ; Wed, 6 Jul 2022 17:17:51 +0300 (EEST) Received: by mail-qt1-f172.google.com with SMTP id ay10so18359651qtb.1 for ; Wed, 06 Jul 2022 07:17:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=6EDZRjwozYi7wBqbRJDfpTrZnB3SvV52aD6SvsBZU5A=; b=E4Nmrwo/uZ92XadjtO/Y9YuUWAwQOGm4rTBUnKZcw3ZACy7Rk4bL8G4pt64pd4Cw62 fsscE1VmCakucjroRvP+p07IUCTNLUJCJNvTvvAF6241KCqrHBsKqeI2Cuza/s64mJIW VWftwzcYFCp11FT0g8Q3j0tQ2h13MPPB+oYg6EpB0a0UovVeNxvoxLqR8VkqugU2ZtQ7 yauN/HpxS9rSmsMLyKDKyvu3t4PEGdQuU40v+G1vNOJfcV0au+FVtpXA0Lti2tWqMu1U y+Jw88gbPEgFW64WC0Tsa5GJZKjdUJYgEZ1oeTmnTQFRN6MEKNMVWr1LBROn9wJIgUH5 +0bw== X-Gm-Message-State: AJIora/VJyojv1WxtcJ+VYE3E3xOrSzhzlZtbnGR+jphqeCKf8tRfOeA rQvSHIr+dLhafomKOT54ckZ0kh54PVI= X-Google-Smtp-Source: AGRyM1vpQ9DbMRJwI9+7FZD569k//YL5x/RFgHK5KgBFxXUXUkkrYqZRYEScQKBCUT90wMtl4cy6yw== X-Received: by 2002:a05:622a:1044:b0:317:b713:19d8 with SMTP id f4-20020a05622a104400b00317b71319d8mr33910445qte.582.1657117069741; Wed, 06 Jul 2022 07:17:49 -0700 (PDT) Received: from mail-yb1-f169.google.com (mail-yb1-f169.google.com. [209.85.219.169]) by smtp.gmail.com with ESMTPSA id s10-20020a05620a29ca00b006a79479657fsm22140035qkp.108.2022.07.06.07.17.49 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Jul 2022 07:17:49 -0700 (PDT) Received: by mail-yb1-f169.google.com with SMTP id o2so22291004yba.7 for ; Wed, 06 Jul 2022 07:17:49 -0700 (PDT) X-Received: by 2002:a25:3207:0:b0:66e:5551:ed09 with SMTP id y7-20020a253207000000b0066e5551ed09mr15219429yby.463.1657117069333; Wed, 06 Jul 2022 07:17:49 -0700 (PDT) MIME-Version: 1.0 References: <1f89dadc-2a60-4b1d-a645-3f8fbf06f48e@www.fastmail.com> <468e39f9-3096-6599-daae-13c693ea6432@gmail.com> <78fd4693-215b-4f17-902a-e0561eda250d@www.fastmail.com> In-Reply-To: From: Tristan Matthews Date: Wed, 6 Jul 2022 10:17:38 -0400 X-Gmail-Original-Message-ID: Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] Patch to libavc/opus to create extradata if missing X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, Jul 6, 2022 at 10:10 AM Tristan Matthews wrote: > Hi, > > On Sun, Jan 3, 2021 at 8:09 PM Andreas Rheinhardt < > andreas.rheinhardt@gmail.com> wrote: > >> Jonathan Baudanza: >> > On Sun, Jan 3, 2021, at 3:34 PM, Andreas Rheinhardt wrote: >> >> Lynne: >> >>> >> >>> Apart from that LGTM. >> >> >> >> +1 if the case of more than two channels has been properly tested. >> >> >> > >> > I tested this by creating an (invalid) SDP file with channels set to 3. >> In this case, the rtp demuxer fails with the following message: >> > >> > [sdp @ 0x7fe40280b800] Error creating opus extradata: Invalid data >> found when processing input >> > >> > It might be more descriptive if we added a log warning about the >> channel count. WDYT? >> >> It's ok as-is. >> >> - Andreas >> > > Could this land? I found another case that it fixes (specifically > streamcopy + muxing a specific mkv file that was captured via RTP). > Sorry for the noise, I missed in the thread that the code in question moved from the opus decoder to the RTP parser and landed there. Best, Tristan _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".