* [FFmpeg-devel] [PATCH 1/2] doc/examples/filter_audio: use av_err2str
@ 2025-05-22 16:57 Tristan Matthews
2025-05-22 16:57 ` [FFmpeg-devel] [PATCH 2/2] doc/examples/qsv_decode: " Tristan Matthews
2025-05-22 17:42 ` [FFmpeg-devel] [PATCH 1/2] doc/examples/filter_audio: " Marvin Scholz
0 siblings, 2 replies; 4+ messages in thread
From: Tristan Matthews @ 2025-05-22 16:57 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Tristan Matthews
---
doc/examples/filter_audio.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/doc/examples/filter_audio.c b/doc/examples/filter_audio.c
index 8b237e2adf..02222f5914 100644
--- a/doc/examples/filter_audio.c
+++ b/doc/examples/filter_audio.c
@@ -270,7 +270,6 @@ int main(int argc, char *argv[])
AVFilterGraph *graph;
AVFilterContext *src, *sink;
AVFrame *frame;
- uint8_t errstr[1024];
float duration;
int err, nb_frames, i;
@@ -354,7 +353,6 @@ int main(int argc, char *argv[])
return 0;
fail:
- av_strerror(err, errstr, sizeof(errstr));
- fprintf(stderr, "%s\n", errstr);
+ fprintf(stderr, "%s\n", av_err2str(err));
return 1;
}
--
2.45.2
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
* [FFmpeg-devel] [PATCH 2/2] doc/examples/qsv_decode: use av_err2str
2025-05-22 16:57 [FFmpeg-devel] [PATCH 1/2] doc/examples/filter_audio: use av_err2str Tristan Matthews
@ 2025-05-22 16:57 ` Tristan Matthews
2025-05-22 17:42 ` [FFmpeg-devel] [PATCH 1/2] doc/examples/filter_audio: " Marvin Scholz
1 sibling, 0 replies; 4+ messages in thread
From: Tristan Matthews @ 2025-05-22 16:57 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Tristan Matthews
---
doc/examples/qsv_decode.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/doc/examples/qsv_decode.c b/doc/examples/qsv_decode.c
index 5a6f3625aa..ec91109480 100644
--- a/doc/examples/qsv_decode.c
+++ b/doc/examples/qsv_decode.c
@@ -219,11 +219,8 @@ int main(int argc, char **argv)
ret = decode_packet(decoder_ctx, frame, sw_frame, NULL, output_ctx);
finish:
- if (ret < 0) {
- char buf[1024];
- av_strerror(ret, buf, sizeof(buf));
- fprintf(stderr, "%s\n", buf);
- }
+ if (ret < 0)
+ fprintf(stderr, "%s\n", av_err2str(ret));
avformat_close_input(&input_ctx);
--
2.45.2
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [FFmpeg-devel] [PATCH 1/2] doc/examples/filter_audio: use av_err2str
2025-05-22 16:57 [FFmpeg-devel] [PATCH 1/2] doc/examples/filter_audio: use av_err2str Tristan Matthews
2025-05-22 16:57 ` [FFmpeg-devel] [PATCH 2/2] doc/examples/qsv_decode: " Tristan Matthews
@ 2025-05-22 17:42 ` Marvin Scholz
2025-05-22 18:20 ` Tristan Matthews
1 sibling, 1 reply; 4+ messages in thread
From: Marvin Scholz @ 2025-05-22 17:42 UTC (permalink / raw)
To: FFmpeg development discussions and patches
On 22 May 2025, at 18:57, Tristan Matthews wrote:
> ---
> doc/examples/filter_audio.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/doc/examples/filter_audio.c b/doc/examples/filter_audio.c
> index 8b237e2adf..02222f5914 100644
> --- a/doc/examples/filter_audio.c
> +++ b/doc/examples/filter_audio.c
> @@ -270,7 +270,6 @@ int main(int argc, char *argv[])
> AVFilterGraph *graph;
> AVFilterContext *src, *sink;
> AVFrame *frame;
> - uint8_t errstr[1024];
> float duration;
> int err, nb_frames, i;
>
> @@ -354,7 +353,6 @@ int main(int argc, char *argv[])
> return 0;
>
> fail:
> - av_strerror(err, errstr, sizeof(errstr));
> - fprintf(stderr, "%s\n", errstr);
> + fprintf(stderr, "%s\n", av_err2str(err));
> return 1;
> }
> --
> 2.45.2
Patchset LGTM
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [FFmpeg-devel] [PATCH 1/2] doc/examples/filter_audio: use av_err2str
2025-05-22 17:42 ` [FFmpeg-devel] [PATCH 1/2] doc/examples/filter_audio: " Marvin Scholz
@ 2025-05-22 18:20 ` Tristan Matthews
0 siblings, 0 replies; 4+ messages in thread
From: Tristan Matthews @ 2025-05-22 18:20 UTC (permalink / raw)
To: FFmpeg development discussions and patches
On Thu, May 22, 2025 at 1:42 PM Marvin Scholz <epirat07@gmail.com> wrote:
>
> On 22 May 2025, at 18:57, Tristan Matthews wrote:
>
> > ---
> > doc/examples/filter_audio.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/doc/examples/filter_audio.c b/doc/examples/filter_audio.c
> > index 8b237e2adf..02222f5914 100644
> > --- a/doc/examples/filter_audio.c
> > +++ b/doc/examples/filter_audio.c
> > @@ -270,7 +270,6 @@ int main(int argc, char *argv[])
> > AVFilterGraph *graph;
> > AVFilterContext *src, *sink;
> > AVFrame *frame;
> > - uint8_t errstr[1024];
> > float duration;
> > int err, nb_frames, i;
> >
> > @@ -354,7 +353,6 @@ int main(int argc, char *argv[])
> > return 0;
> >
> > fail:
> > - av_strerror(err, errstr, sizeof(errstr));
> > - fprintf(stderr, "%s\n", errstr);
> > + fprintf(stderr, "%s\n", av_err2str(err));
> > return 1;
> > }
> > --
> > 2.45.2
>
> Patchset LGTM
Thanks, BTW thanks to your earlier patches that did the same, after
this there will no longer be any calls to av_strerror in the codebase
(aside from being called by av_err2str).
Best,
Tristan
>
> >
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-05-22 18:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-05-22 16:57 [FFmpeg-devel] [PATCH 1/2] doc/examples/filter_audio: use av_err2str Tristan Matthews
2025-05-22 16:57 ` [FFmpeg-devel] [PATCH 2/2] doc/examples/qsv_decode: " Tristan Matthews
2025-05-22 17:42 ` [FFmpeg-devel] [PATCH 1/2] doc/examples/filter_audio: " Marvin Scholz
2025-05-22 18:20 ` Tristan Matthews
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git