From: Tristan Matthews <tmatth@videolan.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/2] doc/examples/filter_audio: use av_err2str
Date: Thu, 22 May 2025 14:20:35 -0400
Message-ID: <CAN8HRD=sKPaS4ajUL4CgkMxtMceFF9BXxw3OgKTgRxKbUaaHWA@mail.gmail.com> (raw)
In-Reply-To: <E03D8FC0-B02E-4805-B0DC-2CFEE0F9D96E@gmail.com>
On Thu, May 22, 2025 at 1:42 PM Marvin Scholz <epirat07@gmail.com> wrote:
>
> On 22 May 2025, at 18:57, Tristan Matthews wrote:
>
> > ---
> > doc/examples/filter_audio.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/doc/examples/filter_audio.c b/doc/examples/filter_audio.c
> > index 8b237e2adf..02222f5914 100644
> > --- a/doc/examples/filter_audio.c
> > +++ b/doc/examples/filter_audio.c
> > @@ -270,7 +270,6 @@ int main(int argc, char *argv[])
> > AVFilterGraph *graph;
> > AVFilterContext *src, *sink;
> > AVFrame *frame;
> > - uint8_t errstr[1024];
> > float duration;
> > int err, nb_frames, i;
> >
> > @@ -354,7 +353,6 @@ int main(int argc, char *argv[])
> > return 0;
> >
> > fail:
> > - av_strerror(err, errstr, sizeof(errstr));
> > - fprintf(stderr, "%s\n", errstr);
> > + fprintf(stderr, "%s\n", av_err2str(err));
> > return 1;
> > }
> > --
> > 2.45.2
>
> Patchset LGTM
Thanks, BTW thanks to your earlier patches that did the same, after
this there will no longer be any calls to av_strerror in the codebase
(aside from being called by av_err2str).
Best,
Tristan
>
> >
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2025-05-22 18:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-22 16:57 Tristan Matthews
2025-05-22 16:57 ` [FFmpeg-devel] [PATCH 2/2] doc/examples/qsv_decode: " Tristan Matthews
2025-05-22 17:42 ` [FFmpeg-devel] [PATCH 1/2] doc/examples/filter_audio: " Marvin Scholz
2025-05-22 18:20 ` Tristan Matthews [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAN8HRD=sKPaS4ajUL4CgkMxtMceFF9BXxw3OgKTgRxKbUaaHWA@mail.gmail.com' \
--to=tmatth@videolan.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git