From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0F75643A48 for ; Wed, 6 Jul 2022 14:11:15 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 796C268BA78; Wed, 6 Jul 2022 17:11:11 +0300 (EEST) Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 827BB68B2F5 for ; Wed, 6 Jul 2022 17:11:04 +0300 (EEST) Received: by mail-qt1-f181.google.com with SMTP id q16so18335514qtn.5 for ; Wed, 06 Jul 2022 07:11:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=VtAp3u683XkbPMbX/8PasXuAzfZakTiXPWQ/pXzhLWY=; b=a3G/Jca8eD8DPnoouhdb6bKaLCf00WK+TfxFdkRa2PW1dkGZZmbfNd7oCFgwbiMo8y lMexjkLZhEh19PutLjY9bBPiY1nbgQs7HP/+L9PRU8iRqZq2bE3ODUk3MJo/gQ58HXtk alSYG8Ea1nY6TO2Jq3DzaC63M+ZJTtPOapVqyQmHjqlDubJwylhAKvtJrDT4zEEpsgxQ wojibH9/03CrbVnl0GQk2hXL0j5bDAQco21kdP5GNbYKKa09GsF+0V4EXdA4DM03XENG wD9e/rvmI+4quHvw/OYjV9h0fDA073pVwNUhPpMhBD6gABAmWfd2Zp/oi5jFQF6x/aS6 HN0Q== X-Gm-Message-State: AJIora9aOLnVb4N/7IdiQbUI7kv86GamZrLT5BiDK/g8tq5FGUtNyrmM 7NmvIRUn5W8KEBruanIuTKmDfyWRc04= X-Google-Smtp-Source: AGRyM1vHcR64/1XPFg4TR+r//oI4rMFOhsWLoUcUH67O1lj50liDVEJwhb5K0Ja664meG+xbiVNVRw== X-Received: by 2002:ac8:5b51:0:b0:317:3513:cf60 with SMTP id n17-20020ac85b51000000b003173513cf60mr33243584qtw.495.1657116662867; Wed, 06 Jul 2022 07:11:02 -0700 (PDT) Received: from mail-yb1-f176.google.com (mail-yb1-f176.google.com. [209.85.219.176]) by smtp.gmail.com with ESMTPSA id ay4-20020a05622a228400b002f39b99f69csm23503275qtb.54.2022.07.06.07.11.02 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Jul 2022 07:11:02 -0700 (PDT) Received: by mail-yb1-f176.google.com with SMTP id b85so14275571yba.8 for ; Wed, 06 Jul 2022 07:11:02 -0700 (PDT) X-Received: by 2002:a05:6902:84:b0:63d:4a3d:eb5 with SMTP id h4-20020a056902008400b0063d4a3d0eb5mr43033621ybs.145.1657116662171; Wed, 06 Jul 2022 07:11:02 -0700 (PDT) MIME-Version: 1.0 References: <1f89dadc-2a60-4b1d-a645-3f8fbf06f48e@www.fastmail.com> <468e39f9-3096-6599-daae-13c693ea6432@gmail.com> <78fd4693-215b-4f17-902a-e0561eda250d@www.fastmail.com> In-Reply-To: From: Tristan Matthews Date: Wed, 6 Jul 2022 10:10:51 -0400 X-Gmail-Original-Message-ID: Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] Patch to libavc/opus to create extradata if missing X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Hi, On Sun, Jan 3, 2021 at 8:09 PM Andreas Rheinhardt < andreas.rheinhardt@gmail.com> wrote: > Jonathan Baudanza: > > On Sun, Jan 3, 2021, at 3:34 PM, Andreas Rheinhardt wrote: > >> Lynne: > >>> > >>> Apart from that LGTM. > >> > >> +1 if the case of more than two channels has been properly tested. > >> > > > > I tested this by creating an (invalid) SDP file with channels set to 3. > In this case, the rtp demuxer fails with the following message: > > > > [sdp @ 0x7fe40280b800] Error creating opus extradata: Invalid data > found when processing input > > > > It might be more descriptive if we added a log warning about the channel > count. WDYT? > > It's ok as-is. > > - Andreas > Could this land? I found another case that it fixes (specifically streamcopy + muxing a specific mkv file that was captured via RTP). Best, Tristan _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".