From: Tristan Matthews <tmatth@videolan.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] Patch to libavc/opus to create extradata if missing
Date: Wed, 6 Jul 2022 10:10:51 -0400
Message-ID: <CAN8HRD=_JvWNqDpVxQELKj5RxDWadvris0jmn0NZZt7Ot0SWbw@mail.gmail.com> (raw)
In-Reply-To: <da0b7c2a-6775-d140-c97e-576441f3cf1a@gmail.com>
Hi,
On Sun, Jan 3, 2021 at 8:09 PM Andreas Rheinhardt <
andreas.rheinhardt@gmail.com> wrote:
> Jonathan Baudanza:
> > On Sun, Jan 3, 2021, at 3:34 PM, Andreas Rheinhardt wrote:
> >> Lynne:
> >>>
> >>> Apart from that LGTM.
> >>
> >> +1 if the case of more than two channels has been properly tested.
> >>
> >
> > I tested this by creating an (invalid) SDP file with channels set to 3.
> In this case, the rtp demuxer fails with the following message:
> >
> > [sdp @ 0x7fe40280b800] Error creating opus extradata: Invalid data
> found when processing input
> >
> > It might be more descriptive if we added a log warning about the channel
> count. WDYT?
>
> It's ok as-is.
>
> - Andreas
>
Could this land? I found another case that it fixes (specifically
streamcopy + muxing a specific mkv file that was captured via RTP).
Best,
Tristan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next parent reply other threads:[~2022-07-06 14:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <ef7ac4ac-1fd9-427f-8358-e47a34151057@www.fastmail.com>
[not found] ` <MPiwUjZ--3-2@lynne.ee>
[not found] ` <1f89dadc-2a60-4b1d-a645-3f8fbf06f48e@www.fastmail.com>
[not found] ` <f0f47a17-520e-4dac-b9da-b9430aafa0b6@www.fastmail.com>
[not found] ` <468e39f9-3096-6599-daae-13c693ea6432@gmail.com>
[not found] ` <ceae07d4-9da5-4f43-941b-b6f8aeac2d17@www.fastmail.com>
[not found] ` <d0114b98-0ae3-ed0d-a894-505901a49b5d@gmail.com>
[not found] ` <78fd4693-215b-4f17-902a-e0561eda250d@www.fastmail.com>
[not found] ` <MQ9LiXS--3-2@lynne.ee>
[not found] ` <ffd8d02f-f864-46df-b4fd-0ac51065f9f2@www.fastmail.com>
[not found] ` <MQ9UqET--3-2@lynne.ee>
[not found] ` <c37cb0ec-8e11-5df0-fe5d-083241d49f46@gmail.com>
[not found] ` <c601cb18-38e4-42d9-b36b-3b5e12e800d1@www.fastmail.com>
[not found] ` <da0b7c2a-6775-d140-c97e-576441f3cf1a@gmail.com>
2022-07-06 14:10 ` Tristan Matthews [this message]
2022-07-06 14:17 ` Tristan Matthews
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAN8HRD=_JvWNqDpVxQELKj5RxDWadvris0jmn0NZZt7Ot0SWbw@mail.gmail.com' \
--to=tmatth@videolan.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git