Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Tristan Matthews via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: tmatth <code@ffmpeg.org>, Tristan Matthews <tmatth@videolan.org>
Subject: [FFmpeg-devel] Re: [PATCH] rvv: add optimized h264 intra prediction functions (PR #20494)
Date: Thu, 11 Sep 2025 14:17:33 -0400
Message-ID: <CAN8HRD=Vjsg6SDJZxv_p0bva2wWFgFSor9TBxqh4G8vYAZMcYg@mail.gmail.com> (raw)
In-Reply-To: <175761164805.25.15246734965513426351@463a07221176>

On Thu, Sep 11, 2025 at 1:29 PM tmatth via ffmpeg-devel
<ffmpeg-devel@ffmpeg.org> wrote:
>
> PR #20494 opened by tmatth
>
> +endfunc
> diff --git a/tests/checkasm/h264pred.c b/tests/checkasm/h264pred.c
> index 53e1cdb219..7254854534 100644
> --- a/tests/checkasm/h264pred.c
> +++ b/tests/checkasm/h264pred.c
> @@ -172,8 +172,15 @@ static void check_pred8x8(H264PredContext *h, uint8_t *buf0, uint8_t *buf1,
>              randomize_buffers();
>              call_ref(src0, 24*SIZEOF_PIXEL);
>              call_new(src1, 24*SIZEOF_PIXEL);
> -            if (memcmp(buf0, buf1, BUF_SIZE))
> +            if (memcmp(buf0, buf1, BUF_SIZE)) {
> +                fprintf(stderr, "REF:\n");
> +                for (int i = 0; i < BUF_SIZE; i++)
> +                    fprintf(stderr, "%d\t", buf0[i]);
> +                fprintf(stderr, "\nASM:\n");
> +                for (int i = 0; i < BUF_SIZE; i++)
> +                    fprintf(stderr, "%d\t", buf1[i]);
>                  fail();
> +            }
>              bench_new(src1, 24*SIZEOF_PIXEL);
>          }
>      }
> --
> 2.49.1
>

This debug code wasn't supposed to be here (in fact I didn't expect
this WIP/draft PR to get mailed out), please see the latest version at
https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20494

Best,
Tristan
_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org

      reply	other threads:[~2025-09-11 18:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-11 17:27 [FFmpeg-devel] " tmatth via ffmpeg-devel
2025-09-11 18:17 ` Tristan Matthews via ffmpeg-devel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAN8HRD=Vjsg6SDJZxv_p0bva2wWFgFSor9TBxqh4G8vYAZMcYg@mail.gmail.com' \
    --to=ffmpeg-devel@ffmpeg.org \
    --cc=code@ffmpeg.org \
    --cc=tmatth@videolan.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git