From: Tristan Matthews <tmatth@videolan.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/1] fate/opus: add silk LBRR test (refs #9890)
Date: Fri, 23 Sep 2022 15:04:17 -0400
Message-ID: <CAN8HRD=DCEz0uN2fg1J6OdqZHypntZmf20i3wyfD7aHHqfy8-Q@mail.gmail.com> (raw)
In-Reply-To: <AS8P250MB07443792AB1332CDC4AE9A3C8F519@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>
On Fri, Sep 23, 2022 at 8:15 AM Andreas Rheinhardt
<andreas.rheinhardt@outlook.com> wrote:
>
> Tristan Matthews:
> > On Thu, Sep 8, 2022 at 3:58 PM Tristan Matthews <tmatth@videolan.org> wrote:
> >
> >> This adds a fate test for a sample with LBRR packets.
> >>
> >> It requires that these files be uploaded:
> >> https://people.videolan.org/~tmatth/9890-fate/silk-lbrr.mka
> >> https://people.videolan.org/~tmatth/9890-fate/silk-lbrr.dec
> >>
> >> ---
> >> tests/fate/opus.mak | 3 ++-
> >> 1 file changed, 2 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/tests/fate/opus.mak b/tests/fate/opus.mak
> >> index 573044ed15..7d359f414a 100644
> >> --- a/tests/fate/opus.mak
> >> +++ b/tests/fate/opus.mak
> >> @@ -4,7 +4,7 @@
> >>
> >> OPUS_CELT_SAMPLES = $(addprefix testvector, 01 11) tron.6ch.tinypkts
> >> OPUS_HYBRID_SAMPLES = $(addprefix testvector, 05 06)
> >> -OPUS_SILK_SAMPLES = $(addprefix testvector, 02 03 04)
> >> +OPUS_SILK_SAMPLES = $(addprefix testvector, 02 03 04) silk-lbrr
> >> OPUS_OTHER_SAMPLES = $(addprefix testvector, 07 08 09 10 12)
> >>
> >> define FATE_OPUS_TEST
> >> @@ -33,6 +33,7 @@ fate-opus-testvector09: CMP_TARGET = 0
> >> fate-opus-testvector10: CMP_TARGET = 38
> >> fate-opus-testvector11: CMP_TARGET = 0
> >> fate-opus-testvector12: CMP_TARGET = 160
> >> +fate-opus-silk-lbrr: CMP_TARGET = 0
> >> fate-opus-tron.6ch.tinypkts: CMP_SHIFT = 1440
> >> fate-opus-tron.6ch.tinypkts: CMP_TARGET = 0
> >>
> >> --
> >> 2.34.1
> >>
> >
> >
> > Sorry this was supposed to be in response to
> > http://ffmpeg.org/pipermail/ffmpeg-devel/2022-August/300758.html (as it
> > depends on it) but I screwed up the git-send-email.
> >
>
> Does this sample have to be so long?
I've shortened it from 4 seconds to 1 second (which is still long
enough to hear the bug when using an older build).
Note that most of the opus test vectors are on the order of 25 seconds.
Best,
Tristan
>
> - Andreas
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-09-23 19:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-31 18:32 [FFmpeg-devel] [PATCH 1/1] opus_silk: reset midonly flag after skipping LBRR Tristan Matthews
2022-09-08 19:57 ` [FFmpeg-devel] [PATCH 1/1] fate/opus: add silk LBRR test (refs #9890) Tristan Matthews
2022-09-08 20:01 ` Tristan Matthews
2022-09-23 12:15 ` Andreas Rheinhardt
2022-09-23 19:04 ` Tristan Matthews [this message]
2022-09-30 13:53 ` Tristan Matthews
2022-10-04 9:05 ` Anton Khirnov
2022-09-15 17:59 ` [FFmpeg-devel] [PATCH 1/1] opus_silk: reset midonly flag after skipping LBRR Tristan Matthews
2022-09-23 11:43 ` Tristan Matthews
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAN8HRD=DCEz0uN2fg1J6OdqZHypntZmf20i3wyfD7aHHqfy8-Q@mail.gmail.com' \
--to=tmatth@videolan.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git