From: Connor Worley <connorbworley@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 2/2] lavc/dxvenc: migrate DXT1 encoder to lavu hashtable
Date: Mon, 5 Feb 2024 12:46:49 -0800
Message-ID: <CAN7ZixyS9g5QeY-WJ7JUBH647SB5NF_z14CYEzs8+3UyongHfw@mail.gmail.com> (raw)
In-Reply-To: <AS8P250MB0744C0A857D8EECF7C0305F98F472@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>
On Mon, Feb 5, 2024 at 12:06 PM Andreas Rheinhardt <
andreas.rheinhardt@outlook.com> wrote:
> Connor Worley:
> >>
> >> How much would one gain if the hash function knew that key_size and
> >> val_size are four?
> >>
> >
> > That yields a nice 10-20% speedup on my machine. Are you thinking of
> macros
> > to parametrize key/val size, or possibly optimized versions for common
> > sizes?
>
> I am thinking about it not being public at all; as long as we have only
> one user...
>
That's fair. I will need some variants for future DXV work, but they can
also be private if this doesn't seem generally useful.
PS: Is the speedup only for the hashing part or for overall decoding? Is
> the comparison the current version of your patch or something that
> already has my comments incorporated?
>
Overall encoding -- current version of my patch with ctx->key/val_size vs
hardcoded sizes.
--
Connor Worley
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-02-05 20:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-05 5:27 [FFmpeg-devel] [PATCH 1/2] lavu/hashtable: create generic robin hood hash table Connor Worley
2024-02-05 5:27 ` [FFmpeg-devel] [PATCH 2/2] lavc/dxvenc: migrate DXT1 encoder to lavu hashtable Connor Worley
2024-02-05 12:04 ` Andreas Rheinhardt
2024-02-05 19:57 ` Connor Worley
2024-02-05 20:08 ` Andreas Rheinhardt
2024-02-05 20:46 ` Connor Worley [this message]
2024-02-05 12:00 ` [FFmpeg-devel] [PATCH 1/2] lavu/hashtable: create generic robin hood hash table Andreas Rheinhardt
2024-02-06 5:00 ` Connor Worley
2024-02-06 10:13 ` Connor Worley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAN7ZixyS9g5QeY-WJ7JUBH647SB5NF_z14CYEzs8+3UyongHfw@mail.gmail.com \
--to=connorbworley@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git